Fix majority of remaining yamllint warnings and errors

Signed-off-by: Ryan Lerch <rlerch@redhat.com>

roles/abrt/faf-post/tasks/main.yml

@@ -9,7 +9,7 @@
     state: directory
     owner: faf
     group: faf
-    mode: 0750
+    mode: "0750"
   when: env != 'staging'
 
 - import_tasks: cron.yml

roles/abrt/faf-pre/tasks/main.yml

@@ -28,18 +28,18 @@
     - { src: "{{private}}/files/rabbitmq/{{env}}/pki/ca.crt",
         dest: "ca.crt",
         owner: faf,
-        mode: 0644
-      }
+        mode: "0644"
+    }
     - { src: "{{private}}/files/rabbitmq/{{env}}/pki/private/faf{{env_suffix}}.key",
         dest: "faf.key",
         owner: faf,
         mode: "600"
-      }
+    }
     - { src: "{{private}}/files/rabbitmq/{{env}}/pki/issued/faf{{env_suffix}}.crt",
         dest: "faf.crt",
         owner: faf,
-        mode: 0644
-      }
+        mode: "0644"
+    }
 
 # landing page
 - name: install abrt-server-info-page

roles/abrt/faf-pre/tasks/ssl.yml

@@ -7,14 +7,14 @@
   - letsencrypt is defined
 
 - name: stop httpd when letsencrypt has not been run
-  service:                                                                                                               
+  service:
     name: httpd
     state: stopped
   when:
   - letsencrypt is defined
   - not item.stat.exists
   with_items: "{{ le_stat_checks.results }}"
-  
+
 
 - name: install letsencrypt ssl certificates for dev
   include_role: name=copr/certbot

roles/abrt/faf/.github/workflows/ansible-lint.yml

@@ -1,10 +1,11 @@
+---
 name: Check Ansible Role
 
-on:
+on: # yamllint disable-line rule:truthy
   push:
-    branches: [ master ]
+    branches: [master]
   pull_request:
-    branches: [ master ]
+    branches: [master]
 
 jobs:
   lint:
@@ -17,7 +18,7 @@ jobs:
 
     # This can be pinned to a specific tag after something newer than v4.1.0.post0 materializes.
     # https://github.com/ansible/ansible-lint-action/commit/91db49755c0e720d9eac9d3a481c227d3d14faf6
-    - name: Lint 
+    - name: Lint
       uses: ansible/ansible-lint-action@master
       with:
         targets: ./

roles/abrt/faf/defaults/main.yml

@@ -39,7 +39,7 @@ faf_web_on_root: false
 # [MAIN]
 faf_plugins_dir: /etc/faf/plugins/
 faf_templates_dir: /etc/faf/templates/
-faf_autoenableplugins: False
+faf_autoenableplugins: false
 
 # [STORAGE]
 # variables used to automatically create a connectstring
@@ -62,11 +62,11 @@ faf_from: no-reply@localhost
 
 # [uREPORT]
 faf_spool_dir: /var/spool/faf
-faf_create_components: False
+faf_create_components: false
 
 # Allow uReports without affected package - meaning that crashing code was
 # not packaged
-faf_allow_unpackaged: False
+faf_allow_unpackaged: false
 
 ###########################
 # faf-webui configuration #

roles/abrt/faf/meta/main.yml

@@ -6,13 +6,13 @@ galaxy_info:
   license: BSD
   min_ansible_version: 2.5
   platforms:
-   - name: EL
-     versions:
-      - 8
-   - name: Fedora
-     versions:
-      - 29
-      - 30
+    - name: EL
+      versions:
+        - 8
+    - name: Fedora
+      versions:
+        - 29
+        - 30
   galaxy_tags:
-   - web
+    - web
 dependencies: []

roles/abrt/faf/tasks/celery.yml

@@ -1,3 +1,4 @@
+---
 - name: install faf web celery packages
   package:
     name: "{{ faf_web_celery_packages }}"

roles/abrt/faf/tasks/check_web.yml

@@ -1,6 +1,6 @@
-
 # check web functionality
 #
+---
 - name: Set URL facts
   set_fact:
     main_url: "https://{{ ansible_default_ipv4.address }}{{ url_suffix }}"

roles/abrt/faf/tasks/config.yml

@@ -11,7 +11,7 @@
     path: /etc/fedora-messaging/
     owner: root
     group: root
-    mode: 0755
+    mode: "0755"
     state: directory
   when: faf_with_fedmsg|bool
 

roles/abrt/faf/tasks/main.yml

@@ -1,3 +1,4 @@
+---
 - import_tasks: install.yml
   tags: [faf, faf_install, packages]
 

roles/abrt/faf/tasks/web.yml

@@ -1,4 +1,4 @@
-
+---
 - name: Set url_suffix fact
   set_fact:
     url_suffix: ""

roles/abrt/requirements.yml

@@ -1,4 +1,5 @@
 # Install a role from GitHub
+---
 - name: faf
   src: https://github.com/abrt/ansible-role-faf.git
   version: master

roles/abrt/retrace-post/tasks/retrace_setup.yml

@@ -1,6 +1,6 @@
 ---
 
-#long running tasks - run them in background - we do not actually care about the results
+# long running tasks - run them in background - we do not actually care about the results
 - name: reposync for fedora
   shell: nohup retrace-server-reposync fedora {{ item[0] }} {{ item[1] }} </dev/null >$(mktemp /tmp/ansible.reposync_for_fedoraXXXXXX.log) &
   loop: "{{ rs_internal_fedora_vers | product(rs_internal_arch_list) | list }}"
@@ -20,20 +20,20 @@
 - file:
     path: /srv/retrace/repos
     state: directory
-    mode: 0755
+    mode: "0755"
     owner: retrace
     group: retrace
 
 - file:
     path: /srv/retrace/tasks
     state: directory
-    mode: 0755
+    mode: "0755"
     owner: retrace
     group: retrace
 
 - file:
     path: /srv/retrace/hardlink-local
     state: directory
-    mode: 0755
+    mode: "0755"
     owner: retrace
     group: retrace

roles/abrt/retrace-pre/tasks/main.yml

@@ -47,7 +47,7 @@
   file:
     path: /srv/retrace/repos
     state: directory
-    mode: 0755
+    mode: "0755"
     owner: retrace
     group: retrace
 
@@ -55,13 +55,13 @@
   file:
     path: /srv/retrace/tasks
     state: directory
-    mode: 0755
+    mode: "0755"
     owner: retrace
     group: retrace
 
 - file:
     path: /srv/retrace/hardlink-local
     state: directory
-    mode: 0755
+    mode: "0755"
     owner: retrace
     group: retrace

roles/abrt/retrace/.github/workflows/ansible-lint.yml

@@ -1,10 +1,11 @@
+---
 name: Check Ansible Role
 
-on:
+on: # yamllint disable-line rule:truthy
   push:
-    branches: [ master ]
+    branches: [master]
   pull_request:
-    branches: [ master ]
+    branches: [master]
 
 jobs:
   lint:
@@ -15,7 +16,7 @@ jobs:
     - name: Check out sources
       uses: actions/checkout@v2
 
-    - name: Lint 
+    - name: Lint
       uses: ansible/ansible-lint-action@master
       with:
         targets: ./

roles/abrt/retrace/meta/main.yml

@@ -5,14 +5,14 @@ galaxy_info:
   license: BSD
   min_ansible_version: 2.8
   platforms:
-   - name: EL
-     versions:
-      - 7
-      - 8
-   - name: Fedora
-     versions:
-      - 33
-      - 34
-      - 35
+    - name: EL
+      versions:
+        - 7
+        - 8
+    - name: Fedora
+      versions:
+        - 33
+        - 34
+        - 35
   galaxy_tags:
-   - system
+    - system

roles/abrt/retrace/tasks/config.yml

@@ -3,19 +3,19 @@
   template:
     src: etc-retrace-server.conf.j2
     dest: /etc/retrace-server/retrace-server.conf
-    mode: 0644
+    mode: "0644"
   notify: restart httpd
 
 - name: retrace-server http config
   template:
     src: retrace-server-httpd.conf.j2
     dest: /etc/httpd/conf.d/retrace-server-httpd.conf
-    mode: 0644
+    mode: "0644"
   notify: restart httpd
 
 - name: configure retrace-server hooks config
   template:
     src: etc-retrace-server-hooks.conf.j2
     dest: /etc/retrace-server/retrace-server-hooks.conf
-    mode: 0644
+    mode: "0644"
   notify: restart httpd