From cdd3b93a04783ff669d528f8d1d9cef1a18b58bd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADt=20Smol=C3=ADk?= <me@smoliicek.cz>
Date: Thu, 7 Aug 2025 17:47:41 +0200
Subject: [PATCH] fix (most) lint problems on update_all and update_all-stg (+
 comments)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Vít Smolík <me@smoliicek.cz>
---
 playbooks/manual/update_all-stg.yml | 30 ++++++++++-------------------
 playbooks/manual/update_all.yml     |  3 +--
 2 files changed, 11 insertions(+), 22 deletions(-)

diff --git a/playbooks/manual/update_all-stg.yml b/playbooks/manual/update_all-stg.yml
index c24ab9f608..e824036348 100644
--- a/playbooks/manual/update_all-stg.yml
+++ b/playbooks/manual/update_all-stg.yml
@@ -1,25 +1,14 @@
+# Copr and openqa system have their updates scheduled separatley, skipping them here.
+# Ocp and worker systems are excluded, openshift manages it's own updates.
+
+# For updating all staging systems, please use manual/update_all-stg.yml
+
 ---
-- name: Set downtime
-  hosts: staging:!copr*:!openqa*:!ocp*:!worker*
-  gather_facts: false
+- name: Update all staging systems
+  hosts: staging*:!copr*:!openqa*:!ocp*:!worker*
   user: root
-  serial: 1
-
   tasks:
 
-  - name: Schedule regular host downtime
-    nagios: action=downtime minutes=30 service=host host={{ inventory_hostname_short }}{{ env_suffix }}
-    delegate_to: noc01.rdu3.fedoraproject.org
-    ignore_errors: true
-    failed_when: no
-    when: nonagios is not defined or not "true" in nonagios
-
-- name: Update staging systems
-  hosts: staging:!copr*:!openqa*:!ocp*:!worker*
-  user: root
-  
-  tasks:
-  
   - name: Apply updates
     ansible.builtin.package:
       state: latest
@@ -29,7 +18,8 @@
     poll: 30
     when: package_excludes is not defined
 
-  - debug:
+  - name: Chech for package_excludes
+    ansible.builtin.debug:
       msg:
       - '!!!!!!!!!!!!!!!!!!! host {{ inventory_hostname }} has EXCLUDES OF {{ package_excludes }} !!!!!!!!!!!!!'
       - '!!!!!!!!!!!!!!!!!!! DANGER DANGER DANGER ^ CHECK THAT EXCLUDES ARE STILL NEEDED ^ !!!!!!!!!!!!!!!!!!!!'
@@ -48,7 +38,7 @@
 
 
 - name: Run rkhunter if installed
-  hosts: staging:!copr*:!openqa*:!ocp*:!worker*
+  hosts: staging*:!copr*:!openqa*:!ocp*:!worker*
   user: root
 
   tasks:
diff --git a/playbooks/manual/update_all.yml b/playbooks/manual/update_all.yml
index 9c7c9b5b0a..e770983725 100644
--- a/playbooks/manual/update_all.yml
+++ b/playbooks/manual/update_all.yml
@@ -7,9 +7,8 @@
 - name: Update all systems
   hosts: all:!copr*:!openqa*:!ocp*:!worker*:!staging*
   user: root
-  
   tasks:
-  
+
   - name: Apply updates
     ansible.builtin.package:
       state: latest