This will unify all the handlers to use first uppercase letter for
ansible-lint to stop complaining.
I went through all `notify:` occurrences and fixed them by running
```
set TEXT "text_to_replace"; set REPLACEMENT "replacement_text"; git grep
-rlz "$TEXT" . | xargs -0 sed -i "s/$TEXT/$REPLACEMENT/g"
```
Then I went through all the changes and removed the ones that wasn't
expected to be changed.
Fixes https://pagure.io/fedora-infrastructure/issue/12391
Signed-off-by: Michal Konecny <mkonecny@redhat.com>
fix 1900 failures of the following case issue:
`name[casing]: All names should start with an uppercase letter.`
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
The task is otherwise very racy:
fatal: [copr-keygen.aws.fedoraproject.org]: FAILED! => {"changed":
false, "msg": "path /var/lib/copr-keygen/gnupg/.#....copr-keygen.aws.fedoraproject.org....
does not exist", "path": "/var/lib/copr-keygen/gnupg/.#l....copr-keygen.aws.fedoraproject.org...."}
Otherwise we risk a conflict with other automatically allocated users,
right now it is:
fatal: [copr-keygen-dev.aws.fedoraproject.org]: FAILED! => {"changed": false, "msg": "useradd: UID 992 is not unique\n", "name": "copr-signer", "rc": 4}
This used to be a role-specific handler, though we have a special
upgrade playbooks (e.g. copr-keygen-upgrade.yml) that failed because
they use but don't import the copr/* roles (and role handlers). So we
would have to either import role-specific handlers explicitly, or do
this commit.
We need to have YYYY-MM-DD in file name to actually have correct
incremental backups. Since we don't overwrite the old backup files now
and we have different filename each day, let's remove the old backup
files and keep only the last one (this is to mimic what happens with DB
backups on copr frontend, which runs
roles/postgresql_server/files/backup-database).
While on it, let's double-quote variable uses.
Per advice in:
https://pagure.io/fedora-infrastructure/issue/8904
[DEPRECATION WARNING]: evaluating devel as a bare variable, this
behaviour will go away and you might need to add |bool to the expression
in the future. Also see CONDITIONAL_BARE_VARS configuration toggle..
This feature will be removed in
version 2.12. Deprecation warnings can be disabled by setting
deprecation_warnings=False in ansible.cfg.
There is a problem with our current playbooks, that they can be
executed automatically without us knowing about it. That is an issue
particularly during release process because we can prepare new
packages into infra-tags repo or bodhi and a nightly reprovision
can upgrade to them outside of an outage window or any of us being
prepared for it.
Therefore `groups/copr-*.yml` playbooks *should not* upgrade any
packages, but only ensure, that those packages are installed. For
upgrade, there should be separate `manual/copr/copr-*-upgrade.yml`
playbooks. Because they are located under `manual` directory, it
is secured, that they can't be run automatically.
