If we ever need to use a git sha here again we can just update the
fcos_cincinnati_git_ref vars the same way we did in the past. For
now let's just follow what's in the main branch.
As the previous change took no effect and the error while executing
`sudo rbac-playbook -l os_control_stg openshift-apps/coreos-cincinnati.yml`
continues to return an error as below, let's try another aproach.
```
"stderr": "The Deployment \"coreos-cincinnati\" is invalid: \n*
spec.template.spec.containers[0].image: Required value
```
Here adding a specific F42 image
During recent migration to deployment, the oc command:
`sudo rbac-playbook -l os_control_stg openshift-apps/coreos-cincinnati.yml`
returns an error:
```
"stderr": "The Deployment \"coreos-cincinnati\" is invalid: \n*
spec.template.spec.containers[0].image: Required value
```
This PR aims to fix the above.
When running
`sudo rbac-playbook -l os_control_stg openshift-apps/coreos-cincinnati.yml`
I came across the below errors due to recent migration to deployment and j2.
unknown field :\"spec.strategy
.activeDeadlineSeconds /.recreateParams /.resources /.rollingParams /.name
This should fix all of the above.
This commit makes the coreos-cincinnati setup look similar to the
other CoreOS/OSTree apps that we own. Notable changes:
- We are still building via commit, we only track a single commit
and not a separate deploy/build one.
- We are now just outputting to a coreos-cincinnati-img:latest
imagestream tag.
- We are now using a fedora:38 imagestream tag as the from: in our
build and triggering new builds based on imagestream updates,
which means we'll get security updates more regularly.
- A bunch of quoting (") in yaml files was removed as it clouded the
diffs between this app and other apps.
- Some minor diffs between playbooks and other files were removed.
As part of an effort to make coreos-cincinnati look like the rest
of the CoreOS Apps we'll move all files into the templates dir
(because even if they aren't templatized they still work there)
and rename `buildconfig-stub.yml` to `buildconfig.yml`.
