Commit Graph

48 Commits

Author SHA1 Message Date
Michal Konecny
2ec055db6f Use first uppercase letter for all handlers
This will unify all the handlers to use first uppercase letter for
ansible-lint to stop complaining.

I went through all `notify:` occurrences and fixed them by running
```
set TEXT "text_to_replace"; set REPLACEMENT "replacement_text"; git grep
-rlz "$TEXT" . | xargs -0 sed -i "s/$TEXT/$REPLACEMENT/g"
```

Then I went through all the changes and removed the ones that wasn't
expected to be changed.

Fixes https://pagure.io/fedora-infrastructure/issue/12391

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2025-02-10 20:31:49 +00:00
Ryan Lerch
25391e95b7 ansiblelint fixes - fqcn[action-core] - package to ansible.builtin.package
Replaces many references to  package: with ansible.builtin.package

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:28:00 +10:00
Ryan Lerch
6a3816dfdc ansiblelint fixes-- fqcn[action-core] - copy to ansible.builtin.copy
Replaces many references to 'copy' with ansible.builtin.copy

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:43:31 +10:00
Ryan Lerch
691adee6ee Fix name[casing] ansible-lint issues
fix 1900 failures of the following case issue:

`name[casing]: All names should start with an uppercase letter.`

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-14 20:20:07 +10:00
Ryan Lerch
89f6f1fc32 Fix majority of remaining yamllint warnings and errors
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-11-28 17:31:45 +10:00
Stephen Smoogen
432a3a497b Go through and remove entries for EL6 and EL7
Using `git grep el6` and `git grep el7` and variants like EL-7 or
el-7, I found various entries and files which were no longer needed
with the current ansible. I updated text or tests to later versions of
RHEL as needed.

found entries for the fedora ami's for the original cloud and removed
those entries also.

Signed-off-by: Stephen Smoogen <ssmoogen@redhat.com>
2024-07-03 22:20:30 +00:00
Kevin Fenzi
c902575f49 openvpn / base: clean up more RedHat and el6 conditionals
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2021-04-16 14:32:36 -07:00
Kevin Fenzi
81fb4582e7 ansible: change when conditions to use == instead of is when checking strings.
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-04-24 21:34:10 +02:00
Kevin Fenzi
a562b8a3f8 ansible_distribution_version: address FIXME's/review tweaks.
download: mod_limitipconn isn't used anyone, dropped the entire line.
transient_cloud: just dropped the dnf part and use 'package' entirely.
sshd_config: UsePrivilegeSeparation isn't used in Fedora at all.
koji_hub: no fedora or rhel8 hubs yet, so just 7 is fine for now.
openvpn: changes look ok
packages3: Should get cverna to review, packages is using fedora now.
varnish: no rhel8 varnish servers yet.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-04-24 21:34:10 +02:00
Karsten Hopp
c9ed62ac32 update ansible_distribution_major_version conditionals
Signed-off-by: Karsten Hopp <karsten@redhat.com>
2020-04-24 21:34:10 +02:00
Karsten Hopp
60c2d50072 openvpn: dnf -> package, with_item changes 2019-06-11 15:00:23 +00:00
Patrick Uiterwijk
a1b11705e7 Fix ca.crt path
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2018-08-17 04:30:09 +00:00
Patrick Uiterwijk
936e8b261a yum accepted pkg=, package calls it name=
Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
2017-10-09 00:38:26 +02:00
Patrick Uiterwijk
adcbf72f03 Packageize this, packageize that, packageize the world
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2017-10-08 22:25:52 +00:00
Kevin Fenzi
0ed471745c add correct tags here so openvpn is installed 2017-08-22 22:47:14 +00:00
Kevin Fenzi
636d7623ad try and use correct logic 2017-05-14 23:36:21 +00:00
Kevin Fenzi
489dd32e32 and also handle it here 2017-05-14 23:30:27 +00:00
Kevin Fenzi
52318bbc49 try and handle cases for f24 not being updated to the new setup either 2017-05-14 23:26:45 +00:00
Kevin Fenzi
f381865238 handle server dh file 2017-05-14 22:31:19 +00:00
Kevin Fenzi
f12de13a1f someday I will get these versions all right 2017-05-14 21:59:08 +00:00
Kevin Fenzi
8c4162eaa4 fix version for rhel 2017-05-14 21:54:22 +00:00
Kevin Fenzi
714506a905 handle poor old rhel6 2017-05-14 21:51:47 +00:00
Kevin Fenzi
f400f56c6b fix handlers and disable notify for now until we roll this out 2017-05-14 21:38:08 +00:00
Kevin Fenzi
4629c0aa58 also install the ca in the right place 2017-05-14 21:02:27 +00:00
Tim Flink
bf03de72d0 fixing logic for openvpn package install w/dnf 2015-11-26 01:27:59 +00:00
Pierre-Yves Chibon
a7e6225b8f Fix indentation 2015-11-17 15:27:42 +01:00
Pierre-Yves Chibon
27910ddaef Install the package with dnf on F22+ 2015-11-17 15:27:05 +01:00
Patrick Uiterwijk
032376de7e Tag the fix-routes.sh play 2015-11-04 23:11:52 +00:00
Patrick Uiterwijk
fe6f551049 Move fix-routes.sh to openvpn base and run it on restart
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2015-11-04 23:09:43 +00:00
Kevin Fenzi
2873cdd427 Move all puppet_private stuff to ansible private so we can stop using puppet private. 2015-09-25 18:16:23 +00:00
Praveen Kumar
4b1e5162d7 Update state from installed/removed to present/absent for yum module as per latest documents -> http://docs.ansible.com/yum_module.html 2014-11-05 15:32:11 +00:00
Tim Flink
6de91bb7f6 missed a openvpn restart notification in base 2014-09-24 17:57:42 +00:00
Ralph Bean
e44d66b9e1 I think this is a typo. 2014-09-10 19:28:49 +00:00
Kevin Fenzi
b43f8e30b3 Try copy 2014-08-12 03:41:16 +00:00
Kevin Fenzi
c744698e0c Tweak openvpn base and keys 2014-08-12 03:36:21 +00:00
Pierre-Yves Chibon
27810d09ca Comment out the crl.pem, it's not used anywhere 2014-08-01 18:30:52 +02:00
Pierre-Yves Chibon
6142a27e19 Move back from copy to file for testing 2014-08-01 17:08:49 +02:00
Pierre-Yves Chibon
d26ae5df9f Use copy instead of file 2014-08-01 17:04:34 +02:00
Pierre-Yves Chibon
ecd9d72382 Try adjusting the notify handler 2014-08-01 16:52:39 +02:00
Pierre-Yves Chibon
27913def24 More quotes for the handler names 2014-08-01 16:45:57 +02:00
Pierre-Yves Chibon
584cda5968 Another try with quotes 2014-08-01 16:43:49 +02:00
Pierre-Yves Chibon
3248bc2878 Let's try quotes around the modes 2014-08-01 16:42:37 +02:00
Pierre-Yves Chibon
8de71b59e3 Tag all the openvpn tasks as 'openvpn' 2014-08-01 16:41:55 +02:00
Pierre-Yves Chibon
8a89bd9fff Fix accessing the mode 2014-08-01 16:34:21 +02:00
Pierre-Yves Chibon
8185a415d2 And we put directly the destination, no location set 2014-08-01 16:30:08 +02:00
Pierre-Yves Chibon
cf1f8dba40 What about quotes 2014-08-01 16:26:15 +02:00
Pierre-Yves Chibon
7f30c0fc7a Adjust the openvpn handler automatically to the distribution used 2014-08-01 12:35:11 +02:00
Pierre-Yves Chibon
e5ff3b586e Start the port to ansible of openvpn 2014-07-31 22:37:58 +02:00