Commit Graph

24 Commits

Author SHA1 Message Date
Michal Konecny
2ec055db6f Use first uppercase letter for all handlers
This will unify all the handlers to use first uppercase letter for
ansible-lint to stop complaining.

I went through all `notify:` occurrences and fixed them by running
```
set TEXT "text_to_replace"; set REPLACEMENT "replacement_text"; git grep
-rlz "$TEXT" . | xargs -0 sed -i "s/$TEXT/$REPLACEMENT/g"
```

Then I went through all the changes and removed the ones that wasn't
expected to be changed.

Fixes https://pagure.io/fedora-infrastructure/issue/12391

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2025-02-10 20:31:49 +00:00
Ryan Lerch
3c41882bb0 ansiblelint fixes - fqcn[action-core] - shell to ansible.builtin.shell
Replaces references to shell: with ansible.builtin.shell

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:29:10 +10:00
Ryan Lerch
462176464b ansiblelint fixes-- fqcn[action-core] - command to ansible.builtin.command
Replaces many references to  command: with ansible.builtin.command

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:26:47 +10:00
Ryan Lerch
62952df107 ansiblelint fixes-- fqcn[action-core] - file to ansible.builtin.file
Replaces many references to  file: with ansible.builtin.file

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:41:52 +10:00
Ryan Lerch
691adee6ee Fix name[casing] ansible-lint issues
fix 1900 failures of the following case issue:

`name[casing]: All names should start with an uppercase letter.`

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-14 20:20:07 +10:00
Ryan Lerch
89f6f1fc32 Fix majority of remaining yamllint warnings and errors
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-11-28 17:31:45 +10:00
Matěj Grabovský
a0d4beab0d retrace: Explicitly add opsys release; improve error handling
- Explicitly register supported CentOS and Fedora releases using
  `faf releaseadd`.
- Ignore "errors" of the "already defined" kind.
2022-02-23 13:04:16 +01:00
Matěj Grabovský
54ff2d749d retrace: Fix Fedora repo assignment again
Use the correct variable to loop over this time.
2021-09-16 20:25:09 +00:00
Matěj Grabovský
763612db97 retrace: Fix Fedora repo assignment
* Fix type error (`rs_internal_fedora_vers` is a list of numbers).
* Assign across all supported architectures.
2021-09-14 15:23:06 +02:00
Matěj Grabovský
7a65a7fb82 retrace: Move repo-related tasks to separate file 2021-09-10 15:35:41 +02:00
Matěj Grabovský
997508c26c retrace: Ignore errors in FAF packages cleanup
Ignore errors when cleaning up packages after removed releases -- the
releases might already be gone when cleanup-packages is run.

See also 9f64d9661 and c2ed129aa.
2021-06-21 11:52:25 +00:00
Matěj Grabovský
923368d85c retrace: Fix cron job definitions
* Fix line folding syntax. The previous version caused vertical
  whitespace to be included in the output which broke the crontab.
* Rename clean up job so that it doesn't contain any variables.
  Including variables in a name makes it difficult to remove or change
  the job when the variable changes.
* Code style consistency.
2021-06-18 16:03:53 +00:00
Matěj Grabovský
0505e365da retrace: Use variables for list of Fedora versions 2021-06-08 14:44:16 +02:00
Matěj Grabovský
6b57d23220 retrace: Fix faf db backup job
The job was broken before because the backup directory
(`/srv/faf/db-backup`) might not have existed.

Also, factor out some magic values into variables.
2021-06-08 14:44:16 +02:00
Matěj Grabovský
2ce5a4b91b retrace: Drop devel variable in favour of env
`env` seems to be the prevailing method of specifying production vs.
staging environments across groups and hosts.
2021-06-08 14:44:15 +02:00
Matěj Grabovský
4cfe740fc6 retrace: Improve code style
* Capitalise task names.
* Wrap shell commands in quotes.
* Use folded strings where appropriate.
* Wrap tasks with the same condition in a block.
2021-06-08 14:43:54 +02:00
Matěj Grabovský
9f64d96615 retrace: Manage FAF repositories on staging as well
* Drop the `not devel` flag on FAF repository management tasks.
* Ignore errors when deleting repositories -- they might be gone already
  when repodel is run.
2021-06-08 14:43:54 +02:00
Matěj Grabovský
b708714444 abrt: Fix become directive
`become` only accepts, not the user name which belongs in `become_user`.
2021-06-01 10:36:23 +02:00
Miroslav Suchý
5d2a203949 retrace: remove remains of f30 2020-09-22 21:02:26 +02:00
Miroslav Suchý
9493e96aa5 retrace: add f33 2020-09-22 21:02:26 +02:00
Miroslav Suchý
d1fe25a12a retrace: type yum->dnf 2020-09-21 17:04:42 +02:00
Miroslav Suchý
21170d4680 retrace: remove f29 from faf 2020-04-24 21:34:26 +02:00
Michal Fabik
ce47bc3544 retrace: Add Fedora 32 to retrace
Signed-off-by: Michal Fabik <mfabik@redhat.com>
Signed-off-by: Miroslav Suchý <msuchy@redhat.com>
2020-04-24 21:34:26 +02:00
Ernestas Kulik
45d448ae5b Rename local retrace roles
The “local” bit is quite redundant and they are otherwise confusingly
named.
2020-04-24 21:34:23 +02:00