Commit Graph

61 Commits

Author SHA1 Message Date
Michal Konecny
2ec055db6f Use first uppercase letter for all handlers
This will unify all the handlers to use first uppercase letter for
ansible-lint to stop complaining.

I went through all `notify:` occurrences and fixed them by running
```
set TEXT "text_to_replace"; set REPLACEMENT "replacement_text"; git grep
-rlz "$TEXT" . | xargs -0 sed -i "s/$TEXT/$REPLACEMENT/g"
```

Then I went through all the changes and removed the ones that wasn't
expected to be changed.

Fixes https://pagure.io/fedora-infrastructure/issue/12391

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2025-02-10 20:31:49 +00:00
Michal Konecny
7b58dfdce8 Remove fedmsg and github2fedmsg from staging
The messaging bridges openshift project and github2fedmsg VM were
already removed in staging. This is to clean the ansible playbooks.

I will create a separate one for production after this one is merged.

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2025-02-04 09:13:40 +01:00
Ryan Lerch
47c68f478d ansiblelint fixes - fqcn[action-core] - template to ansible.builtin.template
Replaces references to template: with ansible.builtin.template

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:30:29 +10:00
Ryan Lerch
3c41882bb0 ansiblelint fixes - fqcn[action-core] - shell to ansible.builtin.shell
Replaces references to shell: with ansible.builtin.shell

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:29:10 +10:00
Ryan Lerch
25391e95b7 ansiblelint fixes - fqcn[action-core] - package to ansible.builtin.package
Replaces many references to  package: with ansible.builtin.package

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:28:00 +10:00
Ryan Lerch
462176464b ansiblelint fixes-- fqcn[action-core] - command to ansible.builtin.command
Replaces many references to  command: with ansible.builtin.command

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:26:47 +10:00
Ryan Lerch
6a3816dfdc ansiblelint fixes-- fqcn[action-core] - copy to ansible.builtin.copy
Replaces many references to 'copy' with ansible.builtin.copy

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:43:31 +10:00
Ryan Lerch
62952df107 ansiblelint fixes-- fqcn[action-core] - file to ansible.builtin.file
Replaces many references to  file: with ansible.builtin.file

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:41:52 +10:00
Ryan Lerch
691adee6ee Fix name[casing] ansible-lint issues
fix 1900 failures of the following case issue:

`name[casing]: All names should start with an uppercase letter.`

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-14 20:20:07 +10:00
Ryan Lerch
89f6f1fc32 Fix majority of remaining yamllint warnings and errors
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-11-28 17:31:45 +10:00
Aurélien Bompard
3f8cd023f9 Syntax error
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2023-05-26 12:23:09 +02:00
Aurélien Bompard
7b2ab9e07f Improve the common collectd selinux module
- Add a workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1731501
- Update the playbook to support module upgrades, not only fresh
  installs

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2023-05-26 12:21:59 +02:00
Kevin Fenzi
0aeb60adea collectd: add to selinux policy to prevent denied read for proc/net
Should fix up these messages from all machines:
audit[865]: AVC avc:  denied  { read } for  pid=865 comm="reader#2" name="net" dev="proc" ino=4026531845 scontext=system_u:system_r:collectd_t:s0 tcontext=system_u:object_r:proc_net_t:s0 tclass=lnk_file permissive=0
audit[865]: AVC avc:  denied  { read } for  pid=865 comm="reader#2" name="net" dev="proc" ino=4026531845 scontext=system_u:system_r:collectd_t:s0 tcontext=system_u:object_r:proc_net_t:s0 tclass=lnk_file permissive=0

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2023-01-10 14:35:18 -08:00
Kevin Fenzi
81fb4582e7 ansible: change when conditions to use == instead of is when checking strings.
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-04-24 21:34:10 +02:00
Karsten Hopp
c9ed62ac32 update ansible_distribution_major_version conditionals
Signed-off-by: Karsten Hopp <karsten@redhat.com>
2020-04-24 21:34:10 +02:00
Kevin Fenzi
a8714caab3 first cut at changing all the old |changed to is changed per ansible deprecations 2018-05-07 23:51:48 +00:00
Kevin Fenzi
a3d3003eb6 remove graphite config entirely 2018-03-05 18:59:18 +00:00
Kevin Fenzi
2cce3883a3 drop collectd graphite plugin 2018-03-05 17:59:38 +00:00
Patrick Uiterwijk
adcbf72f03 Packageize this, packageize that, packageize the world
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2017-10-08 22:25:52 +00:00
Kevin Fenzi
8a6e51a9a6 change state=running to start=started as the old one is going away in ansible 2.7 2017-04-13 01:37:21 +00:00
Peter Robinson
89fb80cac1 collectd: don't exclude aarch64 for collectd-apache 2017-01-19 12:22:53 +00:00
Kevin Fenzi
2f2108a0d5 No collectd for epel7/aarch64 yet, so don't try and install it here. 2016-12-03 03:39:19 +00:00
Tim Flink
4de5fadfa8 making collectd-apache work for fedora 2016-12-01 18:34:57 +00:00
Kevin Fenzi
067d1da6f6 how about this 2016-12-01 04:01:10 +00:00
Kevin Fenzi
7d7f9ccf76 move enable to end of the tasks 2016-12-01 03:52:21 +00:00
Kevin Fenzi
8562a31119 try this 2016-12-01 03:48:25 +00:00
Adam Williamson
a34ed59a8c roles/collectd: install collectd-disk on F25+
Plugin was split into a subpackage in F25.
2016-11-28 19:05:14 -08:00
Kevin Fenzi
b1a2d105c9 In ansible 2.2 always_run is depreciated. Switch to check_mode. 2016-11-01 16:29:49 +00:00
Kevin Fenzi
1c6e9a11f4 Another pile of trailing whitespace fixes 2016-08-08 19:42:36 +00:00
Ricky Elrod
80ccef429e Fix a todo in the collectd role for bind stats
Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
2016-06-30 09:05:34 +00:00
Kevin Fenzi
c4483d8dc4 Another try to exclude beaker hosts 2016-06-25 19:03:51 +00:00
Kevin Fenzi
c011dc8376 Fix copy pasta 2015-11-09 17:51:30 +00:00
Kevin Fenzi
f89ce31b91 And some more 2015-11-09 17:49:49 +00:00
Ricky Elrod
5f5d52c85b Allow collectd to access tcp when collectd_graphite is defined too
Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
2015-06-14 00:16:39 +00:00
Ricky Elrod
74a668ce1a copy over nfs.conf as well
Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
2015-06-10 22:15:52 +00:00
Ricky Elrod
9732b1345f qualify the environment
Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
2015-06-05 21:56:28 +00:00
Ricky Elrod
37a27645fc start of collectd graphite testing
Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
2015-06-05 08:55:14 +00:00
Ricky Elrod
3d4129dd78 install libsemanage-python to set an sebool for collectd
Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
2015-05-28 18:09:03 +00:00
Kevin Fenzi
275f4b5203 Change all instances of ansible_distribution_major_version to filter to int for comparisons. 2015-05-27 22:27:39 +00:00
Ricky Elrod
534f2d2bee Merge branch 'sebool' 2015-05-26 08:28:56 +00:00
Ricky Elrod
c5ae02db25 [collectd/base] re-resolve dns lookup after a few hours if it fails
see: https://github.com/collectd/collectd/pull/732

Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
2015-05-25 19:42:22 +00:00
Ricky Elrod
9b3821d1b9 Toggle sebool and fix missing Instance tag to collectd-apache working
Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
2015-05-25 19:28:08 +00:00
Ricky Elrod
3e14b73e11 Revert "Test defining collectd_apache in the apache role. Temporarily limit the effect of this variable to stg to avoid needing a freeze break until I test it."
This reverts commit 8f182ff510.
2015-05-25 04:32:03 +00:00
Ricky Elrod
482b0396d6 Revert "syntax"
This reverts commit 74ad22a53d.
2015-05-25 04:31:09 +00:00
Ricky Elrod
74ad22a53d syntax
Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
2015-05-25 04:27:33 +00:00
Ricky Elrod
8f182ff510 Test defining collectd_apache in the apache role. Temporarily limit the effect of this variable to stg to avoid needing a freeze break until I test it.
Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
2015-05-25 04:23:56 +00:00
Ralph Bean
8afb3582e8 Add forgotten tags. 2014-11-17 15:10:34 +00:00
Ralph Bean
a3960fa0fd Forgot these bits. 2014-11-17 15:06:52 +00:00
Ralph Bean
c8ef71fc22 Change these names too. 2014-11-17 15:05:40 +00:00
Ralph Bean
7d9fedb942 whitespace. 2014-11-17 02:32:09 +00:00