Commit Graph

31 Commits

Author SHA1 Message Date
Michal Konecny
2ec055db6f Use first uppercase letter for all handlers
This will unify all the handlers to use first uppercase letter for
ansible-lint to stop complaining.

I went through all `notify:` occurrences and fixed them by running
```
set TEXT "text_to_replace"; set REPLACEMENT "replacement_text"; git grep
-rlz "$TEXT" . | xargs -0 sed -i "s/$TEXT/$REPLACEMENT/g"
```

Then I went through all the changes and removed the ones that wasn't
expected to be changed.

Fixes https://pagure.io/fedora-infrastructure/issue/12391

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2025-02-10 20:31:49 +00:00
Ryan Lerch
47c68f478d ansiblelint fixes - fqcn[action-core] - template to ansible.builtin.template
Replaces references to template: with ansible.builtin.template

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:30:29 +10:00
Ryan Lerch
3c41882bb0 ansiblelint fixes - fqcn[action-core] - shell to ansible.builtin.shell
Replaces references to shell: with ansible.builtin.shell

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:29:10 +10:00
Ryan Lerch
25391e95b7 ansiblelint fixes - fqcn[action-core] - package to ansible.builtin.package
Replaces many references to  package: with ansible.builtin.package

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:28:00 +10:00
Ryan Lerch
62952df107 ansiblelint fixes-- fqcn[action-core] - file to ansible.builtin.file
Replaces many references to  file: with ansible.builtin.file

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:41:52 +10:00
Ryan Lerch
691adee6ee Fix name[casing] ansible-lint issues
fix 1900 failures of the following case issue:

`name[casing]: All names should start with an uppercase letter.`

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-14 20:20:07 +10:00
Ryan Lerch
89f6f1fc32 Fix majority of remaining yamllint warnings and errors
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-11-28 17:31:45 +10:00
Pavel Raiskup
9070b6eed7 copr/certbot: fixup synchronize sources 2022-02-02 21:54:53 +01:00
Pavel Raiskup
26f68acac5 copr/certbot: fix c&p issues from the previous experiment, #2 2022-02-02 21:42:45 +01:00
Pavel Raiskup
ccc039b325 copr/certbot: fix c&p issues from the previous experiment 2022-02-02 21:41:06 +01:00
Pavel Raiskup
01adf1cbd2 copr/certbot: typo in operator priority 2022-02-02 21:38:12 +01:00
Pavel Raiskup
a6585dc6ed copr/certbot: restore certs from a batcave dir
https://pagure.io/fedora-infrastructure/issue/10512
2022-02-02 21:29:18 +01:00
Pavel Raiskup
7c75eee9b3 copr/certbot: drop one leftover typo 2022-01-30 23:21:11 +01:00
Pavel Raiskup
47f1841494 copr/certbot: revert the automatic backup/restore of certs
For synchronizing from host A to host B we would have to have SSH
configured from A to B or from B to A (which we don't, and we don't even
want to).  The slurp solution would work, but certbot is pretty picky
WRT the restored /etc/letsencrypt directory (structure, filenames,
symlinks..).
2022-01-30 23:02:51 +01:00
Pavel Raiskup
38d6b8cc89 copr/certbot: missing tags/conditions 2022-01-30 22:13:45 +01:00
Pavel Raiskup
4044e7e518 copr/certbot: use rsync for copying the files
And copy the whole directory structure.
2022-01-30 22:09:42 +01:00
Pavel Raiskup
d257b20d2b copr/certbot: fixup prefix (it matters) 2022-01-30 21:13:21 +01:00
Pavel Raiskup
8d81803886 copr/certbot: combined.pem might be a symlink 2022-01-30 21:08:03 +01:00
Pavel Raiskup
9a49c2f1b4 copr/certbot: typo #2 2022-01-30 21:05:57 +01:00
Pavel Raiskup
0053ecf583 copr/certbot: typo 2022-01-30 21:02:55 +01:00
Pavel Raiskup
af11469b14 copr/certbot: better restoration
Certbot expects that the files in live/ directory are symlinks.
2022-01-30 21:00:43 +01:00
Pavel Raiskup
43ee0392b4 copr/certbot: fixup cert restoration
- no need to create another live/ sub-directory
- don't run the reload script when restored from backups
2022-01-30 20:08:40 +01:00
Pavel Raiskup
4adada983a copr/backend: restore letsencrypt cert from backup 2022-01-30 20:02:33 +01:00
Pavel Raiskup
6ed3c7d48e copr/certbot: tag the import as "always" 2022-01-30 18:55:08 +01:00
Pavel Raiskup
5c1bb52029 copr/certbot: tag all the certbot tags 2022-01-30 18:54:15 +01:00
Pavel Raiskup
9ce266360f copr/certbot: support certificate backup 2022-01-30 18:51:09 +01:00
Pavel Raiskup
06dcef4c38 certbot: typo in ACL specification 2021-12-07 14:25:01 +01:00
Pavel Raiskup
41c3c869aa certbot: document why Lighty needs the access to certbot's dirs 2021-12-07 14:22:41 +01:00
Pavel Raiskup
523be3de09 certbot: allow lighttpd to step into certbot dirs 2021-12-07 14:15:23 +01:00
Pavel Raiskup
6f35839b9e roles/copr/certbot: the trailing comma in webroot path isn't needed 2019-07-19 13:12:22 +02:00
Pavel Raiskup
3cc27430b6 copr: rework letsencrypt
We need two-phase configuration for Let's Encrypt:

1. initialize; the letsencrypt automation, this is happening only
   once per VM (when it is spawned)
2. periodic; using certbot-renew.timer.

Both those phases are now wrapped into copr/certbot role.

Phase 1. needs to be done before the web-server is started (so
include the role on appropriate place in the playbook), so we can
do 'certbot --standalone' (bounds to port 80).
Phase 2. is accomplished using the running web-server, using
'certbot renew --webroot'.

If (and only if) the certificate is renewed, web server needs to
be restarted (and lighttpd needs to have post-processed
certificate format).  So we also need the deploy hook script in
hand (two actually, lighttpd/httpd) so 'certbot renew'
automatically does what we expect it to do.
2019-07-19 11:20:00 +02:00