Commit Graph

244 Commits

Author SHA1 Message Date
Simon de Vlieger
1e777285e6 koji: image-builder for production
Enables the `image-builder` plugin from `koji-image-builder` in the
production environment for both the koji hub, and the koji builder
(kojid).

This is based on the earlier enablement in staging where I've
succesfully tested some builds and it didn't seem to bring down all of
the staging instance.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-04-28 18:58:22 +00:00
Simon de Vlieger
9f15884401 koji: image-builder for staging
Enables the `image-builder` plugin from `koji-image-builder` in the
staging environment for both the koji hub, and the koji builder (kojid).

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
2025-04-23 23:53:51 +00:00
Kevin Fenzi
fc5425c07f koji_builder: add a iptables tag to the osbuildapi scripting
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2025-04-19 09:17:09 -07:00
Kevin Fenzi
feb1bf9a97 koji_builder: syntax tweak
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2025-04-10 17:53:26 -07:00
James Antill
6af1918415 Conditionalize osbuild*.cron based on osbuild in group_names.
Signed-off-by: James Antill <james@and.org>
2025-04-11 00:33:11 +00:00
James Antill
50d04f6e95 Remove nftables cron and disable service, when using iptables (for backout).
Signed-off-by: James Antill <james@and.org>
2025-04-11 00:33:11 +00:00
Kevin Fenzi
5a44707cf4 koji_builder: install linux-firmware, not kernel-firmware
kernel-firmware is the old provide and it's no longer provided by newer
versions of linux-firmware. This is causing our builders to downgrade to
an older linux-firmware, then dnf-automatic just updates it the next
time to the newer one (because it's a security update).

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2025-04-01 13:54:51 -07:00
James Antill
e83b42b572 Remove iptables cron and stop/disable services, when using nftables.
Signed-off-by: James Antill <james@and.org>
2025-03-04 14:14:37 -05:00
James Antill
1c6c65844d Add new osbuildapi-update-nft.cron entries, and get it installed when nftables.
Signed-off-by: James Antill <james@and.org>
2025-03-03 21:20:30 +00:00
Michal Konecny
2ec055db6f Use first uppercase letter for all handlers
This will unify all the handlers to use first uppercase letter for
ansible-lint to stop complaining.

I went through all `notify:` occurrences and fixed them by running
```
set TEXT "text_to_replace"; set REPLACEMENT "replacement_text"; git grep
-rlz "$TEXT" . | xargs -0 sed -i "s/$TEXT/$REPLACEMENT/g"
```

Then I went through all the changes and removed the ones that wasn't
expected to be changed.

Fixes https://pagure.io/fedora-infrastructure/issue/12391

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2025-02-10 20:31:49 +00:00
Kevin Fenzi
8140d863f0 koji_builder: no longer install koji-containerbuild packages
These packages were used when we were building containers in OSBS, and
since we don't do that anymore, drop installing that anywhere.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2025-01-20 14:13:31 -08:00
Kevin Fenzi
d4523c609d koji_builder: fix another handler case
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2025-01-16 15:06:57 -08:00
Ryan Lerch
47c68f478d ansiblelint fixes - fqcn[action-core] - template to ansible.builtin.template
Replaces references to template: with ansible.builtin.template

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:30:29 +10:00
Ryan Lerch
25391e95b7 ansiblelint fixes - fqcn[action-core] - package to ansible.builtin.package
Replaces many references to  package: with ansible.builtin.package

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:28:00 +10:00
Ryan Lerch
6a3816dfdc ansiblelint fixes-- fqcn[action-core] - copy to ansible.builtin.copy
Replaces many references to 'copy' with ansible.builtin.copy

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:43:31 +10:00
Ryan Lerch
62952df107 ansiblelint fixes-- fqcn[action-core] - file to ansible.builtin.file
Replaces many references to  file: with ansible.builtin.file

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:41:52 +10:00
Ryan Lerch
691adee6ee Fix name[casing] ansible-lint issues
fix 1900 failures of the following case issue:

`name[casing]: All names should start with an uppercase letter.`

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-14 20:20:07 +10:00
Kevin Fenzi
ccb3e81b62 koji_builder: don't try and run rngd on aarch64 either
It tries to start on aarch64, but fails.
So, only run rngd on x86_64

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2024-12-09 17:42:27 -08:00
Ryan Lerch
89f6f1fc32 Fix majority of remaining yamllint warnings and errors
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-11-28 17:31:45 +10:00
Kevin Fenzi
5b9d067a31 koji_builder: don't restart the old monolythic libvirtd
In Fedora libvirt switched to a collection of socket activated services
instead of a large single libvirtd service. Restarting that service
caused the socket activated ones to die and then libvirtd exited on
idle, leaving nothing handling virt connections.

So, lets stop trying to restart that and no need to notify other things
because they should idle out/restart on socket activation.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2024-11-23 08:56:43 -08:00
Kevin Fenzi
f5089257fd koji_builder: use iptables backend for libvirt
In f41+ libvirt defaults to using nftables if both it and iptables
are installed, but it doesn't seem to work with imagefactory/oz
virt instances and our iptables setup.
So, lets revert back to iptables for now.
We can switch back if we can fix the incompatiblity, switch builders
to nftables, or stop using oz/IF

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2024-11-22 19:01:31 -08:00
Nils Philippsen
e46308a1a2 Switch to rpmautospec mock plugin in prod
Signed-off-by: Nils Philippsen <nils@redhat.com>
2024-08-16 09:49:40 +02:00
Nils Philippsen
44876b117d koji: Also remove python3-/rpmautospec pkgs
These were only needed for the rpmautospec koji plugin.

Signed-off-by: Nils Philippsen <nils@redhat.com>
2024-08-15 19:06:01 +02:00
Nils Philippsen
d566528276 koji: Switch to rpmautospec mock plugin in staging
Signed-off-by: Nils Philippsen <nils@redhat.com>
2024-08-15 18:15:51 +02:00
Kevin Fenzi
c84b99223c osbs: raise a glass for it's service
This removes osbs and allmost all it's associated playbooks and files.

It served long and well, but we no longer need it.
flatpaks are building with a koji-flatpak plugin.
base/minimal/toolbox containers are building with kiwi.
We aren't building any other containers right now, and we did they could
be added to kiwi.

This is the end of an era... I look with nostolga on
ansible-ansible-openshift-ansible (a role to setup ansible on a control
host and run it from our ansible).

Good bye osbs!

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2024-03-28 12:52:07 -07:00
Kevin Fenzi
4a6cb460ca buildvm_s390x in boston: retire
We have moved over to the rdu mainframe, drop all the bos kvm hosts.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2024-02-27 08:33:41 -08:00
Kevin Fenzi
334219e706 buildvm-s390x: move rest of old zvm builders to rdu and kvm
We want to move (well, really re-install) all these over on the new lpar
in rdu. This will have much higher stats and be in general faster by
both network and cpu. Hopefully all these will replace all the old
boston ones.

We may need to break these up some more into smaller vm's if the number
isn't able to keep up ok. We can adjust after things are all working.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2024-02-21 09:51:24 -08:00
Kevin Fenzi
2159c95c39 koji_builder: fix misleading task name
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2024-02-07 11:45:37 -08:00
Kevin Fenzi
c6d175f414 koji_builder: try and allow coredumps on buildhw-a64 builders
We want to get core dumps from these builders in order to try and track
down livemedia failures in python with SIGILL.
https://bugzilla.redhat.com/show_bug.cgi?id=2247319
We just enable this on those builders for now and we set it so it is the
limit for the systemd-nspawn containers that mock uses.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2023-11-03 16:41:59 +00:00
Owen W. Taylor
aaec95b064 Enable koji-flatpak on production
Enable the plugin on production, not just on staging.

Signed-off-by: Owen W. Taylor <otaylor@fishsoup.net>
2023-08-17 01:49:25 +00:00
Owen W. Taylor
f3c44a3ca3 Enable koji-flatpak plugin for staging
Just for staging for now:
 - enable 'podman-login' role for the buildvm group, so built Flatpaks
   can be pushed to the skopeo registry.
 - add the koji-flatpak hub plugin to koji_hub role
 - add the koji-flatpak builder plugin to the koji_builder role
   and configure it.

Signed-off-by: Owen W. Taylor <otaylor@fishsoup.net>
2023-08-14 19:27:31 +00:00
Kevin Fenzi
b3c2a39e1f koji_builder / osbuild: adjustments for osbuild api scripting
Right now we run a script on all builders once a minute to update the
api/auth ip's for osbuild. This has a number of problems:
* Sometimes osbuild jobs land on s390x builders that have no internet
  access and hang or fail.
* Sometimes the update script hangs or takes a long time to run because
  the builder is heavily loaded with builds, resulting in locking emails
  to sysadmin-main folks.

So, in this commit we:
* make a new koji channel called 'osbuild' with all the buildhw-x86's in
  it. They are usually not too overloaded and there are 16 of them so it
  should be available all the time.
* Leave the cron job on all builders for now in case, but make them only
  update once a day since they won't be getting jobs. If this works out
  we can remove it entirely there.
* Make the buildhw-x86s only update every 5min. This opens a larger
  window for it being wrong, but it's still pretty small and should
  reduce the number of emails for stalled processes we get.

See https://pagure.io/fedora-infrastructure/issue/10982

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2022-12-06 14:44:03 -08:00
Kevin Fenzi
75ddfcd201 koji_builder: mask systemd-oomd entirely
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2022-08-06 17:22:36 -07:00
Kevin Fenzi
688ca64361 koji_builder: add tag for oz.cfg so we can easily change it.
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2022-08-01 12:38:42 -07:00
Kevin Fenzi
76fbf76d1b koji_builders: add tag to be able to do just these
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2022-07-28 16:40:16 -07:00
Kevin Fenzi
20e0e74096 koji_builder: require ipset
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2022-07-28 12:07:00 -07:00
Kevin Fenzi
f545ece040 koji_builder: move update to templates for stg/prod
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2022-07-28 11:59:30 -07:00
Kevin Fenzi
e13df4173b koji_builder: fix typo and add tags
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2022-07-28 11:40:29 -07:00
Kevin Fenzi
1951c7fb1b koji_builder: first cut at a script to update osbuild api ip for builder firewalls
This is a quick, hacked up script that just runs once per minute and
updates the ip addresses for the osbuild koji plugin. The script calls
systemd's resolvectl without cache and puts the ips in a ipset. The
koji_builder firewall has a added rule to check that ipset for outgoing
connections that are allowed.

TODO: add some kind of error checking
TODO: probibly won't work on s390x builders as they can't reach the host
even with open firewalls, but should work for others.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2022-07-28 11:29:07 -07:00
Kevin Fenzi
debbc13616 koji_builder: disable/stop systemd-oomd on builders
systemd-oomd seems to be a bit eager and kills builds before the kernel
OOM would have. Disable it for now and see if it helps memory hungry
builds any.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2022-07-19 11:26:38 -07:00
Mark O Brien
20afa16aa8 install osbuild rpm on prod builders
Signed-off-by: Mark O Brien <markobri@redhat.com>
2022-06-08 11:29:32 +01:00
Mark O Brien
b3cacaaee6 set builder conf file per env
Signed-off-by: Mark O Brien <markobri@redhat.com>
2022-06-02 14:35:28 +01:00
David Kirwan
3d8b3faf0a image-builder: add task to create config directory
Signed-off-by: James Richardson <jamricha@redhat.com>
Signed-off-by: Emma Kidney <ekidney@redhat.com>
Signed-off-by: David Kirwan <dkirwan@redhat.com>
Signed-off-by: Stephen Coady <scoady@redhat.com>
2022-03-16 12:04:12 +00:00
David Kirwan
89e9a698e0 image-builder: add tag to koji-builder dependencies install task
Signed-off-by: James Richardson <jamricha@redhat.com>
Signed-off-by: Emma Kidney <ekidney@redhat.com>
Signed-off-by: David Kirwan <dkirwan@redhat.com>
Signed-off-by: Stephen Coady <scoady@redhat.com>
2022-03-16 11:10:47 +00:00
David Kirwan
9fbd26a83a image-builder: Adding osbuild to koji builders
- configuring koji builders to use image builder
- configure koji hub to handle osbuild jobs
- Separate prod/stg koji builder osbuild plugin config

Signed-off-by: James Richardson <jamricha@redhat.com>
Signed-off-by: Emma Kidney <ekidney@redhat.com>
Signed-off-by: David Kirwan <dkirwan@redhat.com>
Signed-off-by: Stephen Coady <scoady@redhat.com>
2022-03-16 10:38:20 +00:00
Kevin Fenzi
3d121ae5ee bkernel: drop nosync here too and fix logic to not change site-defaults in kojibuilder role
This caused a bit of trouble since I disabled nosync in the kojibuilder
role. I think applied that with -t site-defaults, which updated
everything, _including_ bkernel machines. Sadly, bkernel machines have
additional config in site-defaults to allow for secure boot signing and
this was lost. So, make sure only the bkernel role changes site-defaults
on bkernel machines and also drop nosync from it's private config.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2021-12-10 09:04:18 -08:00
Nils Philippsen
9a5d550570 Koji: prepare for prod deployment of rpmautospec
The relevant parts were made conditional and only applied in the staging
environment, change that. Alongside, ensure the obsolete hub plugin
package and plugin configuration files are removed and don't
automatically update any of the involved packages.

Signed-off-by: Nils Philippsen <nils@redhat.com>
2021-06-17 15:45:19 +02:00
Kevin Fenzi
9a09a926ab drop ntp/ntpdate, no longer in f34
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2021-05-24 18:24:17 -07:00
Kevin Fenzi
e3e490786c koji_builder / staging: drop ntp/ntpdate for f34
Split out the koji_builder package installs so we can drop ntp/ntpdate
for f34 (they were replaced by ntpsec and we use chrony anyhow).
After we move prod to f34 we should merge these back.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2021-04-09 10:21:40 -07:00
Kevin Fenzi
342ad36321 koji_builder: and conditional for rngd starting
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2021-02-17 10:38:42 -08:00