Commit Graph

80 Commits

Author SHA1 Message Date
Michal Konecny
2ec055db6f Use first uppercase letter for all handlers
This will unify all the handlers to use first uppercase letter for
ansible-lint to stop complaining.

I went through all `notify:` occurrences and fixed them by running
```
set TEXT "text_to_replace"; set REPLACEMENT "replacement_text"; git grep
-rlz "$TEXT" . | xargs -0 sed -i "s/$TEXT/$REPLACEMENT/g"
```

Then I went through all the changes and removed the ones that wasn't
expected to be changed.

Fixes https://pagure.io/fedora-infrastructure/issue/12391

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2025-02-10 20:31:49 +00:00
Ryan Lerch
47c68f478d ansiblelint fixes - fqcn[action-core] - template to ansible.builtin.template
Replaces references to template: with ansible.builtin.template

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:30:29 +10:00
Ryan Lerch
25391e95b7 ansiblelint fixes - fqcn[action-core] - package to ansible.builtin.package
Replaces many references to  package: with ansible.builtin.package

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:28:00 +10:00
Ryan Lerch
6a3816dfdc ansiblelint fixes-- fqcn[action-core] - copy to ansible.builtin.copy
Replaces many references to 'copy' with ansible.builtin.copy

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:43:31 +10:00
Ryan Lerch
62952df107 ansiblelint fixes-- fqcn[action-core] - file to ansible.builtin.file
Replaces many references to  file: with ansible.builtin.file

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:41:52 +10:00
Ryan Lerch
691adee6ee Fix name[casing] ansible-lint issues
fix 1900 failures of the following case issue:

`name[casing]: All names should start with an uppercase letter.`

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-14 20:20:07 +10:00
Stephen Smoogen
432a3a497b Go through and remove entries for EL6 and EL7
Using `git grep el6` and `git grep el7` and variants like EL-7 or
el-7, I found various entries and files which were no longer needed
with the current ansible. I updated text or tests to later versions of
RHEL as needed.

found entries for the fedora ami's for the original cloud and removed
those entries also.

Signed-off-by: Stephen Smoogen <ssmoogen@redhat.com>
2024-07-03 22:20:30 +00:00
Kevin Fenzi
c0eba5712b openvpn /client: drop another unneeded conditional
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2021-04-16 14:25:17 -07:00
Kevin Fenzi
519b756751 openvpn / client: drop another unneeded conditional
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2021-04-16 14:20:19 -07:00
Kevin Fenzi
9403ed2309 openvpn / client: drop tons of old cruft for el6 and old openvpn
We had a bunch of old el6 conditionals in here, and we have 0 el6
machines. We also now have some CentOS instances, so we shouldn't check
for RedHat or Fedora anymore. Also, everything is using the newer
openvpn now so no need to make sure the old one is stopped.
This should not affect the vast majority of hosts, but it should allow
the el7/el8-test instances vpns to actually work.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2021-04-16 14:09:33 -07:00
Stephen Smoogen
32552ec77e fix some entries pointing to bastion02 to bastion-iad 2020-06-11 14:10:04 -04:00
Kevin Fenzi
d5afca0080 iad2: drop conditionals, just connect to gateway
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-06-01 09:48:07 -07:00
Kevin Fenzi
508353cc74 openvpn/client: fix all non phx2 openvpn clients to have a remote again
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-05-27 09:18:12 -07:00
Kevin Fenzi
998a7beb31 iad2: openvpn/client: point all the iad2 instances to use the iad2 bastion
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-05-18 13:33:12 -07:00
Kevin Fenzi
81fb4582e7 ansible: change when conditions to use == instead of is when checking strings.
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2020-04-24 21:34:10 +02:00
Karsten Hopp
c9ed62ac32 update ansible_distribution_major_version conditionals
Signed-off-by: Karsten Hopp <karsten@redhat.com>
2020-04-24 21:34:10 +02:00
Karsten Hopp
60c2d50072 openvpn: dnf -> package, with_item changes 2019-06-11 15:00:23 +00:00
Kevin Fenzi
bcc42fad9c Add back a client.conf for rhel6 hosts (fas servers) 2018-09-29 18:28:39 +00:00
Kevin Fenzi
514d2b75ef also masters get messed up by this 2018-09-27 23:10:46 +00:00
Patrick Uiterwijk
325155810b Actually use the ansible hostname
Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
2018-09-18 05:51:46 +02:00
Patrick Uiterwijk
8ad630412f Make OpenVPN use tun1 for os-node's
Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
2018-09-18 05:49:15 +02:00
Patrick Uiterwijk
64f17dd5f7 Also fix paths for el6
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2018-08-17 04:55:48 +00:00
Patrick Uiterwijk
78ae75ac8a Fix client cert paths
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2018-08-17 04:39:50 +00:00
Patrick Uiterwijk
2948514084 Use the variable, not the string
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2018-01-02 02:14:00 +00:00
Patrick Uiterwijk
543acabdb1 Try to ensure that haproxy and varnish get started after VPN comes up on proxies
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2018-01-02 02:11:43 +00:00
Kevin Fenzi
fc484f796c drop some old openvpn stuff 2017-11-25 21:44:59 +00:00
Patrick Uiterwijk
65a6ad06f2 This service does not exist on newly installed boxes
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2017-11-21 23:07:56 +00:00
Patrick Uiterwijk
936e8b261a yum accepted pkg=, package calls it name=
Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
2017-10-09 00:38:26 +02:00
Patrick Uiterwijk
adcbf72f03 Packageize this, packageize that, packageize the world
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2017-10-08 22:25:52 +00:00
Kevin Fenzi
881735b5eb another corner case since f24 has systemd and el6 does not 2017-05-14 23:45:27 +00:00
Kevin Fenzi
5055c83e85 and try and handle f24 here too 2017-05-14 23:39:39 +00:00
Kevin Fenzi
636d7623ad try and use correct logic 2017-05-14 23:36:21 +00:00
Kevin Fenzi
52318bbc49 try and handle cases for f24 not being updated to the new setup either 2017-05-14 23:26:45 +00:00
Kevin Fenzi
50c070a79b fix version here too 2017-05-14 21:56:00 +00:00
Kevin Fenzi
714506a905 handle poor old rhel6 2017-05-14 21:51:47 +00:00
Patrick Uiterwijk
4cc1b78ff3 Check the certificate key usage
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2017-05-14 20:57:39 +00:00
Kevin Fenzi
6005665db7 also need cert and key under client 2017-05-14 20:55:45 +00:00
Kevin Fenzi
179cc4dd54 switch openvpn to use seperate service units and directories for client and server, hopefully in a mostly transparent way that will not cause much outage 2017-05-14 19:01:17 +00:00
Kevin Fenzi
8a6e51a9a6 change state=running to start=started as the old one is going away in ansible 2.7 2017-04-13 01:37:21 +00:00
Kevin Fenzi
215c38198e Disable openvpn client handler for now 2016-08-31 18:57:02 +00:00
Kevin Fenzi
12ed1dd6f7 Update out vpn configs for better encryption. 2016-08-31 18:50:14 +00:00
Kevin Fenzi
1c6e9a11f4 Another pile of trailing whitespace fixes 2016-08-08 19:42:36 +00:00
Tim Flink
bf03de72d0 fixing logic for openvpn package install w/dnf 2015-11-26 01:27:59 +00:00
Pierre-Yves Chibon
1c183896c8 Install the openvpn client package with dnf on F22+ 2015-11-17 15:29:29 +01:00
Patrick Uiterwijk
fe6f551049 Move fix-routes.sh to openvpn base and run it on restart
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2015-11-04 23:09:43 +00:00
Patrick Uiterwijk
b2b07e8bcd Running the script doesnt work yet. But we still want the script.
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2015-10-23 03:11:02 +00:00
Patrick Uiterwijk
50511a65e7 Make fix-routes not terminate with status 2 if it fixed it
This will make openvpn think something went wrong and terminate the connection.
I did this to make it easily visible when running with ansible, but in this case
it messes things up.

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2015-10-23 02:41:01 +00:00
Patrick Uiterwijk
d5bdc65887 Add script to OpenVPN for VPN route fixing
This will make sure that always after a start/restart the
VPN routes are created

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2015-10-23 02:15:43 +00:00
Patrick Uiterwijk
b1db3bafd8 Disable persist-tun for openvpn
This should solve the issue where RHEL7 machines that get a network
hiccup need an OpenVPN restart to restore their routes.

The code is broken in the current upstream OpenVPN release, such that
it does tear down some of the routes during a ping-restart (when the
connection is dropped due to network hiccups), but the reconnection
code does not restore the routes.
I am working on an upstream patch to fix this, but in the meantime
disabling persist-tun will make sure that OpenVPN does the entire
initialization upon reconnection, which makes sure that all routes
are created.

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
2015-10-21 18:26:32 +00:00
Kevin Fenzi
2873cdd427 Move all puppet_private stuff to ansible private so we can stop using puppet private. 2015-09-25 18:16:23 +00:00