In a0046b5b4b there was a bunch of fixes for ansible lint to the
distgit/pagure roles.
However, it seems like a
recursive: true
was added to the facl call, when it wasn't present before.
I noticed this when my playbook run on pkgs was running for several
hours. ;(
I don't think there's any reason to run this recursively,
as permissions should inherit from the top level one and have always
worked without it.
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
The patch provided originally was made against the latest pagure code,
but we are not on the latest dev version. So I created the patch
directly for the source file deployed on src.stg.fedoraproject.org.
There is a local fix on src.fedoraproject.org that is missing on
src.stg.fedoraproject.org. I provided the fix in
https://pagure.io/pagure/pull-request/5525 and this commit is adding it
as patch to ansible, so the change is permanent.
This commit is fixing ansible lint errors for distgit role.
It also introduces two new addition to skip list as the structure of our
ansible repository doesn't adhere to ansible standards.
The errors that will be now skipped are:
- role-name[path] - we have plenty of roles that have sub-roles inside
them and we need to access them
- var-naming[no-role-prefix] - variables for roles are not usually
prefixed correctly in our repository and forcing people to change that
will introduce more issues than what it solves
Removing the topic_prefix from fedora messaging config files was a bit
premature. So let's put them back in place.
Signed-off-by: Michal Konecny <mkonecny@redhat.com>
This will unify all the handlers to use first uppercase letter for
ansible-lint to stop complaining.
I went through all `notify:` occurrences and fixed them by running
```
set TEXT "text_to_replace"; set REPLACEMENT "replacement_text"; git grep
-rlz "$TEXT" . | xargs -0 sed -i "s/$TEXT/$REPLACEMENT/g"
```
Then I went through all the changes and removed the ones that wasn't
expected to be changed.
Fixes https://pagure.io/fedora-infrastructure/issue/12391
Signed-off-by: Michal Konecny <mkonecny@redhat.com>
fix 1900 failures of the following case issue:
`name[casing]: All names should start with an uppercase letter.`
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
This commit retires pdc from ansible.
The website should get redirected to a wiki page about the retirement.
If for some reason we need to bring things back, the vm's will still
have their disks and xml saved off so we can bring it back.
Would need to revert this, run proxy playbooks and do a little cleanup
on the redirect, then bring the vm's back up.
Hopefully we don't have to.
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
This was fixed previously for pagure.io in the context of
paguremirroring. Turns out, it affects all kinds of git operations, so
document and move accordingly.
Fixes: releng#12181
Fixes: fedora-infrastructure#12010
Signed-off-by: Nils Philippsen <nils@redhat.com>
Right now the cron job is mailing out something like:
/tmp/releng.HEQKVAc ~
Cloning into 'releng'...
~
Hopefully this will make it not send that email unless there's an error.
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
Related with commit 1efcf8a90b
We need to update the acls table with their descriptions.
pagure/cli/admin.py update-acls
The above command can update the table and it looks for descriptions in the ACLS config variable.
Packit needs this ACLs to be able to update PRs it has already created.
We are implementing this feature:
https://github.com/packit/packit/issues/2182
Packit needs this ACLs just in distgit.
Part of an initiative to remove PDC calls.
Active branches are now checked from a call to bodhi, not to pdc.
Needed for the check in distgit - avoid pushing to EOL branches
Signed-off-by: Lenka Segura <lsegura@redhat.com>
