Commit Graph

180 Commits

Author SHA1 Message Date
Aurélien Bompard
ba7712dd43 Update manual playbooks that expect unsuffixed job.yml template
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2025-05-13 11:30:36 +02:00
Greg Sutcliffe
2ccdc83dce Add lint prefix to template_fullpath to match openshift/object 2025-03-13 15:45:07 +00:00
Ryan Lerch
a0cd459d47 Fix some references in tasks dropping .j2
When fixing conflicts when merging the PR containing commit 47c68f4,
some of the .j2 suffuxes i added in tasks were erronounusly dropped.

this fixes those.

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 19:44:59 +10:00
Ryan Lerch
47c68f478d ansiblelint fixes - fqcn[action-core] - template to ansible.builtin.template
Replaces references to template: with ansible.builtin.template

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:30:29 +10:00
Ryan Lerch
3c41882bb0 ansiblelint fixes - fqcn[action-core] - shell to ansible.builtin.shell
Replaces references to shell: with ansible.builtin.shell

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:29:10 +10:00
Ryan Lerch
462176464b ansiblelint fixes-- fqcn[action-core] - command to ansible.builtin.command
Replaces many references to  command: with ansible.builtin.command

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 11:26:47 +10:00
Ryan Lerch
6a3816dfdc ansiblelint fixes-- fqcn[action-core] - copy to ansible.builtin.copy
Replaces many references to 'copy' with ansible.builtin.copy

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:43:31 +10:00
Ryan Lerch
62952df107 ansiblelint fixes-- fqcn[action-core] - file to ansible.builtin.file
Replaces many references to  file: with ansible.builtin.file

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-15 10:41:52 +10:00
Aurélien Bompard
f3517ab537 Escape jinja template chars when necessary
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2025-01-14 17:25:50 +01:00
Ryan Lerch
691adee6ee Fix name[casing] ansible-lint issues
fix 1900 failures of the following case issue:

`name[casing]: All names should start with an uppercase letter.`

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-14 20:20:07 +10:00
Ryan Lerch
a6a2e10539 openshift roles - rename yml templates to .j2
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-14 08:37:32 +10:00
Ryan Lerch
098a9fedf2 openshift/project - rename yaml/yml templates to .j2
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2025-01-14 08:37:30 +10:00
Aurélien Bompard
64734c21e9 Set a default for keytab_host
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-10 09:42:36 +01:00
Aurélien Bompard
ffd14b9538 Pass the variables from openshift/keytab down to keytab/service
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-10 09:34:52 +01:00
Aurélien Bompard
c9bd987c66 Fix the openshift/ipa-client role
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 12:22:12 +01:00
Aurélien Bompard
1875a0a0dc Fix variable name conflict
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 12:12:09 +01:00
Aurélien Bompard
483f9802ac s/route_routename/route_name/g
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 11:26:36 +01:00
Aurélien Bompard
acc40816b7 Rewrite prefixes when forwarding vars in openshift roles
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 11:24:58 +01:00
Aurélien Bompard
b9ed0ea60d Missing prefix in openshift/route
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:46 +01:00
Aurélien Bompard
a4ac9af648 Fix missing prefix in openshift/object
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:46 +01:00
Aurélien Bompard
fac05df8de Prefix openshift/secret-tls
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:46 +01:00
Aurélien Bompard
c5f8fe7189 Prefix openshift/import-image
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:46 +01:00
Aurélien Bompard
e5a47b8e0d Prefix openshift/sysadmin-openshift
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:46 +01:00
Aurélien Bompard
4d651a8dae Prefix openshift/ipa-client
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:46 +01:00
Aurélien Bompard
a36b40eec8 Prefix openshift/start-build
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:45 +01:00
Aurélien Bompard
560a31ef5b Prefix openshift/object-delete
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:45 +01:00
Aurélien Bompard
cfb590c2ed Prefix openshift/secret-file
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:45 +01:00
Aurélien Bompard
dc65a76527 Prefix openshift/imagestream
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:45 +01:00
Aurélien Bompard
cf82a481be Prefix openshift/keytab
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:45 +01:00
Aurélien Bompard
39f2e86658 Prefix openshift/job
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-12-03 10:48:45 +01:00
Ryan Lerch
cae52420bb [ansible-lint] prefix variable names for openshift/rollout role
ansible-lint requires that variables for roles are prefixed with the
name of the role. This commit prefixes the variables for the
openshift/rollout role with rollout_ as required by ansible-lint

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-12-03 10:48:45 +01:00
Ryan Lerch
4dea370c66 [ansible-lint] prefix variable names for openshift/route role
ansible-lint requires that variables for roles are prefixed with the
name of the role. This commit prefixes the variables for the
openshift/route role with route_ as required by ansible-lint

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-12-03 10:48:45 +01:00
Ryan Lerch
776866cba3 [ansible-lint] prefix variable names for openshift/object role
ansible-lint requires that variables for roles are prefixed with the
name of the role. This commit prefixes the variables for the
openshift/object role with object_ as required by ansible-lint

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-12-03 10:48:45 +01:00
Ryan Lerch
01ace51513 [ansible-lint] prefix variable names for openshift/project role
ansible-lint requires that variables for roles are prefixed with the
name of the role. This commit prefixes the rvariables for the
openshift/project role with project_ as required by ansible-lint

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-12-03 10:48:44 +01:00
Adam Williamson
4194cafaf4 prometheusRules - try going back to exactly how it was before yamllint
...i.e. without a comment before it to suppress yamllint. Maybe
that doesn't work either?

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-11-30 11:28:52 -08:00
Adam Williamson
501cb25519 Revert "openshift: try and fix an error caused by yamllint cleanup"
This reverts commit 054bc753ac.
It doesn't seem to help. No idea why prometheusRules is blowing
up now, then :(
2024-11-30 11:08:05 -08:00
Adam Williamson
054bc753ac openshift: try and fix an error caused by yamllint cleanup
It looks like these #jinja2 comments don't work with a space
between the # and the jinja2, or something. I'm getting errors
on this template when trying to run an openshift playbook ATM.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-11-30 10:58:05 -08:00
Ryan Lerch
89f6f1fc32 Fix majority of remaining yamllint warnings and errors
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
2024-11-28 17:31:45 +10:00
Michal Konecny
e230842a0a [openshift/ipa-client] Fix krb5 config
There was a typo in krb5 config for staging machines as the naming
convention is stg.iad2.fedoraproject.org and not iad2.stg.fedoraproject.org.

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2024-11-27 13:48:21 +01:00
Aurélien Bompard
692b98ece0 name is a reserved variable
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-11-18 17:33:37 +01:00
Aurélien Bompard
33c98f7467 Allow appowners to create pods in MirrorManager
Ref: https://discussion.fedoraproject.org/t/openshift-permissions-for-appowners/133816

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-10-16 12:22:27 +02:00
Aurélien Bompard
5778e0d999 Create a role to run jobs in OpenShift
Inspired by Koschei's `koschei/job` role.
Adapt the MirrorManager move-to-archive job to it.

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-08-06 07:49:59 +02:00
Aurélien Bompard
be05575049 Add a playbook to run move-to-archive
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
2024-07-30 11:01:27 +02:00
Kevin Fenzi
620dbb5753 openshift: drop egress policy
We had this with SDN networking, but no more with newer networking.
We also don't use it anywhere, it was mostly for when fas2 was running
in openshift to isolate it and it's not there anymore.

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2024-05-22 15:30:54 -07:00
Kevin Fenzi
a2ed5d7b0f imagestream template: should use full crm
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2024-01-15 14:32:52 -08:00
Siteshwar Vashisht
021c8fe152 ocp_monitoring: remove repeat_interval field
Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
2023-11-23 18:23:58 +01:00
Michal Konecny
c5e61168bb [openshift/project] Fix the parameter order for oc apply
The file needs to be specified after `-f` parameter otherwise it fails with
unexpected args error.

Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2023-11-23 16:39:48 +01:00
Kevin Fenzi
9e2b0cda9d openshift: validate when applying objects
Right now if there's a yml thats indented incorrectly, but parts of it
are fine, oc apply will apply those parts that are valid and just ignore
the rest. So, lets add a --validate=strict to have it reject these
entirely, so we know they have something wrong in them and we can fix
it, rather than being confused that they didn't apply anything.

Signed-off-by: Kevin Fenzi kevin@scrye.com
2023-11-08 14:11:02 -08:00
Kevin Fenzi
dfeac79e65 openshift: fix copypasta in crd
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2023-02-13 16:01:15 -08:00
Kevin Fenzi
f7ceb69349 openshift: more fixes to crds
Signed-off-by: Kevin Fenzi <kevin@scrye.com>
2023-02-13 15:59:01 -08:00