mirror of
https://pagure.io/fedora-infra/ansible.git
synced 2026-03-31 17:31:36 +08:00
d9db9714d8
ifcfg.j2 has a pretty awkward assumption that the interface connected to the infra network will be eth0 (or enc900) - it only includes the GATEWAY, DOMAIN and DNS1/DNS2 lines if the interface is one of those two. It seems we were trying quite hard to make eth0 always be "the interface", but now that's been broken in a few systems. enc900 was added as apparently that's what the main interface is called on some s390 boxes; on openqa-ppc64le-01 the if that's connected is eth2 (eth0 is present, but not connected), and on the new qa01 and qa02, it's em3 (according to smooge, we have to use 'predictable' interface names on those boxes as the old names really *do* get assigned to different interfaces on each boot). So since we now have several different cases where the 'eth0' assumption doesn't hold, let's build a slightly better system for handling it. This replaces ifcfg.j2's hard-coded list with a variable, and sets the default value of the variable to the two names ifcfg.j2 handled before: [ 'eth0', 'enc900' ]. This allows the systems where the main interface is *not* one of these to set the variable accordingly, and hopefully that'll give them correct ifcfg files. This *should* solve the problem of openqa-ppc64le-01.qa and qa01 and qa02 constantly dropping out of network connectivity any time they got rebooted or the network plays got run. Signed-off-by: Adam Williamson <awilliam@redhat.com>
This role is the base setup for all our machines. If there's something that shouldn't be run on every single machine, it should be in another role.