From 8abb4aa1f917d56427babf45c3e2a5ab1a0a89b6 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Tue, 26 Nov 2019 18:59:21 +0100 Subject: [PATCH 1/6] GitHub Action to run cpplint on all pull requests --- .github/workflows/ccpp.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 .github/workflows/ccpp.yml diff --git a/.github/workflows/ccpp.yml b/.github/workflows/ccpp.yml new file mode 100644 index 000000000..c71d39918 --- /dev/null +++ b/.github/workflows/ccpp.yml @@ -0,0 +1,10 @@ +name: cpplint +on: [push, pull_request] +jobs: + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v1 + - uses: actions/setup-python@v1 + - run: pip install cpplint + - run: cpplint --recursive . From d9241950166254139b2a4c647b78b1858ae94bec Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Wed, 27 Nov 2019 00:15:06 +0100 Subject: [PATCH 2/6] cpplint --counting=detailed --recursive . --- .github/workflows/ccpp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ccpp.yml b/.github/workflows/ccpp.yml index c71d39918..b7c0baa9a 100644 --- a/.github/workflows/ccpp.yml +++ b/.github/workflows/ccpp.yml @@ -7,4 +7,4 @@ jobs: - uses: actions/checkout@v1 - uses: actions/setup-python@v1 - run: pip install cpplint - - run: cpplint --recursive . + - run: cpplint --counting=detailed --recursive . From 88c7121c84ad9ef59fc8f81a8cfaed049f3c4cd0 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Wed, 27 Nov 2019 00:29:00 +0100 Subject: [PATCH 3/6] --filter --- .github/workflows/ccpp.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ccpp.yml b/.github/workflows/ccpp.yml index b7c0baa9a..f6a71b6d3 100644 --- a/.github/workflows/ccpp.yml +++ b/.github/workflows/ccpp.yml @@ -7,4 +7,11 @@ jobs: - uses: actions/checkout@v1 - uses: actions/setup-python@v1 - run: pip install cpplint - - run: cpplint --counting=detailed --recursive . + - run: | + cpplint --filter=-build/include_order,-build/namespaces,-legal/copyright,\ + -readability/casting,-readability/todo,-runtime/arrays,-runtime/explicit,\ + -runtime/int,-runtime/references,-runtime/threadsafe_fn,-whitespace --recursive . +# whitespace/blank_line,-whitespace/braces,-whitespace/comma,-whitespace/comments +# whitespace/empty_loop_body,-whitespace/end_of_line,-whitespace/ending_newline +# whitespace/forcolon,-whitespace/indent,-whitespace/line_length,-whitespace/newline +# whitespace/operators,-whitespace/parens,-whitespace/semicolon,-whitespace/tab --recursive . From 4f65b23c36af444a1d9d39a71e6cceaec6f6c5c5 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Wed, 27 Nov 2019 00:34:26 +0100 Subject: [PATCH 4/6] No backslash --- .github/workflows/ccpp.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ccpp.yml b/.github/workflows/ccpp.yml index f6a71b6d3..2c0556259 100644 --- a/.github/workflows/ccpp.yml +++ b/.github/workflows/ccpp.yml @@ -8,8 +8,8 @@ jobs: - uses: actions/setup-python@v1 - run: pip install cpplint - run: | - cpplint --filter=-build/include_order,-build/namespaces,-legal/copyright,\ - -readability/casting,-readability/todo,-runtime/arrays,-runtime/explicit,\ + cpplint --filter=-build/include_order,-build/namespaces,-legal/copyright, + -readability/casting,-readability/todo,-runtime/arrays,-runtime/explicit, -runtime/int,-runtime/references,-runtime/threadsafe_fn,-whitespace --recursive . # whitespace/blank_line,-whitespace/braces,-whitespace/comma,-whitespace/comments # whitespace/empty_loop_body,-whitespace/end_of_line,-whitespace/ending_newline From 60cd628762e1fddb9bb4d855ce98f0917bcec0de Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Wed, 27 Nov 2019 00:38:20 +0100 Subject: [PATCH 5/6] cpplint --filter=-build,-legal,-readability,-runtime,-whitespace --recursive . --- .github/workflows/ccpp.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ccpp.yml b/.github/workflows/ccpp.yml index 2c0556259..03c76db29 100644 --- a/.github/workflows/ccpp.yml +++ b/.github/workflows/ccpp.yml @@ -7,11 +7,5 @@ jobs: - uses: actions/checkout@v1 - uses: actions/setup-python@v1 - run: pip install cpplint - - run: | - cpplint --filter=-build/include_order,-build/namespaces,-legal/copyright, - -readability/casting,-readability/todo,-runtime/arrays,-runtime/explicit, - -runtime/int,-runtime/references,-runtime/threadsafe_fn,-whitespace --recursive . -# whitespace/blank_line,-whitespace/braces,-whitespace/comma,-whitespace/comments -# whitespace/empty_loop_body,-whitespace/end_of_line,-whitespace/ending_newline -# whitespace/forcolon,-whitespace/indent,-whitespace/line_length,-whitespace/newline -# whitespace/operators,-whitespace/parens,-whitespace/semicolon,-whitespace/tab --recursive . + - run: cpplint --filter= + - run: cpplint --filter=-build,-legal,-readability,-runtime,-whitespace --recursive . From 639e46f023b41b2efaa92c5efc540fe03515dd19 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Wed, 27 Nov 2019 00:50:33 +0100 Subject: [PATCH 6/6] Add TODO --- .github/workflows/ccpp.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ccpp.yml b/.github/workflows/ccpp.yml index 03c76db29..744fd7c48 100644 --- a/.github/workflows/ccpp.yml +++ b/.github/workflows/ccpp.yml @@ -7,5 +7,6 @@ jobs: - uses: actions/checkout@v1 - uses: actions/setup-python@v1 - run: pip install cpplint - - run: cpplint --filter= + # - run: cpplint --filter= # print out all cpplint rules + # TODO: Remove each filter one at a time and fix those failures - run: cpplint --filter=-build,-legal,-readability,-runtime,-whitespace --recursive .