backup/C-Plus-Plus
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/C-Plus-Plus.git synced 2026-04-05 11:40:46 +08:00
Code Issues Projects Releases Wiki Activity

[fix/docs]: remove memory leak in queue (#2417)

Browse Source 
* fix: remove memory leak in queue

* updating DIRECTORY.md

* clang-format and clang-tidy fixes for effd74c9

* style: simplify logic while using reserve

* style: use value_type as return type in front

* style: use proper error message

* style: use pre-increment and pre-decrement

* docs: use doxygen syntax

* docs: improve wording

Co-authored-by: github-actions[bot] <github-actions@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
This commit is contained in:
Piotr Idzik
2023-01-26 07:29:37 +01:00
committed by GitHub
parent 5b238724b8
commit 7c090481da
7 changed files with 250 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
data_structures/stack.hpp
View File

@@ -7,28 +7,9 @@
#ifndef DATA_STRUCTURES_STACK_HPP_
#define DATA_STRUCTURES_STACK_HPP_
#include <iostream> /// for IO operations
#include <memory> /// for std::shared_ptr
#include <stdexcept> /// for std::invalid_argument
#include <vector> /// for std::vector
/** Definition of the node as a linked-list
* \tparam ValueType type of data nodes of the linked list should contain
*/
template <class ValueType>
struct node {
ValueType data = {}; ///< data at current node
std::shared_ptr<node<ValueType>> next =
{}; ///< pointer to the next ::node instance
};
template <typename Node, typename Action>
void traverse(const Node* const inNode, const Action& action) {
if (inNode) {
action(*inNode);
traverse(inNode->next.get(), action);
}
}
#include "node.hpp" /// for Node
/** Definition of the stack class
* \tparam value_type type of data nodes of the linked list in the stack should
@@ -42,20 +23,13 @@ class stack {
/** Show stack */
void display() const {
std::cout << "Top --> ";
traverse(stackTop.get(), [](const node<value_type>& inNode) {
std::cout << inNode.data << " ";
});
std::cout << std::endl;
display_all(this->stackTop.get());
std::cout << '\n';
std::cout << "Size of stack: " << size << std::endl;
}
std::vector<value_type> toVector() const {
std::vector<value_type> res;
res.reserve(this->size);
traverse(stackTop.get(), [&res](const node<value_type>& inNode) {
res.push_back(inNode.data);
});
return res;
return push_all_to_vector(this->stackTop.get(), this->size);
}
private:
@@ -71,7 +45,7 @@ class stack {
/** Add new item to the stack */
void push(const value_type& item) {
auto newNode = std::make_shared<node<value_type>>();
auto newNode = std::make_shared<Node<value_type>>();
newNode->data = item;
newNode->next = stackTop;
stackTop = newNode;
@@ -98,7 +72,7 @@ class stack {
}
private:
std::shared_ptr<node<value_type>> stackTop =
std::shared_ptr<Node<value_type>> stackTop =
{}; /**< Pointer to the stack */
std::size_t size = 0; ///< size of stack
};