From ecf4ebf50e4a29a45bf0cab3c359138116445935 Mon Sep 17 00:00:00 2001
From: walker0643 <>
Date: Mon, 29 Jan 2018 22:49:50 -0500
Subject: [PATCH] disable check for updated version since it was causing an
 access violation on close and since there is nothing to check it against
 anyway. will reimplement check for updated version in the future.

---
 src/gui/src/VersionChecker.cpp | 42 +++++++++++++++++++---------------
 src/gui/src/VersionChecker.h   |  3 +--
 2 files changed, 24 insertions(+), 21 deletions(-)

diff --git a/src/gui/src/VersionChecker.cpp b/src/gui/src/VersionChecker.cpp
index 6abd5c0b..b6803096 100644
--- a/src/gui/src/VersionChecker.cpp
+++ b/src/gui/src/VersionChecker.cpp
@@ -25,37 +25,41 @@
 #include <QLocale>
 
 #define VERSION_REGEX "(\\d+\\.\\d+\\.\\d+)"
-#define VERSION_URL "http://symless.com/version/"
+//#define VERSION_URL "http://www.TODO.com/"
 
-VersionChecker::VersionChecker()
+VersionChecker::VersionChecker(QObject* parent)
+    : QObject(parent)
 {
-    m_manager = new QNetworkAccessManager(this);
-
-    connect(m_manager, SIGNAL(finished(QNetworkReply*)),
-         this, SLOT(replyFinished(QNetworkReply*)));
-}
-
-VersionChecker::~VersionChecker()
-{
-    delete m_manager;
 }
 
 void VersionChecker::checkLatest()
 {
-    m_manager->get(QNetworkRequest(QUrl(VERSION_URL)));
+    // calling m_manager->get(..) is causing an access violation on app close
+    // atm there is nothing to check the version against, so removing until we need a version checker again
+
+    //m_manager = new QNetworkAccessManager(this);
+
+    //connect(m_manager, SIGNAL(finished(QNetworkReply*)),
+    //    this, SLOT(replyFinished(QNetworkReply*)));
+
+    //m_manager->get(QNetworkRequest(QUrl(VERSION_URL)));
 }
 
 void VersionChecker::replyFinished(QNetworkReply* reply)
 {
-    QString newestVersion = QString(reply->readAll());
-    if (!newestVersion.isEmpty())
-    {
-        QString currentVersion = getVersion();
-        if (currentVersion != "Unknown") {
-            if (compareVersions(currentVersion, newestVersion) > 0)
-                emit updateFound(newestVersion);
+    if (reply->error()) {
+        // TODO: handle me
+    } else {
+        QString newestVersion = QString(reply->readAll());
+        if (!newestVersion.isEmpty()) {
+            QString currentVersion = getVersion();
+            if (currentVersion != "Unknown") {
+                if (compareVersions(currentVersion, newestVersion) > 0)
+                    emit updateFound(newestVersion);
+            }
         }
     }
+    reply->deleteLater();
 }
 
 int VersionChecker::compareVersions(const QString& left, const QString& right)
diff --git a/src/gui/src/VersionChecker.h b/src/gui/src/VersionChecker.h
index daab09ae..e4df2c65 100644
--- a/src/gui/src/VersionChecker.h
+++ b/src/gui/src/VersionChecker.h
@@ -28,8 +28,7 @@ class VersionChecker : public QObject
 {
     Q_OBJECT
 public:
-    VersionChecker();
-    virtual ~VersionChecker();
+    explicit VersionChecker(QObject* parent = 0);
     void checkLatest();
     QString getVersion();
     void setApp(const QString& app) { m_app = app; }