mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-10-30 11:58:49 +08:00
d882311ec6
Removes dead code and redundant logic and consolidates tests, so there is less to read and maintain. No behavior change. 1. **act/runner**: inline single-use wrappers, compile regexes once instead of per call, embed the trampoline as a string, drop the unused legacy result of `parseActionCommand` 2. **act/container**: `sanitizeConfig` and `mergeContainerConfigs` stop returning the configs they already mutate in place, drop never-set option fields and the unused `user` parameter of `ExecWithCmdLine` 3. **act/common and cache server**: drop the unused `Trace`/`Tracef` loggers and the short SHA of `FindGitRevision`, `RegisterJob` releases through `RevokeJob` 4. **daemon, poller and reporter**: one shutdown wait for both poll modes, drop an unreachable fetch timeout branch, guard the reporter's last report time with its existing lock instead of an atomic 5. **build**: drop unused Makefile and release workflow variables, collapse the goreleaser ignore list to the same build targets 6. **tests**: fold near-duplicate tests into tables with shared setup Throughout, hand-rolled logic gives way to `cmp.Or`, `strings.Cut`, `slices` and `min`/`max`. Reviewed-on: https://gitea.com/gitea/runner/pulls/1335 Reviewed-by: bircni <bircni@icloud.com> Co-authored-by: silverwind <me@silverwind.io>
41 lines
905 B
Go
41 lines
905 B
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package run
|
|
|
|
import (
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestRunnerCloneEnvsConcurrentMutation(t *testing.T) {
|
|
r := &Runner{
|
|
envs: map[string]string{
|
|
"ACTIONS_CACHE_URL": "http://cache.example",
|
|
"ACTIONS_RUNTIME_URL": "http://runner.example",
|
|
},
|
|
}
|
|
|
|
const goroutines = 16
|
|
var wg sync.WaitGroup
|
|
wg.Add(goroutines)
|
|
for range goroutines {
|
|
go func() {
|
|
defer wg.Done()
|
|
envs := r.cloneEnvs()
|
|
assert.Equal(t, r.envs, envs)
|
|
envs["ACTIONS_RUNTIME_TOKEN"] = "task-token"
|
|
envs["ACTIONS_ID_TOKEN_REQUEST_URL"] = "http://oidc.example"
|
|
envs["ACTIONS_ID_TOKEN_REQUEST_TOKEN"] = "oidc-token"
|
|
}()
|
|
}
|
|
wg.Wait()
|
|
|
|
assert.Equal(t, map[string]string{
|
|
"ACTIONS_CACHE_URL": "http://cache.example",
|
|
"ACTIONS_RUNTIME_URL": "http://runner.example",
|
|
}, r.envs)
|
|
}
|