mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-11-01 04:48:49 +08:00
fe2a66dc25
Contains a number of small bug fixes where jobs behaved differently from GitHub or failed silently.
1. Hooks fail on a refused `::set-env::` or `::add-path::` and no longer inherit the last step's identity
1. Docker build, exec and wait errors are returned instead of swallowed, token-only registry credentials work, logs of `--tty` services decode
1. Env files split lines like GitHub on each OS, so a carriage return is kept on Linux and CRLF ends a line on Windows, empty heredoc names or delimiters are rejected
1. Post steps run after their pre step even when main was skipped, composites see undeclared inputs, `runs.args` wins without `with.args` being parsed
1. Docker actions skip evaluating defaults of inputs given in `with` and read `entryPoint` and `args` in any case, a lowercase `dockerfile` is found, undeclared inputs get GitHub's warning
1. A user-set `CI` is kept, `GITHUB_REPOSITORY_ID` and the other missing `GITHUB_*` variables are exported
1. `timeout-minutes` can read the step's own `env`, a step-level `ACTIONS_ALLOW_UNSECURE_COMMANDS: false` beats a job-level `true` while the runner's own opt-in still wins, `pwsh` quotes the script path
1. A step `env:` given as one expression such as `${{ fromJSON(matrix.env) }}` is applied, `hashFiles` fails with GitHub's messages on script errors and after 120 seconds, a job image without node still gets an empty hash
1. A step whose command files cannot be reset fails instead of importing stale ones, a timeout between steps fails the job instead of reporting success
1. One named volume can be mounted at several paths, host-mode PTY steps keep their last output when they fail, host scratch directories are removed when job setup fails
1. Cancelling a step right after it starts kills its whole process tree
1. Cache prefix restores pick the newest entry created within the same second, also on S3, cache commits with a wrong size are rejected
1. Artifact chunks are written at their offset, download URLs are escaped, listing a run without artifacts no longer crashes
1. Poll backoff reaches `fetch_interval_max`, proxy passwords are masked in more forms, secrets are also masked in step names and in their quoted form in the runner log, a failed final report is logged
1. On Windows hosts a differently cased unsecure-commands opt-in or proxy variable counts, and an early cancel no longer leaks a job object handle
1. Interactive `register` prompts for a missing token and stops on SIGTERM, `exec --list --detect-event` no longer panics without events, `config set` works on `cache.s3` keys
Reviewed-on: https://gitea.com/gitea/runner/pulls/1338
Reviewed-by: bircni <bircni@icloud.com>
Co-authored-by: silverwind <me@silverwind.io>
65 lines
1.7 KiB
Go
65 lines
1.7 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package report
|
|
|
|
import (
|
|
"slices"
|
|
"strconv"
|
|
"strings"
|
|
"sync"
|
|
"sync/atomic"
|
|
|
|
"gitea.com/gitea/runner/act/runner"
|
|
)
|
|
|
|
// A job's plan runs before its job logger exists and logs through the process-wide one, which
|
|
// several tasks share, so that one holds the union of every live task's starting secrets.
|
|
var (
|
|
globalMu sync.Mutex
|
|
globalMasks = map[*Reporter][]string{}
|
|
globalReplacer atomic.Pointer[strings.Replacer] // nil while nothing is registered
|
|
)
|
|
|
|
func registerGlobalMasks(r *Reporter) {
|
|
globalMu.Lock()
|
|
defer globalMu.Unlock()
|
|
masks := slices.Clip(r.oldnew)
|
|
for i := 0; i < len(r.oldnew); i += 2 { // the console handler Go-quotes values with special characters
|
|
if quoted := strconv.Quote(r.oldnew[i]); quoted[1:len(quoted)-1] != r.oldnew[i] {
|
|
masks = append(masks, quoted[1:len(quoted)-1], r.oldnew[i+1])
|
|
}
|
|
}
|
|
globalMasks[r] = masks
|
|
rebuildGlobalReplacer()
|
|
}
|
|
|
|
func deregisterGlobalMasks(r *Reporter) {
|
|
globalMu.Lock()
|
|
defer globalMu.Unlock()
|
|
delete(globalMasks, r)
|
|
rebuildGlobalReplacer()
|
|
}
|
|
|
|
func rebuildGlobalReplacer() { // caller holds globalMu
|
|
var oldnew []string
|
|
for _, masks := range globalMasks {
|
|
oldnew = append(oldnew, masks...)
|
|
}
|
|
if len(oldnew) == 0 {
|
|
globalReplacer.Store(nil)
|
|
return
|
|
}
|
|
globalReplacer.Store(runner.NewSecretReplacer(oldnew))
|
|
}
|
|
|
|
// MaskGlobal hides every registered value in a formatted line of the process-wide log, fields
|
|
// included. It is meant for logging.TextOptions.Filter.
|
|
func MaskGlobal(line []byte) []byte {
|
|
replacer := globalReplacer.Load()
|
|
if replacer == nil { // nothing to hide, so an idle daemon pays no copy
|
|
return line
|
|
}
|
|
return []byte(replacer.Replace(string(line)))
|
|
}
|