mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-04-25 21:30:23 +08:00
Use `golangci-lint fmt` to format code, upgrading `.golangci.yml` to v2 and mirroring the linter configuration used by https://github.com/go-gitea/gitea. `gci` now handles import ordering into standard, project-local, blank, and default groups. Mirrors https://github.com/go-gitea/gitea/pull/37194. Changes: - Upgrade `.golangci.yml` to v2 format with the same linter set as gitea (minus `prealloc`, `unparam`, `testifylint`, `nilnil` which produced too many pre-existing issues) - Add path-based exclusions (`bodyclose`, `gosec` in tests; `gosec:G115`/`G117` globally) - Run lint via `make lint-go` in CI instead of `golangci/golangci-lint-action`, matching the pattern used by other Gitea repos - Apply safe auto-fixes (`modernize`, `perfsprint`, `usetesting`, etc.) - Add explanations to existing `//nolint` directives - Remove dead code (unused `newRemoteReusableWorkflow` and `networkName`), duplicate imports, and shadowed `max` builtins - Replace deprecated `docker/distribution/reference` with `distribution/reference` - Fix `Deprecated:` comment casing and simplify nil/len checks --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/act/pulls/163 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-committed-by: silverwind <me@silverwind.io>
87 lines
1.9 KiB
Go
87 lines
1.9 KiB
Go
package common
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// Simple fast test that verifies max-parallel: 2 limits concurrency
|
|
func TestMaxParallel2Quick(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
var currentRunning atomic.Int32
|
|
var maxSimultaneous atomic.Int32
|
|
|
|
executors := make([]Executor, 4)
|
|
for i := range 4 {
|
|
executors[i] = func(ctx context.Context) error {
|
|
current := currentRunning.Add(1)
|
|
|
|
// Update max if needed
|
|
for {
|
|
maxValue := maxSimultaneous.Load()
|
|
if current <= maxValue || maxSimultaneous.CompareAndSwap(maxValue, current) {
|
|
break
|
|
}
|
|
}
|
|
|
|
time.Sleep(10 * time.Millisecond)
|
|
currentRunning.Add(-1)
|
|
return nil
|
|
}
|
|
}
|
|
|
|
err := NewParallelExecutor(2, executors...)(ctx)
|
|
|
|
assert.NoError(t, err)
|
|
assert.LessOrEqual(t, maxSimultaneous.Load(), int32(2),
|
|
"Should not exceed max-parallel: 2")
|
|
}
|
|
|
|
// Test that verifies max-parallel: 1 enforces sequential execution
|
|
func TestMaxParallel1Sequential(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
var currentRunning atomic.Int32
|
|
var maxSimultaneous atomic.Int32
|
|
var executionOrder []int
|
|
var orderMutex sync.Mutex
|
|
|
|
executors := make([]Executor, 5)
|
|
for i := range 5 {
|
|
taskID := i
|
|
executors[i] = func(ctx context.Context) error {
|
|
current := currentRunning.Add(1)
|
|
|
|
// Track execution order
|
|
orderMutex.Lock()
|
|
executionOrder = append(executionOrder, taskID)
|
|
orderMutex.Unlock()
|
|
|
|
// Update max if needed
|
|
for {
|
|
maxValue := maxSimultaneous.Load()
|
|
if current <= maxValue || maxSimultaneous.CompareAndSwap(maxValue, current) {
|
|
break
|
|
}
|
|
}
|
|
|
|
time.Sleep(20 * time.Millisecond)
|
|
currentRunning.Add(-1)
|
|
return nil
|
|
}
|
|
}
|
|
|
|
err := NewParallelExecutor(1, executors...)(ctx)
|
|
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int32(1), maxSimultaneous.Load(),
|
|
"max-parallel: 1 should only run 1 task at a time")
|
|
assert.Len(t, executionOrder, 5, "All 5 tasks should have executed")
|
|
}
|