mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-04-25 05:10:31 +08:00
Use `golangci-lint fmt` to format code, upgrading `.golangci.yml` to v2 and mirroring the linter configuration used by https://github.com/go-gitea/gitea. `gci` now handles import ordering into standard, project-local, blank, and default groups. Mirrors https://github.com/go-gitea/gitea/pull/37194. Changes: - Upgrade `.golangci.yml` to v2 format with the same linter set as gitea (minus `prealloc`, `unparam`, `testifylint`, `nilnil` which produced too many pre-existing issues) - Add path-based exclusions (`bodyclose`, `gosec` in tests; `gosec:G115`/`G117` globally) - Run lint via `make lint-go` in CI instead of `golangci/golangci-lint-action`, matching the pattern used by other Gitea repos - Apply safe auto-fixes (`modernize`, `perfsprint`, `usetesting`, etc.) - Add explanations to existing `//nolint` directives - Remove dead code (unused `newRemoteReusableWorkflow` and `networkName`), duplicate imports, and shadowed `max` builtins - Replace deprecated `docker/distribution/reference` with `distribution/reference` - Fix `Deprecated:` comment casing and simplify nil/len checks --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/act/pulls/163 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-committed-by: silverwind <me@silverwind.io>
151 lines
4.5 KiB
Go
151 lines
4.5 KiB
Go
package container
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
log "github.com/sirupsen/logrus"
|
|
assert "github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func init() {
|
|
log.SetLevel(log.DebugLevel)
|
|
}
|
|
|
|
var originalCommonSocketLocations = CommonSocketLocations
|
|
|
|
func TestGetSocketAndHostWithSocket(t *testing.T) {
|
|
// Arrange
|
|
CommonSocketLocations = originalCommonSocketLocations
|
|
dockerHost := "unix:///my/docker/host.sock"
|
|
socketURI := "/path/to/my.socket"
|
|
t.Setenv("DOCKER_HOST", dockerHost)
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost(socketURI)
|
|
|
|
// Assert
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, SocketAndHost{socketURI, dockerHost}, ret)
|
|
}
|
|
|
|
func TestGetSocketAndHostNoSocket(t *testing.T) {
|
|
// Arrange
|
|
dockerHost := "unix:///my/docker/host.sock"
|
|
t.Setenv("DOCKER_HOST", dockerHost)
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost("")
|
|
|
|
// Assert
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, SocketAndHost{dockerHost, dockerHost}, ret)
|
|
}
|
|
|
|
func TestGetSocketAndHostOnlySocket(t *testing.T) {
|
|
// Arrange
|
|
socketURI := "/path/to/my.socket"
|
|
os.Unsetenv("DOCKER_HOST")
|
|
CommonSocketLocations = originalCommonSocketLocations
|
|
defaultSocket, defaultSocketFound := socketLocation()
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost(socketURI)
|
|
|
|
// Assert
|
|
assert.NoError(t, err, "Expected no error from GetSocketAndHost")
|
|
assert.Equal(t, true, defaultSocketFound, "Expected to find default socket")
|
|
assert.Equal(t, socketURI, ret.Socket, "Expected socket to match common location")
|
|
assert.Equal(t, defaultSocket, ret.Host, "Expected ret.Host to match default socket location")
|
|
}
|
|
|
|
func TestGetSocketAndHostDontMount(t *testing.T) {
|
|
// Arrange
|
|
CommonSocketLocations = originalCommonSocketLocations
|
|
dockerHost := "unix:///my/docker/host.sock"
|
|
t.Setenv("DOCKER_HOST", dockerHost)
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost("-")
|
|
|
|
// Assert
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, SocketAndHost{"-", dockerHost}, ret)
|
|
}
|
|
|
|
func TestGetSocketAndHostNoHostNoSocket(t *testing.T) {
|
|
// Arrange
|
|
CommonSocketLocations = originalCommonSocketLocations
|
|
os.Unsetenv("DOCKER_HOST")
|
|
defaultSocket, found := socketLocation()
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost("")
|
|
|
|
// Assert
|
|
assert.Equal(t, true, found, "Expected a default socket to be found")
|
|
assert.Nil(t, err, "Expected no error from GetSocketAndHost")
|
|
assert.Equal(t, SocketAndHost{defaultSocket, defaultSocket}, ret, "Expected to match default socket location")
|
|
}
|
|
|
|
// Catch
|
|
// > Your code breaks setting DOCKER_HOST if shouldMount is false.
|
|
// > This happens if neither DOCKER_HOST nor --container-daemon-socket has a value, but socketLocation() returns a URI
|
|
func TestGetSocketAndHostNoHostNoSocketDefaultLocation(t *testing.T) {
|
|
// Arrange
|
|
mySocketFile, tmpErr := os.CreateTemp(t.TempDir(), "act-*.sock")
|
|
mySocket := mySocketFile.Name()
|
|
unixSocket := "unix://" + mySocket
|
|
defer os.RemoveAll(mySocket)
|
|
assert.NoError(t, tmpErr)
|
|
os.Unsetenv("DOCKER_HOST")
|
|
|
|
CommonSocketLocations = []string{mySocket}
|
|
defaultSocket, found := socketLocation()
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost("")
|
|
|
|
// Assert
|
|
assert.Equal(t, unixSocket, defaultSocket, "Expected default socket to match common socket location")
|
|
assert.Equal(t, true, found, "Expected default socket to be found")
|
|
assert.Nil(t, err, "Expected no error from GetSocketAndHost")
|
|
assert.Equal(t, SocketAndHost{unixSocket, unixSocket}, ret, "Expected to match default socket location")
|
|
}
|
|
|
|
func TestGetSocketAndHostNoHostInvalidSocket(t *testing.T) {
|
|
// Arrange
|
|
os.Unsetenv("DOCKER_HOST")
|
|
mySocket := "/my/socket/path.sock"
|
|
CommonSocketLocations = []string{"/unusual", "/socket", "/location"}
|
|
defaultSocket, found := socketLocation()
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost(mySocket)
|
|
|
|
// Assert
|
|
assert.Equal(t, false, found, "Expected no default socket to be found")
|
|
assert.Equal(t, "", defaultSocket, "Expected no default socket to be found")
|
|
assert.Equal(t, SocketAndHost{}, ret, "Expected to match default socket location")
|
|
assert.Error(t, err, "Expected an error in invalid state")
|
|
}
|
|
|
|
func TestGetSocketAndHostOnlySocketValidButUnusualLocation(t *testing.T) {
|
|
// Arrange
|
|
socketURI := "unix:///path/to/my.socket"
|
|
CommonSocketLocations = []string{"/unusual", "/location"}
|
|
os.Unsetenv("DOCKER_HOST")
|
|
defaultSocket, found := socketLocation()
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost(socketURI)
|
|
|
|
// Assert
|
|
// Default socket locations
|
|
assert.Equal(t, "", defaultSocket, "Expect default socket location to be empty")
|
|
assert.Equal(t, false, found, "Expected no default socket to be found")
|
|
// Sane default
|
|
assert.Nil(t, err, "Expect no error from GetSocketAndHost")
|
|
assert.Equal(t, socketURI, ret.Host, "Expect host to default to unusual socket")
|
|
}
|