mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-04-25 21:30:23 +08:00
Use `golangci-lint fmt` to format code, upgrading `.golangci.yml` to v2 and mirroring the linter configuration used by https://github.com/go-gitea/gitea. `gci` now handles import ordering into standard, project-local, blank, and default groups. Mirrors https://github.com/go-gitea/gitea/pull/37194. Changes: - Upgrade `.golangci.yml` to v2 format with the same linter set as gitea (minus `prealloc`, `unparam`, `testifylint`, `nilnil` which produced too many pre-existing issues) - Add path-based exclusions (`bodyclose`, `gosec` in tests; `gosec:G115`/`G117` globally) - Run lint via `make lint-go` in CI instead of `golangci/golangci-lint-action`, matching the pattern used by other Gitea repos - Apply safe auto-fixes (`modernize`, `perfsprint`, `usetesting`, etc.) - Add explanations to existing `//nolint` directives - Remove dead code (unused `newRemoteReusableWorkflow` and `networkName`), duplicate imports, and shadowed `max` builtins - Replace deprecated `docker/distribution/reference` with `distribution/reference` - Fix `Deprecated:` comment casing and simplify nil/len checks --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/act/pulls/163 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-committed-by: silverwind <me@silverwind.io>
213 lines
4.3 KiB
Go
213 lines
4.3 KiB
Go
package model
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
log "github.com/sirupsen/logrus"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestSetRef(t *testing.T) {
|
|
log.SetLevel(log.DebugLevel)
|
|
|
|
oldFindGitRef := findGitRef
|
|
oldFindGitRevision := findGitRevision
|
|
defer func() { findGitRef = oldFindGitRef }()
|
|
defer func() { findGitRevision = oldFindGitRevision }()
|
|
|
|
findGitRef = func(ctx context.Context, file string) (string, error) {
|
|
return "refs/heads/master", nil
|
|
}
|
|
|
|
findGitRevision = func(ctx context.Context, file string) (string, string, error) {
|
|
return "", "1234fakesha", nil
|
|
}
|
|
|
|
tables := []struct {
|
|
eventName string
|
|
event map[string]any
|
|
ref string
|
|
refName string
|
|
}{
|
|
{
|
|
eventName: "pull_request_target",
|
|
event: map[string]any{},
|
|
ref: "refs/heads/master",
|
|
refName: "master",
|
|
},
|
|
{
|
|
eventName: "pull_request",
|
|
event: map[string]any{
|
|
"number": 1234.,
|
|
},
|
|
ref: "refs/pull/1234/merge",
|
|
refName: "1234/merge",
|
|
},
|
|
{
|
|
eventName: "deployment",
|
|
event: map[string]any{
|
|
"deployment": map[string]any{
|
|
"ref": "refs/heads/somebranch",
|
|
},
|
|
},
|
|
ref: "refs/heads/somebranch",
|
|
refName: "somebranch",
|
|
},
|
|
{
|
|
eventName: "release",
|
|
event: map[string]any{
|
|
"release": map[string]any{
|
|
"tag_name": "v1.0.0",
|
|
},
|
|
},
|
|
ref: "refs/tags/v1.0.0",
|
|
refName: "v1.0.0",
|
|
},
|
|
{
|
|
eventName: "push",
|
|
event: map[string]any{
|
|
"ref": "refs/heads/somebranch",
|
|
},
|
|
ref: "refs/heads/somebranch",
|
|
refName: "somebranch",
|
|
},
|
|
{
|
|
eventName: "unknown",
|
|
event: map[string]any{
|
|
"repository": map[string]any{
|
|
"default_branch": "main",
|
|
},
|
|
},
|
|
ref: "refs/heads/main",
|
|
refName: "main",
|
|
},
|
|
{
|
|
eventName: "no-event",
|
|
event: map[string]any{},
|
|
ref: "refs/heads/master",
|
|
refName: "master",
|
|
},
|
|
}
|
|
|
|
for _, table := range tables {
|
|
t.Run(table.eventName, func(t *testing.T) {
|
|
ghc := &GithubContext{
|
|
EventName: table.eventName,
|
|
BaseRef: "master",
|
|
Event: table.event,
|
|
}
|
|
|
|
ghc.SetRef(context.Background(), "main", "/some/dir")
|
|
ghc.SetRefTypeAndName()
|
|
|
|
assert.Equal(t, table.ref, ghc.Ref)
|
|
assert.Equal(t, table.refName, ghc.RefName)
|
|
})
|
|
}
|
|
|
|
t.Run("no-default-branch", func(t *testing.T) {
|
|
findGitRef = func(ctx context.Context, file string) (string, error) {
|
|
return "", errors.New("no default branch")
|
|
}
|
|
|
|
ghc := &GithubContext{
|
|
EventName: "no-default-branch",
|
|
Event: map[string]any{},
|
|
}
|
|
|
|
ghc.SetRef(context.Background(), "", "/some/dir")
|
|
|
|
assert.Equal(t, "refs/heads/master", ghc.Ref)
|
|
})
|
|
}
|
|
|
|
func TestSetSha(t *testing.T) {
|
|
log.SetLevel(log.DebugLevel)
|
|
|
|
oldFindGitRef := findGitRef
|
|
oldFindGitRevision := findGitRevision
|
|
defer func() { findGitRef = oldFindGitRef }()
|
|
defer func() { findGitRevision = oldFindGitRevision }()
|
|
|
|
findGitRef = func(ctx context.Context, file string) (string, error) {
|
|
return "refs/heads/master", nil
|
|
}
|
|
|
|
findGitRevision = func(ctx context.Context, file string) (string, string, error) {
|
|
return "", "1234fakesha", nil
|
|
}
|
|
|
|
tables := []struct {
|
|
eventName string
|
|
event map[string]any
|
|
sha string
|
|
}{
|
|
{
|
|
eventName: "pull_request_target",
|
|
event: map[string]any{
|
|
"pull_request": map[string]any{
|
|
"base": map[string]any{
|
|
"sha": "pr-base-sha",
|
|
},
|
|
},
|
|
},
|
|
sha: "pr-base-sha",
|
|
},
|
|
{
|
|
eventName: "pull_request",
|
|
event: map[string]any{
|
|
"number": 1234.,
|
|
},
|
|
sha: "1234fakesha",
|
|
},
|
|
{
|
|
eventName: "deployment",
|
|
event: map[string]any{
|
|
"deployment": map[string]any{
|
|
"sha": "deployment-sha",
|
|
},
|
|
},
|
|
sha: "deployment-sha",
|
|
},
|
|
{
|
|
eventName: "release",
|
|
event: map[string]any{},
|
|
sha: "1234fakesha",
|
|
},
|
|
{
|
|
eventName: "push",
|
|
event: map[string]any{
|
|
"after": "push-sha",
|
|
"deleted": false,
|
|
},
|
|
sha: "push-sha",
|
|
},
|
|
{
|
|
eventName: "unknown",
|
|
event: map[string]any{},
|
|
sha: "1234fakesha",
|
|
},
|
|
{
|
|
eventName: "no-event",
|
|
event: map[string]any{},
|
|
sha: "1234fakesha",
|
|
},
|
|
}
|
|
|
|
for _, table := range tables {
|
|
t.Run(table.eventName, func(t *testing.T) {
|
|
ghc := &GithubContext{
|
|
EventName: table.eventName,
|
|
BaseRef: "master",
|
|
Event: table.event,
|
|
}
|
|
|
|
ghc.SetSha(context.Background(), "/some/dir")
|
|
|
|
assert.Equal(t, table.sha, ghc.Sha)
|
|
})
|
|
}
|
|
}
|