mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-05-01 00:10:31 +08:00
Removes 88 `nolint` directives (386 → 298) via mechanical, zero-regression cleanups: - **38 `bodyclose`** in `act/artifactcache/handler_test.go`: replaced by `defer resp.Body.Close()` after each HTTP call. - **21 dead directives** (`gocyclo`, `dogsled`, `contextcheck`): none of these linters are enabled in `.golangci.yml`, so the directives were doing nothing. - **29 `testifylint`** directives whose underlying issues were addressed by mechanical rewrites: - `assert.Nil(t, err)` → `assert.NoError(t, err)` - `assert.NotNil(t, err)` → `assert.Error(t, err)` - `assert.Equal(t, true/false, x)` → `assert.True/False(t, x)` - `assert.Equal(t, 0, len(x))` → `assert.Empty(t, x)` - `assert.Equal(t, N, len(x))` → `assert.Len(t, x, N)` - `assert.Len(t, x, 0)` → `assert.Empty(t, x)` Many `testifylint` directives still apply because they flag `require-error` (i.e. testifylint wants `require.NoError` instead of `assert.NoError` for early bail-out). That's a behavior change (fail-fast vs continue) and out of scope for this purely mechanical cleanup — those can be addressed in a follow-up. Same for `expected-actual`, `equal-values`, `error-is-as`, and the remaining `nilnil` / `unparam` / `forbidigo` / `staticcheck` / `goheader` / `dupl` directives. `golangci-lint run` is clean. Tests pass for all touched packages. --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/act_runner/pulls/864 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <2021+silverwind@noreply.gitea.com> Co-committed-by: silverwind <2021+silverwind@noreply.gitea.com>
155 lines
5.2 KiB
Go
155 lines
5.2 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// Copyright 2024 The nektos/act Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package container
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
log "github.com/sirupsen/logrus"
|
|
assert "github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func init() {
|
|
log.SetLevel(log.DebugLevel)
|
|
}
|
|
|
|
var originalCommonSocketLocations = CommonSocketLocations
|
|
|
|
func TestGetSocketAndHostWithSocket(t *testing.T) {
|
|
// Arrange
|
|
CommonSocketLocations = originalCommonSocketLocations
|
|
dockerHost := "unix:///my/docker/host.sock"
|
|
socketURI := "/path/to/my.socket"
|
|
t.Setenv("DOCKER_HOST", dockerHost)
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost(socketURI)
|
|
|
|
// Assert
|
|
assert.NoError(t, err) //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.Equal(t, SocketAndHost{socketURI, dockerHost}, ret)
|
|
}
|
|
|
|
func TestGetSocketAndHostNoSocket(t *testing.T) {
|
|
// Arrange
|
|
dockerHost := "unix:///my/docker/host.sock"
|
|
t.Setenv("DOCKER_HOST", dockerHost)
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost("")
|
|
|
|
// Assert
|
|
assert.NoError(t, err) //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.Equal(t, SocketAndHost{dockerHost, dockerHost}, ret)
|
|
}
|
|
|
|
func TestGetSocketAndHostOnlySocket(t *testing.T) {
|
|
// Arrange
|
|
socketURI := "/path/to/my.socket"
|
|
os.Unsetenv("DOCKER_HOST")
|
|
CommonSocketLocations = originalCommonSocketLocations
|
|
defaultSocket, defaultSocketFound := socketLocation()
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost(socketURI)
|
|
|
|
// Assert
|
|
assert.NoError(t, err, "Expected no error from GetSocketAndHost") //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.True(t, defaultSocketFound, "Expected to find default socket")
|
|
assert.Equal(t, socketURI, ret.Socket, "Expected socket to match common location")
|
|
assert.Equal(t, defaultSocket, ret.Host, "Expected ret.Host to match default socket location")
|
|
}
|
|
|
|
func TestGetSocketAndHostDontMount(t *testing.T) {
|
|
// Arrange
|
|
CommonSocketLocations = originalCommonSocketLocations
|
|
dockerHost := "unix:///my/docker/host.sock"
|
|
t.Setenv("DOCKER_HOST", dockerHost)
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost("-")
|
|
|
|
// Assert
|
|
assert.NoError(t, err) //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.Equal(t, SocketAndHost{"-", dockerHost}, ret)
|
|
}
|
|
|
|
func TestGetSocketAndHostNoHostNoSocket(t *testing.T) {
|
|
// Arrange
|
|
CommonSocketLocations = originalCommonSocketLocations
|
|
os.Unsetenv("DOCKER_HOST")
|
|
defaultSocket, found := socketLocation()
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost("")
|
|
|
|
// Assert
|
|
assert.True(t, found, "Expected a default socket to be found")
|
|
assert.NoError(t, err, "Expected no error from GetSocketAndHost") //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.Equal(t, SocketAndHost{defaultSocket, defaultSocket}, ret, "Expected to match default socket location")
|
|
}
|
|
|
|
// Catch
|
|
// > Your code breaks setting DOCKER_HOST if shouldMount is false.
|
|
// > This happens if neither DOCKER_HOST nor --container-daemon-socket has a value, but socketLocation() returns a URI
|
|
func TestGetSocketAndHostNoHostNoSocketDefaultLocation(t *testing.T) {
|
|
// Arrange
|
|
mySocketFile, tmpErr := os.CreateTemp(t.TempDir(), "act-*.sock")
|
|
mySocket := mySocketFile.Name()
|
|
unixSocket := "unix://" + mySocket
|
|
defer os.RemoveAll(mySocket)
|
|
assert.NoError(t, tmpErr) //nolint:testifylint // pre-existing issue from nektos/act
|
|
os.Unsetenv("DOCKER_HOST")
|
|
|
|
CommonSocketLocations = []string{mySocket}
|
|
defaultSocket, found := socketLocation()
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost("")
|
|
|
|
// Assert
|
|
assert.Equal(t, unixSocket, defaultSocket, "Expected default socket to match common socket location")
|
|
assert.True(t, found, "Expected default socket to be found")
|
|
assert.NoError(t, err, "Expected no error from GetSocketAndHost") //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.Equal(t, SocketAndHost{unixSocket, unixSocket}, ret, "Expected to match default socket location")
|
|
}
|
|
|
|
func TestGetSocketAndHostNoHostInvalidSocket(t *testing.T) {
|
|
// Arrange
|
|
os.Unsetenv("DOCKER_HOST")
|
|
mySocket := "/my/socket/path.sock"
|
|
CommonSocketLocations = []string{"/unusual", "/socket", "/location"}
|
|
defaultSocket, found := socketLocation()
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost(mySocket)
|
|
|
|
// Assert
|
|
assert.False(t, found, "Expected no default socket to be found")
|
|
assert.Equal(t, "", defaultSocket, "Expected no default socket to be found") //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.Equal(t, SocketAndHost{}, ret, "Expected to match default socket location")
|
|
assert.Error(t, err, "Expected an error in invalid state")
|
|
}
|
|
|
|
func TestGetSocketAndHostOnlySocketValidButUnusualLocation(t *testing.T) {
|
|
// Arrange
|
|
socketURI := "unix:///path/to/my.socket"
|
|
CommonSocketLocations = []string{"/unusual", "/location"}
|
|
os.Unsetenv("DOCKER_HOST")
|
|
defaultSocket, found := socketLocation()
|
|
|
|
// Act
|
|
ret, err := GetSocketAndHost(socketURI)
|
|
|
|
// Assert
|
|
// Default socket locations
|
|
assert.Equal(t, "", defaultSocket, "Expect default socket location to be empty") //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.False(t, found, "Expected no default socket to be found")
|
|
// Sane default
|
|
assert.NoError(t, err, "Expect no error from GetSocketAndHost") //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.Equal(t, socketURI, ret.Host, "Expect host to default to unusual socket")
|
|
}
|