mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-03-20 03:46:09 +08:00
## Summary - Replace old `.golangci.yml` (v1 format) with v2 format, aligned with gitea's lint config - Add `lint-go`, `lint-go-fix`, and `lint` Makefile targets using golangci-lint v2.10.1 - Replace `make vet` with `make lint` in CI workflow (lint includes vet) - Fix all 35 lint issues: modernize (maps.Copy, range over int, any), perfsprint (errors.New), unparam (remove unused parameters), revive (var naming), staticcheck, forbidigo exclusion for cmd/ - Make `security-check` non-fatal (apply https://github.com/go-gitea/gitea/pull/36681) - Remove dead gocritic exclusion rules (commentFormatting, exitAfterDefer) - Remove dead linter exclusions and disabled checks (singleCaseSwitch, ST1003, QF1001, QF1006, QF1008, testifylint go-require/require-error, test file exclusions for dupl/errcheck/staticcheck/unparam) ## Test plan - [x] `golangci-lint run` passes - [x] `go build ./...` passes - [x] `go test ./...` passes --------- Co-authored-by: ChristopherHX <christopher.homberger@web.de> Co-authored-by: Christopher Homberger <christopher.homberger@web.de> Reviewed-on: https://gitea.com/gitea/act_runner/pulls/803 Reviewed-by: ChristopherHX <christopherhx@noreply.gitea.com>
330 lines
7.5 KiB
Go
330 lines
7.5 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package run
|
|
|
|
import (
|
|
"testing"
|
|
|
|
runnerv1 "code.gitea.io/actions-proto-go/runner/v1"
|
|
"github.com/nektos/act/pkg/model"
|
|
"github.com/stretchr/testify/require"
|
|
"go.yaml.in/yaml/v4"
|
|
"gotest.tools/v3/assert"
|
|
)
|
|
|
|
func Test_generateWorkflow(t *testing.T) {
|
|
type args struct {
|
|
task *runnerv1.Task
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
assert func(t *testing.T, wf *model.Workflow)
|
|
want1 string
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "has needs",
|
|
args: args{
|
|
task: &runnerv1.Task{
|
|
WorkflowPayload: []byte(`
|
|
name: Build and deploy
|
|
on: push
|
|
|
|
jobs:
|
|
job9:
|
|
needs: build
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- run: ./deploy --build ${{ needs.job1.outputs.output1 }}
|
|
- run: ./deploy --build ${{ needs.job2.outputs.output2 }}
|
|
`),
|
|
Needs: map[string]*runnerv1.TaskNeed{
|
|
"job1": {
|
|
Outputs: map[string]string{
|
|
"output1": "output1 value",
|
|
},
|
|
Result: runnerv1.Result_RESULT_SUCCESS,
|
|
},
|
|
"job2": {
|
|
Outputs: map[string]string{
|
|
"output2": "output2 value",
|
|
},
|
|
Result: runnerv1.Result_RESULT_SUCCESS,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
assert: func(t *testing.T, wf *model.Workflow) {
|
|
assert.DeepEqual(t, wf.GetJob("job9").Needs(), []string{"job1", "job2"})
|
|
},
|
|
want1: "job9",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "no needs",
|
|
args: args{
|
|
task: &runnerv1.Task{
|
|
WorkflowPayload: []byte(`
|
|
name: Simple workflow
|
|
on: push
|
|
|
|
jobs:
|
|
test:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- run: echo "hello"
|
|
`),
|
|
Needs: map[string]*runnerv1.TaskNeed{},
|
|
},
|
|
},
|
|
assert: func(t *testing.T, wf *model.Workflow) {
|
|
job := wf.GetJob("test")
|
|
assert.DeepEqual(t, job.Needs(), []string{})
|
|
assert.Equal(t, len(job.Steps), 2)
|
|
},
|
|
want1: "test",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "needs list",
|
|
args: args{
|
|
task: &runnerv1.Task{
|
|
WorkflowPayload: []byte(`
|
|
name: Workflow with list needs
|
|
on: push
|
|
|
|
jobs:
|
|
deploy:
|
|
needs: [build, test, lint]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo "deploying"
|
|
`),
|
|
Needs: map[string]*runnerv1.TaskNeed{
|
|
"build": {
|
|
Outputs: map[string]string{},
|
|
Result: runnerv1.Result_RESULT_SUCCESS,
|
|
},
|
|
"test": {
|
|
Outputs: map[string]string{
|
|
"coverage": "80%",
|
|
},
|
|
Result: runnerv1.Result_RESULT_SUCCESS,
|
|
},
|
|
"lint": {
|
|
Outputs: map[string]string{},
|
|
Result: runnerv1.Result_RESULT_FAILURE,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
assert: func(t *testing.T, wf *model.Workflow) {
|
|
job := wf.GetJob("deploy")
|
|
needs := job.Needs()
|
|
assert.DeepEqual(t, needs, []string{"build", "lint", "test"})
|
|
assert.Equal(t, wf.Jobs["test"].Outputs["coverage"], "80%")
|
|
assert.Equal(t, wf.Jobs["lint"].Result, "failure")
|
|
},
|
|
want1: "deploy",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "workflow env and defaults",
|
|
args: args{
|
|
task: &runnerv1.Task{
|
|
WorkflowPayload: []byte(`
|
|
name: Complex workflow
|
|
on:
|
|
push:
|
|
branches: [main, develop]
|
|
pull_request:
|
|
types: [opened, synchronize]
|
|
|
|
env:
|
|
NODE_ENV: production
|
|
CI: "true"
|
|
|
|
jobs:
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
env:
|
|
BUILD_TYPE: release
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: actions/setup-node@v3
|
|
with:
|
|
node-version: "18"
|
|
- run: npm ci
|
|
- run: npm run build
|
|
`),
|
|
Needs: map[string]*runnerv1.TaskNeed{},
|
|
},
|
|
},
|
|
assert: func(t *testing.T, wf *model.Workflow) {
|
|
assert.Equal(t, wf.Name, "Complex workflow")
|
|
assert.Equal(t, wf.Env["NODE_ENV"], "production")
|
|
assert.Equal(t, wf.Env["CI"], "true")
|
|
job := wf.GetJob("build")
|
|
assert.Equal(t, len(job.Steps), 4)
|
|
},
|
|
want1: "build",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "job with container and services",
|
|
args: args{
|
|
task: &runnerv1.Task{
|
|
WorkflowPayload: []byte(`
|
|
name: Integration tests
|
|
on: push
|
|
|
|
jobs:
|
|
integration:
|
|
runs-on: ubuntu-latest
|
|
container:
|
|
image: node:18
|
|
services:
|
|
postgres:
|
|
image: postgres:15
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- run: npm test
|
|
`),
|
|
Needs: map[string]*runnerv1.TaskNeed{},
|
|
},
|
|
},
|
|
assert: func(t *testing.T, wf *model.Workflow) {
|
|
job := wf.GetJob("integration")
|
|
container := job.Container()
|
|
assert.Equal(t, container.Image, "node:18")
|
|
assert.Equal(t, job.Services["postgres"].Image, "postgres:15")
|
|
},
|
|
want1: "integration",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "job with matrix strategy",
|
|
args: args{
|
|
task: &runnerv1.Task{
|
|
WorkflowPayload: []byte(`
|
|
name: Matrix build
|
|
on: push
|
|
|
|
jobs:
|
|
test:
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
matrix:
|
|
go-version: ["1.21", "1.22"]
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- run: go test ./...
|
|
`),
|
|
Needs: map[string]*runnerv1.TaskNeed{},
|
|
},
|
|
},
|
|
assert: func(t *testing.T, wf *model.Workflow) {
|
|
job := wf.GetJob("test")
|
|
matrixes, err := job.GetMatrixes()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, len(matrixes), 2)
|
|
},
|
|
want1: "test",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "special yaml characters in values",
|
|
args: args{
|
|
task: &runnerv1.Task{
|
|
WorkflowPayload: []byte("name: \"Special: characters & test\"\non: push\n\njobs:\n test:\n runs-on: ubuntu-latest\n steps:\n - run: 'echo \"hello: world\"'\n - run: 'echo \"quotes & ampersands\"'\n - run: |\n echo \"multiline\"\n echo \"script\"\n"),
|
|
Needs: map[string]*runnerv1.TaskNeed{},
|
|
},
|
|
},
|
|
assert: func(t *testing.T, wf *model.Workflow) {
|
|
assert.Equal(t, wf.Name, "Special: characters & test")
|
|
job := wf.GetJob("test")
|
|
assert.Equal(t, len(job.Steps), 3)
|
|
},
|
|
want1: "test",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "invalid yaml",
|
|
args: args{
|
|
task: &runnerv1.Task{
|
|
WorkflowPayload: []byte(`
|
|
name: Bad workflow
|
|
on: push
|
|
jobs:
|
|
test:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- run: echo "ok"
|
|
bad-indent: true
|
|
`),
|
|
Needs: map[string]*runnerv1.TaskNeed{},
|
|
},
|
|
},
|
|
assert: nil,
|
|
want1: "",
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got, got1, err := generateWorkflow(tt.args.task)
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
return
|
|
}
|
|
require.NoError(t, err)
|
|
tt.assert(t, got)
|
|
assert.Equal(t, got1, tt.want1)
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_yamlV4NodeRoundTrip(t *testing.T) {
|
|
t.Run("marshal sequence node", func(t *testing.T) {
|
|
node := yaml.Node{
|
|
Kind: yaml.SequenceNode,
|
|
Content: []*yaml.Node{
|
|
{Kind: yaml.ScalarNode, Value: "a"},
|
|
{Kind: yaml.ScalarNode, Value: "b"},
|
|
{Kind: yaml.ScalarNode, Value: "c"},
|
|
},
|
|
}
|
|
|
|
out, err := yaml.Marshal(&node)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, string(out), "- a\n- b\n- c\n")
|
|
})
|
|
|
|
t.Run("unmarshal and re-marshal workflow", func(t *testing.T) {
|
|
input := []byte("name: test\non: push\njobs:\n build:\n runs-on: ubuntu-latest\n steps:\n - run: echo hello\n")
|
|
|
|
var wf map[string]any
|
|
err := yaml.Unmarshal(input, &wf)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, wf["name"], "test")
|
|
|
|
out, err := yaml.Marshal(wf)
|
|
require.NoError(t, err)
|
|
|
|
var wf2 map[string]any
|
|
err = yaml.Unmarshal(out, &wf2)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, wf2["name"], "test")
|
|
})
|
|
|
|
t.Run("node kind constants", func(t *testing.T) {
|
|
// Verify yaml/v4 node kind constants are usable (same API as v3)
|
|
require.NotEqual(t, yaml.ScalarNode, yaml.SequenceNode)
|
|
require.NotEqual(t, yaml.SequenceNode, yaml.MappingNode)
|
|
})
|
|
}
|