mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-10-30 03:46:33 +08:00
Contains a number of small bug fixes where jobs behaved differently from GitHub or failed silently.
1. Hooks fail on a refused `::set-env::` or `::add-path::` and no longer inherit the last step's identity
1. Docker build, exec and wait errors are returned instead of swallowed, token-only registry credentials work, logs of `--tty` services decode
1. Env files split lines like GitHub on each OS, so a carriage return is kept on Linux and CRLF ends a line on Windows, empty heredoc names or delimiters are rejected
1. Post steps run after their pre step even when main was skipped, composites see undeclared inputs, `runs.args` wins without `with.args` being parsed
1. Docker actions skip evaluating defaults of inputs given in `with` and read `entryPoint` and `args` in any case, a lowercase `dockerfile` is found, undeclared inputs get GitHub's warning
1. A user-set `CI` is kept, `GITHUB_REPOSITORY_ID` and the other missing `GITHUB_*` variables are exported
1. `timeout-minutes` can read the step's own `env`, a step-level `ACTIONS_ALLOW_UNSECURE_COMMANDS: false` beats a job-level `true` while the runner's own opt-in still wins, `pwsh` quotes the script path
1. A step `env:` given as one expression such as `${{ fromJSON(matrix.env) }}` is applied, `hashFiles` fails with GitHub's messages on script errors and after 120 seconds, a job image without node still gets an empty hash
1. A step whose command files cannot be reset fails instead of importing stale ones, a timeout between steps fails the job instead of reporting success
1. One named volume can be mounted at several paths, host-mode PTY steps keep their last output when they fail, host scratch directories are removed when job setup fails
1. Cancelling a step right after it starts kills its whole process tree
1. Cache prefix restores pick the newest entry created within the same second, also on S3, cache commits with a wrong size are rejected
1. Artifact chunks are written at their offset, download URLs are escaped, listing a run without artifacts no longer crashes
1. Poll backoff reaches `fetch_interval_max`, proxy passwords are masked in more forms, secrets are also masked in step names and in their quoted form in the runner log, a failed final report is logged
1. On Windows hosts a differently cased unsecure-commands opt-in or proxy variable counts, and an early cancel no longer leaks a job object handle
1. Interactive `register` prompts for a missing token and stops on SIGTERM, `exec --list --detect-event` no longer panics without events, `config set` works on `cache.s3` keys
Reviewed-on: https://gitea.com/gitea/runner/pulls/1338
Reviewed-by: bircni <bircni@icloud.com>
Co-authored-by: silverwind <me@silverwind.io>
247 lines
5.7 KiB
Go
247 lines
5.7 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// Copyright 2022 The nektos/act Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package ghcontext
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"gitea.dev/actionslib/pkg/model"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestSetRef(t *testing.T) {
|
|
oldFindGitRef := findGitRef
|
|
defer func() { findGitRef = oldFindGitRef }()
|
|
|
|
findGitRef = func(_ctx context.Context, _file string) (string, error) {
|
|
return "refs/heads/master", nil
|
|
}
|
|
|
|
tables := []struct {
|
|
eventName string
|
|
event map[string]any
|
|
ref string
|
|
refName string
|
|
}{
|
|
{
|
|
eventName: "pull_request_target",
|
|
event: map[string]any{},
|
|
ref: "refs/heads/master",
|
|
refName: "master",
|
|
},
|
|
{
|
|
eventName: "pull_request",
|
|
event: map[string]any{
|
|
"number": 1234.,
|
|
},
|
|
ref: "refs/pull/1234/merge",
|
|
refName: "1234/merge",
|
|
},
|
|
{
|
|
eventName: "pull_request_review",
|
|
event: map[string]any{"pull_request": map[string]any{"number": 1234.}},
|
|
ref: "refs/pull/1234/merge",
|
|
refName: "1234/merge",
|
|
},
|
|
{
|
|
eventName: "pull_request",
|
|
event: map[string]any{"number": 1234., "action": "closed", "pull_request": map[string]any{"merged": true}},
|
|
ref: "refs/heads/master",
|
|
refName: "master",
|
|
},
|
|
{
|
|
eventName: "pull_request",
|
|
event: map[string]any{"number": 1234., "action": "closed", "pull_request": map[string]any{"merged": false}},
|
|
ref: "refs/pull/1234/merge",
|
|
refName: "1234/merge",
|
|
},
|
|
{
|
|
eventName: "pull_request_review_comment",
|
|
event: map[string]any{"pull_request": map[string]any{"number": 1234.}},
|
|
ref: "refs/pull/1234/merge",
|
|
refName: "1234/merge",
|
|
},
|
|
{
|
|
eventName: "deployment",
|
|
event: map[string]any{
|
|
"deployment": map[string]any{
|
|
"ref": "refs/heads/somebranch",
|
|
},
|
|
},
|
|
ref: "refs/heads/somebranch",
|
|
refName: "somebranch",
|
|
},
|
|
{
|
|
eventName: "release",
|
|
event: map[string]any{
|
|
"release": map[string]any{
|
|
"tag_name": "v1.0.0",
|
|
},
|
|
},
|
|
ref: "refs/tags/v1.0.0",
|
|
refName: "v1.0.0",
|
|
},
|
|
{
|
|
eventName: "push",
|
|
event: map[string]any{
|
|
"ref": "refs/heads/somebranch",
|
|
},
|
|
ref: "refs/heads/somebranch",
|
|
refName: "somebranch",
|
|
},
|
|
{
|
|
eventName: "create",
|
|
event: map[string]any{"ref": "feature/new", "ref_type": "branch"},
|
|
ref: "refs/heads/feature/new",
|
|
refName: "feature/new",
|
|
},
|
|
{
|
|
eventName: "create",
|
|
event: map[string]any{"ref": "v1", "ref_type": "tag"},
|
|
ref: "refs/tags/v1",
|
|
refName: "v1",
|
|
},
|
|
{
|
|
eventName: "create",
|
|
event: map[string]any{"ref": "refs/tags/v1", "ref_type": "tag"},
|
|
ref: "refs/tags/v1",
|
|
refName: "v1",
|
|
},
|
|
{
|
|
eventName: "unknown",
|
|
event: map[string]any{
|
|
"repository": map[string]any{
|
|
"default_branch": "main",
|
|
},
|
|
},
|
|
ref: "refs/heads/main",
|
|
refName: "main",
|
|
},
|
|
{
|
|
eventName: "no-event",
|
|
event: map[string]any{},
|
|
ref: "refs/heads/master",
|
|
refName: "master",
|
|
},
|
|
}
|
|
|
|
for _, table := range tables {
|
|
t.Run(table.eventName, func(t *testing.T) {
|
|
ghc := &model.GithubContext{
|
|
EventName: table.eventName,
|
|
BaseRef: "master",
|
|
Event: table.event,
|
|
}
|
|
|
|
SetRef(t.Context(), ghc, "/some/dir")
|
|
ghc.SetRefTypeAndName()
|
|
|
|
assert.Equal(t, table.ref, ghc.Ref)
|
|
assert.Equal(t, table.refName, ghc.RefName)
|
|
})
|
|
}
|
|
|
|
t.Run("no-default-branch", func(t *testing.T) {
|
|
findGitRef = func(_ctx context.Context, _file string) (string, error) {
|
|
return "", errors.New("no default branch")
|
|
}
|
|
|
|
ghc := &model.GithubContext{
|
|
EventName: "no-default-branch",
|
|
Event: map[string]any{},
|
|
}
|
|
|
|
SetRef(t.Context(), ghc, "/some/dir")
|
|
|
|
assert.Equal(t, "refs/heads/master", ghc.Ref)
|
|
})
|
|
}
|
|
|
|
func TestSetSha(t *testing.T) {
|
|
oldFindGitRef := findGitRef
|
|
oldFindGitRevision := findGitRevision
|
|
defer func() { findGitRef = oldFindGitRef }()
|
|
defer func() { findGitRevision = oldFindGitRevision }()
|
|
|
|
findGitRevision = func(_ctx context.Context, _file string) (string, error) {
|
|
return "1234fakesha", nil
|
|
}
|
|
|
|
tables := []struct {
|
|
eventName string
|
|
event map[string]any
|
|
sha string
|
|
}{
|
|
{
|
|
eventName: "pull_request_target",
|
|
event: map[string]any{
|
|
"pull_request": map[string]any{
|
|
"base": map[string]any{
|
|
"sha": "pr-base-sha",
|
|
},
|
|
},
|
|
},
|
|
sha: "pr-base-sha",
|
|
},
|
|
{
|
|
eventName: "pull_request",
|
|
event: map[string]any{
|
|
"number": 1234.,
|
|
},
|
|
sha: "1234fakesha",
|
|
},
|
|
{
|
|
eventName: "deployment",
|
|
event: map[string]any{
|
|
"deployment": map[string]any{
|
|
"sha": "deployment-sha",
|
|
},
|
|
},
|
|
sha: "deployment-sha",
|
|
},
|
|
{
|
|
eventName: "push",
|
|
event: map[string]any{
|
|
"after": "push-sha",
|
|
"deleted": false,
|
|
},
|
|
sha: "push-sha",
|
|
},
|
|
{
|
|
eventName: "unknown",
|
|
event: map[string]any{},
|
|
sha: "1234fakesha",
|
|
},
|
|
}
|
|
|
|
for _, table := range tables {
|
|
t.Run(table.eventName, func(t *testing.T) {
|
|
ghc := &model.GithubContext{
|
|
EventName: table.eventName,
|
|
Event: table.event,
|
|
}
|
|
|
|
SetSha(t.Context(), ghc, "/some/dir")
|
|
|
|
assert.Equal(t, table.sha, ghc.Sha)
|
|
})
|
|
}
|
|
|
|
t.Run("pinned checkout keeps the first sha and ref", func(t *testing.T) {
|
|
ctx := WithPinnedCheckout(t.Context())
|
|
for _, head := range []string{"first", "moved"} {
|
|
findGitRevision = func(context.Context, string) (string, error) { return head, nil }
|
|
findGitRef = func(context.Context, string) (string, error) { return "refs/heads/" + head, nil }
|
|
ghc := &model.GithubContext{Event: map[string]any{}}
|
|
SetSha(ctx, ghc, "/some/dir")
|
|
SetRef(ctx, ghc, "/some/dir")
|
|
assert.Equal(t, "first", ghc.Sha)
|
|
assert.Equal(t, "refs/heads/first", ghc.Ref)
|
|
}
|
|
})
|
|
}
|