mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-04-25 13:20:32 +08:00
Use `golangci-lint fmt` to format code, upgrading `.golangci.yml` to v2 and mirroring the linter configuration used by https://github.com/go-gitea/gitea. `gci` now handles import ordering into standard, project-local, blank, and default groups. Mirrors https://github.com/go-gitea/gitea/pull/37194. Changes: - Upgrade `.golangci.yml` to v2 format with the same linter set as gitea (minus `prealloc`, `unparam`, `testifylint`, `nilnil` which produced too many pre-existing issues) - Add path-based exclusions (`bodyclose`, `gosec` in tests; `gosec:G115`/`G117` globally) - Run lint via `make lint-go` in CI instead of `golangci/golangci-lint-action`, matching the pattern used by other Gitea repos - Apply safe auto-fixes (`modernize`, `perfsprint`, `usetesting`, etc.) - Add explanations to existing `//nolint` directives - Remove dead code (unused `newRemoteReusableWorkflow` and `networkName`), duplicate imports, and shadowed `max` builtins - Replace deprecated `docker/distribution/reference` with `distribution/reference` - Fix `Deprecated:` comment casing and simplify nil/len checks --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/act/pulls/163 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-committed-by: silverwind <me@silverwind.io>
83 lines
1.3 KiB
Go
83 lines
1.3 KiB
Go
package runner
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/nektos/act/pkg/model"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestStepFactoryNewStep(t *testing.T) {
|
|
table := []struct {
|
|
name string
|
|
model *model.Step
|
|
check func(s step) bool
|
|
}{
|
|
{
|
|
name: "StepRemoteAction",
|
|
model: &model.Step{
|
|
Uses: "remote/action@v1",
|
|
},
|
|
check: func(s step) bool {
|
|
_, ok := s.(*stepActionRemote)
|
|
return ok
|
|
},
|
|
},
|
|
{
|
|
name: "StepLocalAction",
|
|
model: &model.Step{
|
|
Uses: "./action@v1",
|
|
},
|
|
check: func(s step) bool {
|
|
_, ok := s.(*stepActionLocal)
|
|
return ok
|
|
},
|
|
},
|
|
{
|
|
name: "StepDocker",
|
|
model: &model.Step{
|
|
Uses: "docker://image:tag",
|
|
},
|
|
check: func(s step) bool {
|
|
_, ok := s.(*stepDocker)
|
|
return ok
|
|
},
|
|
},
|
|
{
|
|
name: "StepRun",
|
|
model: &model.Step{
|
|
Run: "cmd",
|
|
},
|
|
check: func(s step) bool {
|
|
_, ok := s.(*stepRun)
|
|
return ok
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tt := range table {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
sf := &stepFactoryImpl{}
|
|
|
|
step, err := sf.newStep(tt.model, &RunContext{})
|
|
|
|
assert.True(t, tt.check((step)))
|
|
assert.Nil(t, err)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStepFactoryInvalidStep(t *testing.T) {
|
|
model := &model.Step{
|
|
Uses: "remote/action@v1",
|
|
Run: "cmd",
|
|
}
|
|
|
|
sf := &stepFactoryImpl{}
|
|
|
|
_, err := sf.newStep(model, &RunContext{})
|
|
|
|
assert.Error(t, err)
|
|
}
|