From 1b02a45331706b401d0d6dedd55b91e02836124a Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Tue, 15 Oct 2019 17:20:54 -0400 Subject: [PATCH] no need to update database image --- contrib/run-unittests.sh | 5 ++--- docs/CONTRIBUTING.rst | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/contrib/run-unittests.sh b/contrib/run-unittests.sh index e5f970eb..77f200e9 100755 --- a/contrib/run-unittests.sh +++ b/contrib/run-unittests.sh @@ -11,8 +11,8 @@ # set, tests will run in mbs-test-centos with Python 2 by default. # --with-pgsql: run tests with PostgreSQL, otherwise SQLite is used. # --no-tty: don't use tty for containers -# --sudo: run docker via sudo -# --no-pull: don't update docker images +# --sudo: run Docker via sudo +# --no-pull: don't update Docker images # # Please note that, both of them can have arbitrary value as long as one of # them is set. So, generally, it works by just setting to 1 or yes for @@ -81,7 +81,6 @@ if [ -n "$with_pgsql" ]; then # Database will be generated automatically by postgres container during launch. # Setting this password makes it possible to get into database container # and check the data. - [ -n "$do_pull" ] && $docker pull "$db_container_name" db_bg_container=$( $docker run --rm --name "$db_container_name" \ -e POSTGRES_PASSWORD=$db_password \ diff --git a/docs/CONTRIBUTING.rst b/docs/CONTRIBUTING.rst index 6ae6e397..94f1b480 100644 --- a/docs/CONTRIBUTING.rst +++ b/docs/CONTRIBUTING.rst @@ -30,8 +30,8 @@ There are options to change the tests enviornment: * ``--py3``: run tests with Python 3. * ``--with-pgsql``: run tests with PostgreSQL database. * ``--no-tty``: don't use tty for containers -* ``--sudo``: run docker via sudo -* ``--no-pull``: don't update docker images +* ``--sudo``: run Docker via sudo +* ``--no-pull``: don't update Docker images For example, ``contrib/run-unittests.sh --py3 --with-pgsql``.