From 1fae917fc33dd718d89f59b2a21debecf2f1a7e4 Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Thu, 19 Dec 2019 14:43:05 -0500 Subject: [PATCH] error if repo metadata fails to load --- module_build_service/scheduler/default_modules.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/module_build_service/scheduler/default_modules.py b/module_build_service/scheduler/default_modules.py index a355f60a..d1fabac7 100644 --- a/module_build_service/scheduler/default_modules.py +++ b/module_build_service/scheduler/default_modules.py @@ -389,6 +389,13 @@ def _get_rpms_in_external_repo(repo_url, arches, cache_dir_name): log.exception(msg) raise RuntimeError(msg) + # dnf will not always raise an error on repo failures, so we check explicitly + for repo_name in base.repos: + if not base.repos[repo_name].metadata: + msg = "Failed to load metadata for repo %s" % repo_name + log.exception(msg) + raise RuntimeError(msg) + base.fill_sack(load_system_repo=False) # Return all the available RPMs