From 3313cbb007d6327f2e99fb523e6b08fd613a04f4 Mon Sep 17 00:00:00 2001 From: Filip Valder Date: Fri, 11 Nov 2016 14:53:43 +0100 Subject: [PATCH] convention: avoid confusion with __setitem__ --- module_build_service/config.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/module_build_service/config.py b/module_build_service/config.py index 3a5f86ce..99206466 100644 --- a/module_build_service/config.py +++ b/module_build_service/config.py @@ -197,7 +197,7 @@ def from_app_config(): for key, value in app.config.items(): # lower keys key = key.lower() - conf.setitem(key, value) + conf.set_item(key, value) return conf @@ -212,10 +212,10 @@ class Config(object): in self._defaults} for conf_item in self._defaults: - self.setitem(conf_item['name'], conf_item['default']) + self.set_item(conf_item['name'], conf_item['default']) - def setitem(self, key, value): - if key == 'setitem' or key.startswith('_'): + def set_item(self, key, value): + if key == 'set_item' or key.startswith('_'): raise Exception("Configuration item's name is not allowed: %s" % key) # registered defaults