From 3b938dba26cf0fb9bf4812719d7513725cd18a41 Mon Sep 17 00:00:00 2001 From: Chenxiong Qi Date: Thu, 18 Jul 2019 22:27:59 +0800 Subject: [PATCH] No need of argument component_id for ComponentBuild.state_trace Signed-off-by: Chenxiong Qi --- module_build_service/models.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/module_build_service/models.py b/module_build_service/models.py index 9d09c04e..6bc6a331 100644 --- a/module_build_service/models.py +++ b/module_build_service/models.py @@ -1199,10 +1199,9 @@ class ComponentBuild(MBSBase): def from_component_nvr(cls, db_session, nvr, module_id): return db_session.query(cls).filter_by(nvr=nvr, module_id=module_id).first() - def state_trace(self, db_session, component_id): - # FIXME: remove argument component_id, just use self.id + def state_trace(self, db_session): return ( - db_session.query(ComponentBuildTrace).filter_by(component_id=component_id) + db_session.query(ComponentBuildTrace).filter_by(component_id=self.id) .order_by(ComponentBuildTrace.state_time) .all() ) @@ -1251,7 +1250,7 @@ class ComponentBuild(MBSBase): "state_name": INVERSE_BUILD_STATES[record.state], "reason": record.state_reason, } - for record in self.state_trace(db_session, self.id) + for record in self.state_trace(db_session) ], "state_url": state_url, })