From 3ba33f4e530e69b90ecd57194f16880f78bb0b98 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Kadl=C4=8D=C3=ADk?= Date: Wed, 17 Aug 2016 13:22:45 +0200 Subject: [PATCH] Use Popen's returncode instead of getstatusoutput because the getstatusoutput is python3 only --- rida/scm.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/rida/scm.py b/rida/scm.py index 15903d89..99527fa4 100644 --- a/rida/scm.py +++ b/rida/scm.py @@ -137,9 +137,10 @@ class SCM(object): :raises: RuntimeError """ if self.scheme == "git": - (status , output) = sp.getstatusoutput("git ls-remote %s" - % self.repository) - if status != 0: + cmd = ["git", "ls-remote", self.repository] + proc = sp.Popen(cmd, stdout=sp.PIPE, stderr=sp.PIPE) + output, stderr = proc.communicate() + if proc.returncode != 0: raise RuntimeError("Cannot get git hash of master HEAD in %s" % self.repository) for line in output.split(os.linesep):