From 62e26ba652045eddee582b3481baf42b98c64e3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Kadl=C4=8D=C3=ADk?= Date: Thu, 23 Feb 2017 20:17:33 +0100 Subject: [PATCH] Use better way of checking for forbidden columns --- module_build_service/views.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/module_build_service/views.py b/module_build_service/views.py index c010295e..f5145746 100644 --- a/module_build_service/views.py +++ b/module_build_service/views.py @@ -124,7 +124,7 @@ class ModuleBuildAPI(MethodView): log.error("The submitted scmurl %r is not valid" % url) raise Unauthorized("The submitted scmurl %s is not valid" % url) - forbidden_params = [k for k in r if not hasattr(models.ModuleBuild, k)] + forbidden_params = [k for k in r if k not in models.ModuleBuild.__table__.columns] if forbidden_params: raise ValidationError('The request contains unspecified parameters: {}'.format(", ".join(forbidden_params))) @@ -135,7 +135,7 @@ class ModuleBuildAPI(MethodView): if not conf.yaml_submit_allowed: raise Unauthorized("YAML submission is not enabled") - forbidden_params = [k for k in request.form if not hasattr(models.ModuleBuild, k)] + forbidden_params = [k for k in request.form if k not in models.ModuleBuild.__table__.columns] if forbidden_params: raise ValidationError('The request contains unspecified parameters: {}'.format(", ".join(forbidden_params)))