From 80c7e20bfa75331b7c56b4136cb742d53f01bb41 Mon Sep 17 00:00:00 2001 From: "Owen W. Taylor" Date: Sun, 22 Nov 2020 16:14:48 -0500 Subject: [PATCH] resolver: remove unused state/states parameter to get_module() BaseResolver.get_module() and DBResolver.get_module() to a state parameter, MBSResolver took a states parameter - neither was used anywhere. --- module_build_service/resolver/DBResolver.py | 5 ++--- module_build_service/resolver/MBSResolver.py | 4 ++-- module_build_service/resolver/base.py | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/module_build_service/resolver/DBResolver.py b/module_build_service/resolver/DBResolver.py index 0be8d156..5cb8fa2c 100644 --- a/module_build_service/resolver/DBResolver.py +++ b/module_build_service/resolver/DBResolver.py @@ -23,11 +23,10 @@ class DBResolver(GenericResolver): self.config = config def get_module( - self, name, stream, version, context, - state=models.BUILD_STATES["ready"], strict=False + self, name, stream, version, context, strict=False ): mb = models.ModuleBuild.get_build_from_nsvc( - self.db_session, name, stream, version, context, state=state) + self.db_session, name, stream, version, context, state=models.BUILD_STATES["ready"]) if mb: return mb.extended_json(self.db_session) diff --git a/module_build_service/resolver/MBSResolver.py b/module_build_service/resolver/MBSResolver.py index 639ec22e..e28e125a 100644 --- a/module_build_service/resolver/MBSResolver.py +++ b/module_build_service/resolver/MBSResolver.py @@ -96,8 +96,8 @@ class MBSResolver(KojiResolver): else: return modules - def get_module(self, name, stream, version, context, states=None, strict=False): - rv = self._get_modules(name, stream, version, context, states, strict) + def get_module(self, name, stream, version, context, strict=False): + rv = self._get_modules(name, stream, version, context, strict=strict) if rv: return rv[0] diff --git a/module_build_service/resolver/base.py b/module_build_service/resolver/base.py index 776ff78d..8a5036fe 100644 --- a/module_build_service/resolver/base.py +++ b/module_build_service/resolver/base.py @@ -78,7 +78,7 @@ class GenericResolver(six.with_metaclass(ABCMeta)): return False @abstractmethod - def get_module(self, name, stream, version, context, state="ready", strict=False): + def get_module(self, name, stream, version, context, strict=False): raise NotImplementedError() @abstractmethod