From 9204941d823ba4f3d36dfd8b323d74259ec992b7 Mon Sep 17 00:00:00 2001 From: Luiz Carvalho Date: Fri, 22 Nov 2019 10:17:24 -0500 Subject: [PATCH] Increase get_module_build_arches test coverage Signed-off-by: Luiz Carvalho --- tests/test_builder/test_koji.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/tests/test_builder/test_koji.py b/tests/test_builder/test_koji.py index 0f990ef2..bcbd344f 100644 --- a/tests/test_builder/test_koji.py +++ b/tests/test_builder/test_koji.py @@ -934,6 +934,25 @@ class TestKojiBuilder: ret = KojiModuleBuilder.get_module_build_arches(module_build) assert " ".join(ret) == arches + @patch.dict("sys.modules", krbV=MagicMock()) + @patch("module_build_service.builder.KojiModuleBuilder.KojiClientSession") + def test_get_module_build_arches_with_archless_tag(self, ClientSession): + module_build = module_build_service.models.ModuleBuild.get_by_id(db_session, 2) + session = ClientSession.return_value + session.getTag.return_value = {"arches": ""} + ret = KojiModuleBuilder.get_module_build_arches(module_build) + assert ret == [] + + @patch.dict("sys.modules", krbV=MagicMock()) + @patch("module_build_service.builder.KojiModuleBuilder.KojiClientSession") + def test_get_module_build_arches_with_unknown_tag(self, ClientSession): + module_build = module_build_service.models.ModuleBuild.get_by_id(db_session, 2) + session = ClientSession.return_value + session.getTag.return_value = None + with pytest.raises(ValueError) as exc_info: + KojiModuleBuilder.get_module_build_arches(module_build) + assert "Unknown Koji tag" in str(exc_info.value) + class TestGetDistTagSRPM: """Test KojiModuleBuilder.get_disttag_srpm"""