Add greenwave query to done handler

Signed-off-by: Valerij Maljulin <vmaljuli@redhat.com>
This commit is contained in:
Valerij Maljulin
2019-05-09 18:42:25 +02:00
parent 4b5618f079
commit 95bacc4e15
4 changed files with 258 additions and 43 deletions

View File

@@ -406,9 +406,12 @@ class TestBuild:
pass
@pytest.mark.parametrize("mmd_version", [1, 2])
@patch("module_build_service.utils.greenwave.Greenwave.check_gating", return_value=True)
@patch("module_build_service.auth.get_user", return_value=user)
@patch("module_build_service.scm.SCM")
def test_submit_build(self, mocked_scm, mocked_get_user, conf_system, dbg, hmsc, mmd_version):
def test_submit_build(
self, mocked_scm, mocked_get_user, mocked_greenwave, conf_system, dbg, hmsc, mmd_version
):
"""
Tests the build of testmodule.yaml using FakeModuleBuilder which
succeeds everytime.
@@ -481,12 +484,17 @@ class TestBuild:
assert module_build.module_builds_trace[4].state == models.BUILD_STATES["ready"]
assert len(module_build.module_builds_trace) == 5
@pytest.mark.parametrize("gating_result", (True, False))
@patch("module_build_service.utils.greenwave.Greenwave.check_gating")
@patch("module_build_service.auth.get_user", return_value=user)
@patch("module_build_service.scm.SCM")
def test_submit_build_no_components(self, mocked_scm, mocked_get_user, conf_system, dbg, hmsc):
def test_submit_build_no_components(
self, mocked_scm, mocked_get_user, mocked_greenwave, conf_system, dbg, hmsc, gating_result
):
"""
Tests the build of a module with no components
"""
mocked_greenwave.return_value = gating_result
FakeSCM(
mocked_scm,
"python3",
@@ -512,7 +520,10 @@ class TestBuild:
# Make sure no component builds were registered
assert len(module_build.component_builds) == 0
# Make sure the build is done
assert module_build.state == models.BUILD_STATES["ready"]
if gating_result:
assert module_build.state == models.BUILD_STATES["ready"]
else:
assert module_build.state == models.BUILD_STATES["done"]
@patch(
"module_build_service.config.Config.check_for_eol",
@@ -1412,10 +1423,11 @@ class TestBuild:
models.BUILD_STATES["ready"],
]
@patch("module_build_service.utils.greenwave.Greenwave.check_gating", return_value=True)
@patch("module_build_service.auth.get_user", return_value=user)
@patch("module_build_service.scm.SCM")
def test_submit_build_resume_init_fail(
self, mocked_scm, mocked_get_user, conf_system, dbg, hmsc
self, mocked_scm, mocked_get_user, mock_greenwave, conf_system, dbg, hmsc
):
"""
Tests that resuming the build fails when the build is in init state
@@ -1654,10 +1666,11 @@ class TestBuild:
module = db.session.query(models.ModuleBuild).get(module_build_id)
assert module.state == models.BUILD_STATES["build"]
@patch("module_build_service.utils.greenwave.Greenwave.check_gating", return_value=True)
@patch("module_build_service.auth.get_user", return_value=user)
@patch("module_build_service.scm.SCM")
def test_submit_br_metadata_only_module(
self, mocked_scm, mocked_get_user, conf_system, dbg, hmsc
self, mocked_scm, mocked_get_user, mock_greenwave, conf_system, dbg, hmsc
):
"""
Test that when a build is submitted with a buildrequire without a Koji tag,

View File

@@ -23,13 +23,14 @@
import json
from mock import patch, Mock
import module_build_service.utils.greenwave
import pytest
from module_build_service.utils.greenwave import greenwave
from tests import make_module
class TestGreenwaveQuery():
@patch("module_build_service.utils.greenwave.requests")
def test_greenwave_decision(self, mock_requests):
def test_greenwave_query_decision(self, mock_requests):
resp_status = 200
resp_content = {
"applicable_policies": ["osci_compose_modules"],
@@ -56,8 +57,7 @@ class TestGreenwaveQuery():
fake_build = make_module("pkg:0.1:1:c1", requires_list={"platform": "el8"})
gw = module_build_service.utils.greenwave.Greenwave()
got_response = gw.query_decision(fake_build, prod_version="xxxx-8")
got_response = greenwave.query_decision(fake_build, prod_version="xxxx-8")
assert got_response == resp_content
assert json.loads(mock_requests.post.call_args_list[0][1]["data"]) == {
@@ -68,3 +68,112 @@ class TestGreenwaveQuery():
"Content-Type": "application/json"}
assert mock_requests.post.call_args_list[0][1]["url"] == \
"https://greenwave.example.local/api/v1.0/decision"
@pytest.mark.parametrize("return_all", (False, True))
@patch("module_build_service.utils.greenwave.requests")
def test_greenwave_query_policies(self, mock_requests, return_all):
resp_status = 200
resp_content = {
"policies": [
{
"decision_context": "test_dec_context",
"product_versions": ["ver1", "ver3"],
"rules": [],
"subject_type": "some-module"
},
{
"decision_context": "test_dec_context",
"product_versions": ["ver1", "ver2"],
"rules": [],
"subject_type": "some-module"
},
{
"decision_context": "decision_context_2",
"product_versions": ["ver4"],
"rules": [],
"subject_type": "subject_type_2"
}
]
}
selected_policies = {"policies": resp_content["policies"][:-1]}
response = Mock()
response.json.return_value = resp_content
response.status_code = resp_status
mock_requests.get.return_value = response
got_response = greenwave.query_policies(return_all)
if return_all:
assert got_response == resp_content
else:
assert got_response == selected_policies
assert mock_requests.get.call_args_list[0][1]["url"] == \
"https://greenwave.example.local/api/v1.0/policies"
@patch("module_build_service.utils.greenwave.requests")
def test_greenwave_get_product_versions(self, mock_requests):
resp_status = 200
resp_content = {
"policies": [
{
"decision_context": "test_dec_context",
"product_versions": ["ver1", "ver3"],
"rules": [],
"subject_type": "some-module"
},
{
"decision_context": "test_dec_context",
"product_versions": ["ver1", "ver2"],
"rules": [],
"subject_type": "some-module"
},
{
"decision_context": "decision_context_2",
"product_versions": ["ver4"],
"rules": [],
"subject_type": "subject_type_2"
}
]
}
expected_versions = {"ver1", "ver2", "ver3"}
response = Mock()
response.json.return_value = resp_content
response.status_code = resp_status
mock_requests.get.return_value = response
versions_set = greenwave.get_product_versions()
assert versions_set == expected_versions
assert mock_requests.get.call_args_list[0][1]["url"] == \
"https://greenwave.example.local/api/v1.0/policies"
@pytest.mark.parametrize("policies_satisfied", (True, False))
@patch("module_build_service.utils.greenwave.requests")
def test_greenwave_check_gating(self, mock_requests, policies_satisfied):
resp_status = 200
policies_content = {
"policies": [
{
"decision_context": "test_dec_context",
"product_versions": ["ver1", "ver3"],
"rules": [],
"subject_type": "some-module"
}
]
}
responses = [Mock() for i in range(3)]
for r in responses:
r.status_code = resp_status
responses[0].json.return_value = policies_content
responses[1].json.return_value = {"policies_satisfied": False}
responses[2].json.return_value = {"policies_satisfied": policies_satisfied}
mock_requests.get.return_value = responses[0]
mock_requests.post.side_effect = responses[1:]
fake_build = make_module("pkg:0.1:1:c1", requires_list={"platform": "el8"})
result = greenwave.check_gating(fake_build)
assert result == policies_satisfied