From bf80ce4537e825a1046b9acc8e7592a1d2567ec8 Mon Sep 17 00:00:00 2001 From: mprahl Date: Mon, 22 Jan 2018 15:20:41 -0500 Subject: [PATCH] Don't traceback on failed task cancellations and log those exceptions --- module_build_service/builder/KojiModuleBuilder.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/module_build_service/builder/KojiModuleBuilder.py b/module_build_service/builder/KojiModuleBuilder.py index 457cd5ab..ab1ef12b 100644 --- a/module_build_service/builder/KojiModuleBuilder.py +++ b/module_build_service/builder/KojiModuleBuilder.py @@ -671,7 +671,11 @@ chmod 644 %buildroot/%_sysconfdir/rpm/macros.zz-modules return task_id, state, reason, None def cancel_build(self, task_id): - self.koji_session.cancelTask(task_id) + try: + self.koji_session.cancelTask(task_id) + except Exception as error: + log.error('Failed to cancel task ID {0} in Koji. The error ' + 'message was: {1}'.format(task_id, str(error))) @classmethod def repo_from_tag(cls, config, tag_name, arch):