From c54c3a288bf76c28643ff4aa213e286c8664e052 Mon Sep 17 00:00:00 2001 From: Chenxiong Qi Date: Wed, 11 Sep 2019 09:52:24 +0800 Subject: [PATCH] Do not ignore building components to reset state when submit an existing module build koji.BUILD_STATE["BUILDING"] equals to 0. So, checking if component.state is None explicitly to avoid ignoring the components which are in building state. Signed-off-by: Chenxiong Qi --- module_build_service/utils/submit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module_build_service/utils/submit.py b/module_build_service/utils/submit.py index 45fd4f6b..9ed05cf8 100644 --- a/module_build_service/utils/submit.py +++ b/module_build_service/utils/submit.py @@ -975,7 +975,7 @@ def submit_module_build(db_session, username, mmd, params): log.debug("Resuming existing module build %r" % module) # Reset all component builds that didn't complete for component in module.component_builds: - if component.state and component.state != koji.BUILD_STATES["COMPLETE"]: + if component.state is not None and component.state != koji.BUILD_STATES["COMPLETE"]: component.state = None component.state_reason = None db_session.add(component)