From cbb75d34e6bc475969fd70bc9be01f38e1b9bf02 Mon Sep 17 00:00:00 2001 From: Ralph Bean Date: Thu, 3 Aug 2017 14:27:26 -0400 Subject: [PATCH] Also, only remove the dir if we succeed in passing the buck to koji. --- module_build_service/builder/KojiContentGenerator.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/module_build_service/builder/KojiContentGenerator.py b/module_build_service/builder/KojiContentGenerator.py index 6fe61537..079c766b 100644 --- a/module_build_service/builder/KojiContentGenerator.py +++ b/module_build_service/builder/KojiContentGenerator.py @@ -344,8 +344,11 @@ class KojiContentGenerator(object): build_info = session.CGImport(metadata, file_dir) log.info("Content generator import done.") log.debug(json.dumps(build_info, sort_keys=True, indent=4)) + + # Only remove the logs if CG import was successful. If it fails, + # then we want to keep them around for debugging. + log.info("Removing %r" % file_dir) + shutil.rmtree(file_dir) except Exception as e: log.exception("Content generator import failed: %s", e) raise e - finally: - shutil.rmtree(file_dir)