mirror of
https://pagure.io/fm-orchestrator.git
synced 2026-04-27 04:02:23 +08:00
GenericBuilder: Add a boolean 'succeeded' parameter to finalize
Previously MockModuleBuilder was checking the module state to see if
it should run a final createrepo, but since eafa93037f, finalize() is
called before changing the module state; add an explicit boolean to
GenericBuilder.finalize() to avoid worrying about ordering.
This commit is contained in:
@@ -262,12 +262,13 @@ class GenericBuilder(six.with_metaclass(ABCMeta)):
|
||||
raise NotImplementedError()
|
||||
|
||||
@abstractmethod
|
||||
def finalize(self):
|
||||
def finalize(self, succeeded=True):
|
||||
"""
|
||||
:param succeeded: True if all module builds were successful
|
||||
:return: None
|
||||
|
||||
This method is supposed to be called after all module builds are
|
||||
successfully finished.
|
||||
finished.
|
||||
|
||||
It could be utilized for various purposes such as cleaning or
|
||||
running additional build-system based operations on top of
|
||||
|
||||
Reference in New Issue
Block a user