From dbced8668b927a41d3ab9260aa7ee7287c555b17 Mon Sep 17 00:00:00 2001 From: Chenxiong Qi Date: Thu, 15 Aug 2019 17:46:59 +0800 Subject: [PATCH] Do not compare with a empty list An empty list [] is evaluated as a false value. So, it is not necessary to compare like "if some_var == []:". Signed-off-by: Chenxiong Qi --- module_build_service/utils/mse.py | 8 ++++---- module_build_service/utils/submit.py | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/module_build_service/utils/mse.py b/module_build_service/utils/mse.py index fc663f84..b312b39f 100644 --- a/module_build_service/utils/mse.py +++ b/module_build_service/utils/mse.py @@ -105,7 +105,7 @@ def expand_mse_streams(db_session, mmd, default_streams=None, raise_if_stream_am new_streams = _expand_mse_streams( db_session, name, streams, default_streams, raise_if_stream_ambigous) - if new_streams == []: + if not new_streams: new_deps.set_empty_runtime_dependencies_for_module(name) else: for stream in new_streams: @@ -116,7 +116,7 @@ def expand_mse_streams(db_session, mmd, default_streams=None, raise_if_stream_am new_streams = _expand_mse_streams( db_session, name, streams, default_streams, raise_if_stream_ambigous) - if new_streams == []: + if not new_streams: new_deps.set_empty_buildtime_dependencies_for_module(name) else: for stream in new_streams: @@ -471,7 +471,7 @@ def generate_expanded_mmds(db_session, mmd, raise_if_stream_ambigous=False, defa if req_name not in deps_buildrequires: # This require is not a buildrequire so just copy this runtime requirement to # new_dep and don't touch buildrequires - if req_streams == []: + if not req_streams: new_deps.set_empty_runtime_dependencies_for_module(req_name) else: for req_stream in req_streams: @@ -479,7 +479,7 @@ def generate_expanded_mmds(db_session, mmd, raise_if_stream_ambigous=False, defa elif set(req_streams) != set(deps_buildrequires[req_name]): # Streams in runtime section are not the same as in buildtime section, # so just copy this runtime requirement to new_dep. - if req_streams == []: + if not req_streams: new_deps.set_empty_runtime_dependencies_for_module(req_name) else: for req_stream in req_streams: diff --git a/module_build_service/utils/submit.py b/module_build_service/utils/submit.py index 614e9531..1ce04fc5 100644 --- a/module_build_service/utils/submit.py +++ b/module_build_service/utils/submit.py @@ -662,7 +662,7 @@ def _apply_dep_overrides(mmd, params): else: streams_to_add = reqs[name] - if streams_to_add == []: + if not streams_to_add: add_empty_func(name) else: for stream in streams_to_add: @@ -705,7 +705,7 @@ def _modify_buildtime_streams(db_session, mmd, new_streams_func): if streams != new_streams: overridden = True - if new_streams == []: + if not new_streams: new_dep.set_empty_buildtime_dependencies_for_module(name) else: for stream in new_streams: @@ -715,7 +715,7 @@ def _modify_buildtime_streams(db_session, mmd, new_streams_func): # Copy the runtime streams as is reqs = deps_to_dict(dep, "runtime") for name, streams in reqs.items(): - if streams == []: + if not streams: new_dep.set_empty_runtime_dependencies_for_module(name) else: for stream in streams: