From e1342d8ffca12c36e979242a4564a51fc0869bf3 Mon Sep 17 00:00:00 2001 From: Chenxiong Qi Date: Thu, 15 Aug 2019 21:28:24 +0800 Subject: [PATCH] Use dict literal to create dict Some code create a dict in this way: some_var = {} some_var["a"] = 100 some_var["b"] = 200 Using dict literal could make these lines a little bit simpler. Signed-off-by: Chenxiong Qi --- .../builder/KojiModuleBuilder.py | 16 +++++++-------- module_build_service/logger.py | 20 ++++++++++--------- module_build_service/manage.py | 10 ++++------ 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/module_build_service/builder/KojiModuleBuilder.py b/module_build_service/builder/KojiModuleBuilder.py index 5f38e15b..ca9f5c2a 100644 --- a/module_build_service/builder/KojiModuleBuilder.py +++ b/module_build_service/builder/KojiModuleBuilder.py @@ -931,14 +931,14 @@ class KojiModuleBuilder(GenericBuilder): if record_exists(parent["id"], inheritance_data): continue - parent_data = {} - parent_data["parent_id"] = parent["id"] - parent_data["priority"] = priority - parent_data["maxdepth"] = None - parent_data["intransitive"] = False - parent_data["noconfig"] = False - parent_data["pkg_filter"] = "" - inheritance_data.append(parent_data) + inheritance_data.append({ + "parent_id": parent["id"], + "priority": priority, + "maxdepth": None, + "intransitive": False, + "noconfig": False, + "pkg_filter": "", + }) priority += 10 if inheritance_data: diff --git a/module_build_service/logger.py b/module_build_service/logger.py index 42898cc7..a2d8ed99 100644 --- a/module_build_service/logger.py +++ b/module_build_service/logger.py @@ -46,16 +46,18 @@ import os import logging import inspect -levels = {} -levels["debug"] = logging.DEBUG -levels["error"] = logging.ERROR -levels["warning"] = logging.WARNING -levels["info"] = logging.INFO +levels = { + "debug": logging.DEBUG, + "error": logging.ERROR, + "warning": logging.WARNING, + "info": logging.INFO, +} -level_flags = {} -level_flags["debug"] = levels["debug"] -level_flags["verbose"] = levels["info"] -level_flags["quiet"] = levels["error"] +level_flags = { + "debug": levels["debug"], + "verbose": levels["info"], + "quiet": levels["error"], +} log_format = "%(asctime)s - %(threadName)s - %(name)s - %(levelname)s - %(message)s" diff --git a/module_build_service/manage.py b/module_build_service/manage.py index d936659f..1594cada 100755 --- a/module_build_service/manage.py +++ b/module_build_service/manage.py @@ -157,12 +157,10 @@ def build_module_locally( db.create_all() - params = {} - params["local_build"] = True - params["default_streams"] = {} - for ns in default_streams: - n, s = ns.split(":") - params["default_streams"][n] = s + params = { + "local_build": True, + "default_streams": dict(ns.split(":") for ns in default_streams) + } if srpms: params["srpms"] = srpms