From ec28f9aa00a3c6c2f71fdde8296d1f709a6dbefa Mon Sep 17 00:00:00 2001 From: Chenxiong Qi Date: Mon, 22 Oct 2018 16:51:01 +0800 Subject: [PATCH] Remove unused parameter scm from submit_module_build submit_module_build creates new module build and set parameter url to ModuleBuild.scmurl. It looks scm.url could be passed to scmurl as well, but scm is not used through out whole method. url is enough for the purpose, hence scm is removed. Signed-off-by: Chenxiong Qi --- module_build_service/utils/submit.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/module_build_service/utils/submit.py b/module_build_service/utils/submit.py index 3b877ffc..bd9974c4 100644 --- a/module_build_service/utils/submit.py +++ b/module_build_service/utils/submit.py @@ -388,7 +388,7 @@ def submit_module_build_from_yaml(username, handle, stream=None, skiptests=False buildopts = mmd.get_rpm_buildopts() buildopts["macros"] = buildopts.get("macros", "") + "\n\n%__spec_check_pre exit 0\n" mmd.set_rpm_buildopts(buildopts) - return submit_module_build(username, None, mmd, None, optional_params) + return submit_module_build(username, None, mmd, optional_params) _url_check_re = re.compile(r"^[^:/]+:.*$") @@ -404,17 +404,16 @@ def submit_module_build_from_scm(username, url, branch, allow_local_url=False, url = "file://" + url mmd, scm = _fetch_mmd(url, branch, allow_local_url) - return submit_module_build(username, url, mmd, scm, optional_params) + return submit_module_build(username, url, mmd, optional_params) -def submit_module_build(username, url, mmd, scm, optional_params=None): +def submit_module_build(username, url, mmd, optional_params=None): """ Submits new module build. :param str username: Username of the build's owner. :param str url: SCM URL of submitted build. :param Modulemd.Module mmd: Modulemd defining the build. - :param scm.SCM scm: SCM class representing the cloned git repo. :param dict optional_params: Dict with optional params for a build: - "local_build" (bool): The module is being built locally (the MBS is not running in infra, but on local developer's machine).