Files
fm-orchestrator/tests/test_builder/test_koji.py
mprahl d54422adeb Don't filter RPMs of reused components from a module that depends on itself
If a module has filters set and it buildrequires itself, issues occur
during component reuse. In that event, the filtered RPMs from the
previous module build will not be available in the buildroot because the NVRs
in the filters will match the RPMs from the reused component.

Co-authored-by: Jan Kaluza <jkaluza@redhat.com>
2018-08-13 11:13:40 -04:00

609 lines
26 KiB
Python

# Copyright (c) 2016 Red Hat, Inc.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in all
# copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
#
# Written by Jan Kaluza <jkaluza@redhat.com>
import mock
import koji
try:
import xmlrpclib
except ImportError:
import xmlrpc.client as xmlrpclib
from collections import OrderedDict
import module_build_service.messaging
import module_build_service.scheduler.handlers.repos
import module_build_service.models
import module_build_service.builder
from module_build_service import glib
import pytest
from mock import patch, MagicMock
from tests import conf, init_data, reuse_component_init_data
from module_build_service.builder.KojiModuleBuilder import KojiModuleBuilder
class FakeKojiModuleBuilder(KojiModuleBuilder):
@module_build_service.utils.retry(wait_on=(xmlrpclib.ProtocolError, koji.GenericError))
def get_session(self, config, owner):
koji_session = MagicMock()
koji_session.getRepo.return_value = {'create_event': 'fake event'}
FakeKojiModuleBuilder.tags = {
"module-foo": {
"name": "module-foo", "id": 1, "arches": "x86_64", "locked": False,
"perm": "admin"},
"module-foo-build": {
"name": "module-foo-build", "id": 2, "arches": "x86_64", "locked": False,
"perm": "admin"}
}
def _get_tag(name):
return FakeKojiModuleBuilder.tags.get(name, {})
koji_session.getTag = _get_tag
def _createTag(name):
FakeKojiModuleBuilder.tags[name] = {
"name": name, "id": len(FakeKojiModuleBuilder.tags) + 1, "arches": "x86_64",
"locked": False, "perm": "admin"}
koji_session.createTag = _createTag
def _getBuildTarget(name):
return {
"build_tag_name": self.module_build_tag['name'],
"dest_tag_name": self.module_tag['name']
}
koji_session.getBuildTarget = _getBuildTarget
def _getAllPerms(*args, **kwargs):
return [{"id": 1, "name": "admin"}]
koji_session.getAllPerms = _getAllPerms
return koji_session
class TestKojiBuilder:
def setup_method(self, test_method):
init_data(1)
self.config = mock.Mock()
self.config.koji_profile = conf.koji_profile
self.config.koji_repository_url = conf.koji_repository_url
self.module = module_build_service.models.ModuleBuild.query.filter_by(id=2).one()
def test_tag_to_repo(self):
""" Test that when a repo msg hits us and we have no match,
that we do nothing gracefully.
"""
repo = module_build_service.builder.GenericBuilder.tag_to_repo(
"koji", self.config,
"module-base-runtime-0.25-9",
"x86_64")
assert repo == ("https://kojipkgs.stg.fedoraproject.org/repos"
"/module-base-runtime-0.25-9/latest/x86_64")
def test_recover_orphaned_artifact_when_tagged(self):
""" Test recover_orphaned_artifact when the artifact is found and tagged in both tags
"""
builder = FakeKojiModuleBuilder(owner=self.module.owner,
module=self.module,
config=conf,
tag_name='module-foo',
components=[])
builder.module_tag = {"name": "module-foo", "id": 1}
builder.module_build_tag = {"name": "module-foo-build", "id": 2}
# Set listTagged to return test data
build_tagged = [{"nvr": "foo-1.0-1.module+e0095747", "task_id": 12345, 'build_id': 91}]
dest_tagged = [{"nvr": "foo-1.0-1.module+e0095747", "task_id": 12345, 'build_id': 91}]
builder.koji_session.listTagged.side_effect = [build_tagged, dest_tagged]
module_build = module_build_service.models.ModuleBuild.query.get(4)
component_build = module_build.component_builds[0]
component_build.task_id = None
component_build.state = None
component_build.nvr = None
actual = builder.recover_orphaned_artifact(component_build)
assert len(actual) == 3
assert type(actual[0]) == module_build_service.messaging.KojiBuildChange
assert actual[0].build_id == 91
assert actual[0].task_id == 12345
assert actual[0].build_new_state == koji.BUILD_STATES['COMPLETE']
assert actual[0].build_name == 'rubygem-rails'
assert actual[0].build_version == '1.0'
assert actual[0].build_release == '1.module+e0095747'
assert actual[0].module_build_id == 4
assert type(actual[1]) == module_build_service.messaging.KojiTagChange
assert actual[1].tag == 'module-foo-build'
assert actual[1].artifact == 'rubygem-rails'
assert type(actual[2]) == module_build_service.messaging.KojiTagChange
assert actual[2].tag == 'module-foo'
assert actual[2].artifact == 'rubygem-rails'
assert component_build.state == koji.BUILD_STATES['COMPLETE']
assert component_build.task_id == 12345
assert component_build.state_reason == 'Found existing build'
assert builder.koji_session.tagBuild.call_count == 0
def test_recover_orphaned_artifact_when_untagged(self):
""" Tests recover_orphaned_artifact when the build is found but untagged
"""
builder = FakeKojiModuleBuilder(owner=self.module.owner,
module=self.module,
config=conf,
tag_name='module-foo',
components=[])
builder.module_tag = {"name": "module-foo", "id": 1}
builder.module_build_tag = {"name": "module-foo-build", "id": 2}
dist_tag = 'module+2+b8661ee4'
# Set listTagged to return test data
builder.koji_session.listTagged.side_effect = [[], [], []]
untagged = [{
"id": 9000,
"name": "foo",
"version": "1.0",
"release": "1.{0}".format(dist_tag),
}]
builder.koji_session.untaggedBuilds.return_value = untagged
build_info = {
'nvr': 'foo-1.0-1.{0}'.format(dist_tag),
'task_id': 12345,
'build_id': 91
}
builder.koji_session.getBuild.return_value = build_info
module_build = module_build_service.models.ModuleBuild.query.get(4)
component_build = module_build.component_builds[0]
component_build.task_id = None
component_build.nvr = None
component_build.state = None
actual = builder.recover_orphaned_artifact(component_build)
assert len(actual) == 1
assert type(actual[0]) == module_build_service.messaging.KojiBuildChange
assert actual[0].build_id == 91
assert actual[0].task_id == 12345
assert actual[0].build_new_state == koji.BUILD_STATES['COMPLETE']
assert actual[0].build_name == 'rubygem-rails'
assert actual[0].build_version == '1.0'
assert actual[0].build_release == '1.{0}'.format(dist_tag)
assert actual[0].module_build_id == 4
assert component_build.state == koji.BUILD_STATES['COMPLETE']
assert component_build.task_id == 12345
assert component_build.state_reason == 'Found existing build'
builder.koji_session.tagBuild.assert_called_once_with(2, 'foo-1.0-1.{0}'.format(dist_tag))
def test_recover_orphaned_artifact_when_nothing_exists(self):
""" Test recover_orphaned_artifact when the build is not found
"""
builder = FakeKojiModuleBuilder(owner=self.module.owner,
module=self.module,
config=conf,
tag_name='module-foo',
components=[])
builder.module_tag = {"name": "module-foo", "id": 1}
builder.module_build_tag = {"name": "module-foo-build", "id": 2}
# Set listTagged to return nothing...
tagged = []
builder.koji_session.listTagged.return_value = tagged
untagged = [{
"nvr": "foo-1.0-1.nope",
"release": "nope",
}]
builder.koji_session.untaggedBuilds.return_value = untagged
module_build = module_build_service.models.ModuleBuild.query.get(4)
component_build = module_build.component_builds[0]
component_build.task_id = None
component_build.nvr = None
component_build.state = None
actual = builder.recover_orphaned_artifact(component_build)
assert actual == []
# Make sure nothing erroneous gets tag
assert builder.koji_session.tagBuild.call_count == 0
@patch('koji.util')
def test_buildroot_ready(self, mocked_kojiutil):
attrs = {'checkForBuilds.return_value': None,
'checkForBuilds.side_effect': IOError}
mocked_kojiutil.configure_mock(**attrs)
fake_kmb = FakeKojiModuleBuilder(owner=self.module.owner,
module=self.module,
config=conf,
tag_name='module-nginx-1.2',
components=[])
fake_kmb.module_target = {'build_tag': 'module-fake_tag'}
with pytest.raises(IOError):
fake_kmb.buildroot_ready()
assert mocked_kojiutil.checkForBuilds.call_count == 3
@pytest.mark.parametrize('blocklist', [False, True])
def test_tagging_already_tagged_artifacts(self, blocklist):
"""
Tests that buildroot_add_artifacts and tag_artifacts do not try to
tag already tagged artifacts
"""
if blocklist:
mmd = self.module.mmd()
xmd = glib.from_variant_dict(mmd.get_xmd())
xmd["mbs_options"] = {"blocked_packages": ["foo", "bar", "new"]}
mmd.set_xmd(glib.dict_values(xmd))
self.module.modulemd = mmd.dumps()
builder = FakeKojiModuleBuilder(owner=self.module.owner,
module=self.module,
config=conf,
tag_name='module-nginx-1.2',
components=[])
builder.module_tag = {"name": "module-foo", "id": 1}
builder.module_build_tag = {"name": "module-foo-build", "id": 2}
# Set listTagged to return test data
tagged = [{"nvr": "foo-1.0-1.module_e0095747"},
{"nvr": "bar-1.0-1.module_e0095747"}]
builder.koji_session.listTagged.return_value = tagged
# Try to tag one artifact which is already tagged and one new ...
to_tag = ["foo-1.0-1.module_e0095747", "new-1.0-1.module_e0095747"]
builder.buildroot_add_artifacts(to_tag)
if blocklist:
# "foo" and "new" packages should be unblocked before tagging.
expected_calls = [mock.call('module-foo-build', 'foo'),
mock.call('module-foo-build', 'new')]
else:
expected_calls = []
assert builder.koji_session.packageListUnblock.mock_calls == expected_calls
# ... only new one should be added.
builder.koji_session.tagBuild.assert_called_once_with(
builder.module_build_tag["id"], "new-1.0-1.module_e0095747")
# Try the same for tag_artifacts(...).
builder.koji_session.tagBuild.reset_mock()
builder.tag_artifacts(to_tag)
builder.koji_session.tagBuild.assert_called_once_with(
builder.module_tag["id"], "new-1.0-1.module_e0095747")
@patch.object(FakeKojiModuleBuilder, 'get_session')
@patch.object(FakeKojiModuleBuilder, '_get_tagged_nvrs')
def test_untagged_artifacts(self, mock_get_tagged_nvrs, mock_get_session):
"""
Tests that only tagged artifacts will be untagged
"""
mock_session = mock.Mock()
mock_session.getTag.side_effect = [
{'name': 'foobar', 'id': 1}, {'name': 'foobar-build', 'id': 2}]
mock_get_session.return_value = mock_session
mock_get_tagged_nvrs.side_effect = [['foo', 'bar'], ['foo']]
builder = FakeKojiModuleBuilder(
owner=self.module.owner, module=self.module, config=conf, tag_name='module-foo',
components=[])
builder.untag_artifacts(['foo', 'bar'])
assert mock_session.untagBuild.call_count == 3
expected_calls = [mock.call(1, 'foo'), mock.call(2, 'foo'), mock.call(1, 'bar')]
assert mock_session.untagBuild.mock_calls == expected_calls
@patch('module_build_service.builder.KojiModuleBuilder.KojiModuleBuilder.get_session')
def test_get_build_weights(self, get_session):
session = MagicMock()
session.getLoggedInUser.return_value = {"id": 123}
session.multiCall.side_effect = [
# getPackageID response
[[1], [2]],
# listBuilds response
[[[{"task_id": 456}]], [[{"task_id": 789}]]],
# getTaskDescendents response
[[{'1': [], '2': [], '3': [{'weight': 1.0}, {'weight': 1.0}]}],
[{'1': [], '2': [], '3': [{'weight': 1.0}, {'weight': 1.0}]}]]
]
get_session.return_value = session
weights = KojiModuleBuilder.get_build_weights(["httpd", "apr"])
assert weights == {"httpd": 2, "apr": 2}
expected_calls = [mock.call(456), mock.call(789)]
assert session.getTaskDescendents.mock_calls == expected_calls
@patch('module_build_service.builder.KojiModuleBuilder.KojiModuleBuilder.get_session')
def test_get_build_weights_no_task_id(self, get_session):
session = MagicMock()
session.getLoggedInUser.return_value = {"id": 123}
session.multiCall.side_effect = [
# getPackageID response
[[1], [2]],
# listBuilds response
[[[{"task_id": 456}]], [[{"task_id": None}]]],
# getTaskDescendents response
[[{'1': [], '2': [], '3': [{'weight': 1.0}, {'weight': 1.0}]}]]
]
session.getAverageBuildDuration.return_value = None
get_session.return_value = session
weights = KojiModuleBuilder.get_build_weights(["httpd", "apr"])
assert weights == {"httpd": 2, "apr": 1.5}
expected_calls = [mock.call(456)]
assert session.getTaskDescendents.mock_calls == expected_calls
@patch('module_build_service.builder.KojiModuleBuilder.KojiModuleBuilder.get_session')
def test_get_build_weights_no_build(self, get_session):
session = MagicMock()
session.getLoggedInUser.return_value = {"id": 123}
session.multiCall.side_effect = [
# getPackageID response
[[1], [2]],
# listBuilds response
[[[{"task_id": 456}]], [[]]],
# getTaskDescendents response
[[{'1': [], '2': [], '3': [{'weight': 1.0}, {'weight': 1.0}]}]]
]
session.getAverageBuildDuration.return_value = None
get_session.return_value = session
weights = KojiModuleBuilder.get_build_weights(["httpd", "apr"])
assert weights == {"httpd": 2, "apr": 1.5}
expected_calls = [mock.call(456)]
assert session.getTaskDescendents.mock_calls == expected_calls
@patch('module_build_service.builder.KojiModuleBuilder.KojiModuleBuilder.get_session')
def test_get_build_weights_listBuilds_failed(self, get_session):
session = MagicMock()
session.getLoggedInUser.return_value = {"id": 123}
session.multiCall.side_effect = [[[1], [2]], []]
session.getAverageBuildDuration.return_value = None
get_session.return_value = session
weights = KojiModuleBuilder.get_build_weights(["httpd", "apr"])
assert weights == {"httpd": 1.5, "apr": 1.5}
expected_calls = [mock.call(packageID=1, userID=123, state=1,
queryOpts={'limit': 1, 'order': '-build_id'}),
mock.call(packageID=2, userID=123, state=1,
queryOpts={'limit': 1, 'order': '-build_id'})]
assert session.listBuilds.mock_calls == expected_calls
@patch('module_build_service.builder.KojiModuleBuilder.KojiModuleBuilder.get_session')
def test_get_build_weights_getPackageID_failed(self, get_session):
session = MagicMock()
session.getLoggedInUser.return_value = {"id": 123}
session.multiCall.side_effect = [[], []]
session.getAverageBuildDuration.return_value = None
get_session.return_value = session
weights = KojiModuleBuilder.get_build_weights(["httpd", "apr"])
assert weights == {"httpd": 1.5, "apr": 1.5}
expected_calls = [mock.call("httpd"), mock.call("apr")]
assert session.getPackageID.mock_calls == expected_calls
@patch('module_build_service.builder.KojiModuleBuilder.KojiModuleBuilder.get_session')
def test_get_build_weights_getLoggedInUser_failed(self, get_session):
session = MagicMock()
session.getAverageBuildDuration.return_value = None
get_session.return_value = session
weights = KojiModuleBuilder.get_build_weights(["httpd", "apr"])
assert weights == {"httpd": 1.5, "apr": 1.5}
@pytest.mark.parametrize('blocklist', [False, True])
@pytest.mark.parametrize('custom_whitelist', [False, True])
@pytest.mark.parametrize('repo_include_all', [False, True])
def test_buildroot_connect(self, custom_whitelist, blocklist, repo_include_all):
if blocklist:
mmd = self.module.mmd()
xmd = glib.from_variant_dict(mmd.get_xmd())
xmd["mbs_options"] = {"blocked_packages": ["foo", "nginx"]}
mmd.set_xmd(glib.dict_values(xmd))
self.module.modulemd = mmd.dumps()
if custom_whitelist:
mmd = self.module.mmd()
opts = mmd.get_buildopts()
opts.set_rpm_whitelist(['custom1', 'custom2'])
mmd.set_buildopts(opts)
self.module.modulemd = mmd.dumps()
if repo_include_all is False:
mmd = self.module.mmd()
xmd = glib.from_variant_dict(mmd.get_xmd())
mbs_options = xmd["mbs_options"] if "mbs_options" in xmd.keys() else {}
mbs_options["repo_include_all"] = False
xmd["mbs_options"] = mbs_options
mmd.set_xmd(glib.dict_values(xmd))
self.module.modulemd = mmd.dumps()
builder = FakeKojiModuleBuilder(
owner=self.module.owner, module=self.module, config=conf, tag_name='module-foo',
components=["nginx"])
session = builder.koji_session
groups = OrderedDict()
groups['build'] = set(["unzip"])
groups['srpm-build'] = set(["fedora-release"])
builder.buildroot_connect(groups)
if custom_whitelist:
expected_calls = [
mock.call('module-foo', 'custom1', 'Moe Szyslak'),
mock.call('module-foo', 'custom2', 'Moe Szyslak'),
mock.call('module-foo-build', 'custom1', 'Moe Szyslak'),
mock.call('module-foo-build', 'custom2', 'Moe Szyslak')
]
else:
expected_calls = [
mock.call('module-foo', 'nginx', 'Moe Szyslak'),
mock.call('module-foo-build', 'nginx', 'Moe Szyslak')
]
assert session.packageListAdd.mock_calls == expected_calls
expected_calls = [mock.call('module-foo-build', 'build'),
mock.call('module-foo-build', 'srpm-build')]
assert session.groupListAdd.mock_calls == expected_calls
expected_calls = [mock.call('module-foo-build', 'build', 'unzip'),
mock.call('module-foo-build', 'srpm-build', 'fedora-release')]
assert session.groupPackageListAdd.mock_calls == expected_calls
# packageListBlock should not be called, because we set the block list only when creating
# new Koji tag to prevent overriding it on each buildroot_connect.
expected_calls = []
assert session.packageListBlock.mock_calls == expected_calls
expected_calls = [mock.call('module-foo', arches='i686 armv7hl x86_64',
extra={'mock.package_manager': 'dnf',
'repo_include_all': repo_include_all}),
mock.call('module-foo-build', arches='i686 armv7hl x86_64',
extra={'mock.package_manager': 'dnf',
'repo_include_all': repo_include_all})]
assert session.editTag2.mock_calls == expected_calls
@pytest.mark.parametrize('blocklist', [False, True])
def test_buildroot_connect_create_tag(self, blocklist):
if blocklist:
mmd = self.module.mmd()
xmd = glib.from_variant_dict(mmd.get_xmd())
xmd["mbs_options"] = {"blocked_packages": ["foo", "nginx"]}
mmd.set_xmd(glib.dict_values(xmd))
self.module.modulemd = mmd.dumps()
builder = FakeKojiModuleBuilder(
owner=self.module.owner, module=self.module, config=conf, tag_name='module-foo',
components=["nginx"])
session = builder.koji_session
FakeKojiModuleBuilder.tags = {}
groups = OrderedDict()
groups['build'] = set(["unzip"])
groups['srpm-build'] = set(["fedora-release"])
builder.buildroot_connect(groups)
if blocklist:
expected_calls = [mock.call('module-foo-build', 'foo'),
mock.call('module-foo-build', 'nginx')]
else:
expected_calls = []
assert session.packageListBlock.mock_calls == expected_calls
@patch('module_build_service.builder.KojiModuleBuilder.KojiModuleBuilder.get_session')
def test_get_built_rpms_in_module_build(self, get_session):
session = MagicMock()
session.listTaggedRPMS.return_value = ([
{'build_id': 735939, 'name': 'tar', 'extra': None, 'arch': 'ppc64le',
'buildtime': 1533299221, 'id': 6021394, 'epoch': 2, 'version': '1.30',
'metadata_only': False, 'release': '4.el8+1308+551bfa71',
'buildroot_id': 4321122, 'payloadhash': '0621ab2091256d21c47dcac868e7fc2a',
'size': 878684},
{'build_id': 735939, 'name': 'bar', 'extra': None, 'arch': 'ppc64le',
'buildtime': 1533299221, 'id': 6021394, 'epoch': 2, 'version': '1.30',
'metadata_only': False, 'release': '4.el8+1308+551bfa71',
'buildroot_id': 4321122, 'payloadhash': '0621ab2091256d21c47dcac868e7fc2a',
'size': 878684}], [])
get_session.return_value = session
ret = KojiModuleBuilder.get_built_rpms_in_module_build(self.module)
assert set(ret) == set(
['bar-2:1.30-4.el8+1308+551bfa71', 'tar-2:1.30-4.el8+1308+551bfa71'])
@pytest.mark.parametrize('br_filtered_rpms,expected', (
(
['perl-Tangerine-0.23-1.module+0+d027b723', 'not-in-tag-5.0-1.module+0+d027b723'],
['not-in-tag-5.0-1.module+0+d027b723']
),
(
['perl-Tangerine-0.23-1.module+0+d027b723',
'perl-List-Compare-0.53-5.module+0+d027b723'],
[]
),
(
['perl-Tangerine-0.23-1.module+0+d027b723',
'perl-List-Compare-0.53-5.module+0+d027b723',
'perl-Tangerine-0.23-1.module+0+d027b723'],
[]
),
(
['perl-Tangerine-0.23-1.module+0+diff_module', 'not-in-tag-5.0-1.module+0+d027b723'],
['perl-Tangerine-0.23-1.module+0+diff_module', 'not-in-tag-5.0-1.module+0+d027b723']
),
(
[],
[]
),
))
@patch('module_build_service.builder.KojiModuleBuilder.KojiModuleBuilder.get_session')
def test_get_filtered_rpms_on_self_dep(self, get_session, br_filtered_rpms, expected):
session = MagicMock()
session.listTaggedRPMS.return_value = (
[
{
'build_id': 12345,
'epoch': None,
'name': 'perl-Tangerine',
'release': '1.module+0+d027b723',
'version': '0.23'
},
{
'build_id': 23456,
'epoch': None,
'name': 'perl-List-Compare',
'release': '5.module+0+d027b723',
'version': '0.53'
},
{
'build_id': 34567,
'epoch': None,
'name': 'tangerine',
'release': '3.module+0+d027b723',
'version': '0.22'
}
],
[
{
'build_id': 12345,
'name': 'perl-Tangerine',
'nvr': 'perl-Tangerine-0.23-1.module+0+d027b723'
},
{
'build_id': 23456,
'name': 'perl-List-Compare',
'nvr': 'perl-List-Compare-0.53-5.module+0+d027b723'
},
{
'build_id': 34567,
'name': 'tangerine',
'nvr': 'tangerine-0.22-3.module+0+d027b723'
}
]
)
get_session.return_value = session
reuse_component_init_data()
current_module = module_build_service.models.ModuleBuild.query.get(3)
rv = KojiModuleBuilder._get_filtered_rpms_on_self_dep(current_module, br_filtered_rpms)
assert set(rv) == set(expected)