Files
fm-orchestrator/module_build_service/scheduler/handlers/components.py
Chenxiong Qi 3878affa41 Separate use of database sessions
This patch separates the use of database session in different MBS components
and do not mix them together.

In general, MBS components could be separated as the REST API (implemented
based on Flask) and non-REST API including the backend build workflow
(implemented as a fedmsg consumer on top of fedmsg-hub and running
independently) and library shared by them. As a result, there are two kind of
database session used in MBS, one is created and managed by Flask-SQLAlchemy,
and another one is created from SQLAclhemy Session API directly. The goal of
this patch is to make ensure session object is used properly in the right
place.

All the changes follow these rules:

* REST API related code uses the session object db.session created and
  managed by Flask-SQLAlchemy.
* Non-REST API related code uses the session object created with SQLAlchemy
  Session API. Function make_db_session does that.
* Shared code does not created a new session object as much as possible.
  Instead, it accepts an argument db_session.

The first two rules are applicable to tests as well.

Major changes:

* Switch tests back to run with a file-based SQLite database.
* make_session is renamed to make_db_session and SQLAlchemy connection pool
  options are applied for PostgreSQL backend.
* Frontend Flask related code uses db.session
* Shared code by REST API and backend build workflow accepts SQLAlchemy session
  object as an argument. For example, resolver class is constructed with a
  database session, and some functions accepts an argument for database session.
* Build workflow related code use session object returned from make_db_session
  and ensure db.session is not used.
* Only tests for views use db.session, and other tests use db_session fixture
  to access database.
* All argument name session, that is for database access, are renamed to
  db_session.
* Functions model_tests_init_data, reuse_component_init_data and
  reuse_shared_userspace_init_data, which creates fixture data for
  tests, are converted into pytest fixtures from original function
  called inside setup_method or a test method. The reason of this
  conversion is to use fixture ``db_session`` rather than create a
  new one. That would also benefit the whole test suite to reduce the
  number of SQLAlchemy session objects.

Signed-off-by: Chenxiong Qi <cqi@redhat.com>
2019-07-18 21:26:50 +08:00

178 lines
7.2 KiB
Python

# -*- coding: utf-8 -*-
# Copyright (c) 2016 Red Hat, Inc.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in all
# copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
#
# Written by Ralph Bean <rbean@redhat.com>
""" Handlers for koji component build events on the message bus. """
import logging
import module_build_service.builder
import koji
from module_build_service import models, log, messaging
logging.basicConfig(level=logging.DEBUG)
def _finalize(config, db_session, msg, state):
""" Called whenever a koji build completes or fails. """
# First, find our ModuleBuild associated with this component, if any.
component_build = models.ComponentBuild.from_component_event(db_session, msg)
try:
nvr = "{}-{}-{}".format(msg.build_name, msg.build_version, msg.build_release)
except KeyError:
nvr = None
if not component_build:
log.debug("We have no record of %s" % nvr)
return
log.info("Saw relevant component build of %r from %r." % (nvr, msg.msg_id))
if msg.state_reason:
state_reason = msg.state_reason
elif state != koji.BUILD_STATES["COMPLETE"]:
state_reason = "Failed to build artifact %s in Koji" % (msg.build_name)
else:
state_reason = ""
# Mark the state in the db.
component_build.state = state
component_build.nvr = nvr
component_build.state_reason = state_reason
db_session.commit()
parent = component_build.module_build
# If the macro build failed, then the module is doomed.
if component_build.package == "module-build-macros" and state != koji.BUILD_STATES["COMPLETE"]:
parent.transition(
db_session,
config,
state=models.BUILD_STATES["failed"],
state_reason=state_reason,
failure_type="user",
)
db_session.commit()
return
further_work = []
# If there are no other components still building in a batch,
# we can tag all successfully built components in the batch.
unbuilt_components_in_batch = [
c for c in parent.current_batch()
if c.state == koji.BUILD_STATES["BUILDING"] or not c.state
]
if not unbuilt_components_in_batch:
failed_components_in_batch = [
c for c in parent.current_batch()
if (c.state in [koji.BUILD_STATES["FAILED"], koji.BUILD_STATES["CANCELED"]])
]
built_components_in_batch = [
c for c in parent.current_batch()
if c.state == koji.BUILD_STATES["COMPLETE"]
]
builder = module_build_service.builder.GenericBuilder.create_from_module(
db_session, parent, config
)
if failed_components_in_batch:
log.info(
"Batch done, but not tagging because of failed component builds. Will "
'transition the module to "failed"'
)
state_reason = "Component(s) {} failed to build.".format(
", ".join(c.package for c in failed_components_in_batch))
parent.transition(
db_session,
config,
state=models.BUILD_STATES["failed"],
state_reason=state_reason,
failure_type="user",
)
db_session.commit()
return []
elif not built_components_in_batch:
# If there are no successfully built components in a batch, there is nothing to tag.
# The repository won't be regenerated in this case and therefore we generate fake repo
# change message here.
log.info("Batch done. No component to tag")
further_work += [
messaging.KojiRepoChange(
"components::_finalize: fake msg", builder.module_build_tag["name"])
]
else:
built_component_nvrs_in_batch = [c.nvr for c in built_components_in_batch]
# tag && add to srpm-build group if neccessary
log.info(
"Batch done. Tagging %i component(s) in the build tag."
% len(built_component_nvrs_in_batch)
)
log.debug("%r" % built_component_nvrs_in_batch)
# TODO: install=component_build.build_time_only works here because module-build-macros
# is alone in its batch and the only component with build_time_only set. All other
# batches will have install=False. If we expand to have batches with a mix of
# build_time_only and not components, then this logic will need to change.
builder.buildroot_add_artifacts(
built_component_nvrs_in_batch, install=component_build.build_time_only)
# Do not tag packages which only belong to the build tag to the dest tag
component_nvrs_to_tag_in_dest = [
c.nvr for c in built_components_in_batch
if c.build_time_only is False
]
log.info(
"Tagging %i component(s) in the dest tag." % len(component_nvrs_to_tag_in_dest))
if component_nvrs_to_tag_in_dest:
builder.tag_artifacts(component_nvrs_to_tag_in_dest)
db_session.commit()
elif any([c.state != koji.BUILD_STATES["BUILDING"] for c in unbuilt_components_in_batch]):
# We are not in the middle of the batch building and
# we have some unbuilt components in this batch. We might hit the
# concurrent builds threshold in previous call of continue_batch_build
# done in repos.py:done(...), but because we have just finished one
# build, try to call continue_batch_build again so in case we hit the
# threshold previously, we will submit another build from this batch.
builder = module_build_service.builder.GenericBuilder.create_from_module(
db_session, parent, config)
further_work += module_build_service.utils.continue_batch_build(
config, parent, db_session, builder)
return further_work
def complete(config, db_session, msg):
return _finalize(config, db_session, msg, state=koji.BUILD_STATES["COMPLETE"])
def failed(config, db_session, msg):
return _finalize(config, db_session, msg, state=koji.BUILD_STATES["FAILED"])
def canceled(config, db_session, msg):
return _finalize(config, db_session, msg, state=koji.BUILD_STATES["CANCELED"])