From 5cc2fabc642fe64b8a834cf6613509e5488790e3 Mon Sep 17 00:00:00 2001 From: Estrella Pan Date: Sun, 26 Jul 2026 15:53:14 +0200 Subject: [PATCH] fix(types): correct type-ignore codes and narrow Optional in tests CI mypy (not run locally before) flagged the is_not() ignores as union-attr and the un-narrowed RSSItem | None in the re-enable test. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_019WTfJZ3EzCpY8SLhzXT6Sf --- backend/src/module/database/bangumi.py | 4 ++-- backend/src/test/test_database.py | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/backend/src/module/database/bangumi.py b/backend/src/module/database/bangumi.py index 75499cf6..00ff2d5b 100644 --- a/backend/src/module/database/bangumi.py +++ b/backend/src/module/database/bangumi.py @@ -567,11 +567,11 @@ class BangumiDatabase: from module.models.torrent import Torrent await self.session.execute( - delete(Torrent).where(Torrent.bangumi_id.is_not(None)) # type: ignore[attr-defined] + delete(Torrent).where(Torrent.bangumi_id.is_not(None)) # type: ignore[union-attr] ) await self.session.execute( update(Aria2Gid) - .where(Aria2Gid.bangumi_id.is_not(None)) # type: ignore[attr-defined] + .where(Aria2Gid.bangumi_id.is_not(None)) # type: ignore[union-attr] .values(bangumi_id=None) ) await self.session.execute(delete(Bangumi)) diff --git a/backend/src/test/test_database.py b/backend/src/test/test_database.py index ae0b683d..44cc4bcb 100644 --- a/backend/src/test/test_database.py +++ b/backend/src/test/test_database.py @@ -119,10 +119,12 @@ async def test_rss_add_reenables_disabled_duplicate(db_session): await db.add(RSSItem(url=rss_url, name="Test RSS")) item = await db.search_url(rss_url) + assert item is not None await db.disable(item.id) assert await db.add(RSSItem(url=rss_url, name="Test RSS")) is True item = await db.search_url(rss_url) + assert item is not None assert item.enabled is True