mirror of
https://github.com/jxxghp/MoviePilot.git
synced 2026-11-11 16:21:09 +08:00
520 lines
18 KiB
Python
520 lines
18 KiB
Python
"""分类策略启动迁移、运行时回退和旧 API 发布测试。"""
|
||
|
||
from __future__ import annotations
|
||
|
||
from collections.abc import Callable, Mapping
|
||
from pathlib import Path
|
||
from types import SimpleNamespace
|
||
from typing import Any, TypeVar, cast
|
||
|
||
import pytest
|
||
|
||
from app.api.endpoints import media as media_endpoint
|
||
from app.application.classification.configuration import (
|
||
ClassificationPolicyConfigurationService,
|
||
build_default_classification_policy,
|
||
)
|
||
from app.application.classification.contract import ClassificationPolicyConflictError
|
||
from app.application.classification.runtime import ClassificationRuntime
|
||
from app.schemas.category import (
|
||
ClassificationConditionGroup,
|
||
ClassificationPolicyState,
|
||
)
|
||
from app.schemas.types import SystemConfigKey
|
||
from app.startup.composition import classification as classification_composition
|
||
|
||
T = TypeVar("T")
|
||
|
||
|
||
class _MemoryPolicyStore:
|
||
"""模拟分类状态 CAS 存储并记录成功写入次数。"""
|
||
|
||
def __init__(self, state: ClassificationPolicyState | None = None) -> None:
|
||
"""保存可选初始状态。"""
|
||
self.state = state.model_copy(deep=True) if state else None
|
||
self.write_count = 0
|
||
|
||
def load(self) -> ClassificationPolicyState | None:
|
||
"""返回隔离的状态快照。"""
|
||
return self.state.model_copy(deep=True) if self.state else None
|
||
|
||
def compare_and_set(
|
||
self,
|
||
*,
|
||
expected_revision: int,
|
||
state: ClassificationPolicyState,
|
||
) -> None:
|
||
"""按活动 revision 原子替换状态。"""
|
||
current_revision = self.state.active.revision if self.state else 0
|
||
if current_revision != expected_revision:
|
||
raise ClassificationPolicyConflictError(
|
||
expected_revision=expected_revision,
|
||
current_revision=current_revision,
|
||
)
|
||
self.state = state.model_copy(deep=True)
|
||
self.write_count += 1
|
||
|
||
|
||
class _InlineExecutor:
|
||
"""直接执行启动阶段的同步操作。"""
|
||
|
||
async def run(self, operation: Callable[[], T]) -> T:
|
||
"""执行并返回操作结果。"""
|
||
return operation()
|
||
|
||
|
||
class _SystemConfig:
|
||
"""提供启动组合所需的只读配置键目录。"""
|
||
|
||
def __init__(self, values: Mapping[str, Any]) -> None:
|
||
"""保存配置快照。"""
|
||
self._values = dict(values)
|
||
|
||
def all(self) -> dict[str, Any]:
|
||
"""返回隔离的配置快照。"""
|
||
return dict(self._values)
|
||
|
||
def get(self, key: object) -> Any:
|
||
"""按枚举或字符串键返回启动测试配置值。"""
|
||
normalized = getattr(key, "value", key)
|
||
return self._values.get(str(normalized))
|
||
|
||
def publish_many(self, values: Mapping[object, Any]) -> None:
|
||
"""模拟提交后的系统配置快照发布。"""
|
||
for key, value in values.items():
|
||
normalized = getattr(key, "value", key)
|
||
self._values[str(normalized)] = value
|
||
|
||
|
||
def _published_default_state() -> ClassificationPolicyState:
|
||
"""构造已经持久化的 revision 1 默认策略状态。"""
|
||
policy = build_default_classification_policy().model_copy(update={"revision": 1})
|
||
return ClassificationPolicyState(active=policy)
|
||
|
||
|
||
def _published_legacy_default_state() -> ClassificationPolicyState:
|
||
"""构造旧版本仅含三个未分类兜底的 revision 1 状态。"""
|
||
policy = build_default_classification_policy()
|
||
policy.categories = [
|
||
category
|
||
for category in policy.categories
|
||
if category.id
|
||
in {
|
||
"movie.uncategorized",
|
||
"tv.uncategorized",
|
||
"music.uncategorized",
|
||
}
|
||
]
|
||
policy.rules = []
|
||
return ClassificationPolicyState(active=policy.model_copy(update={"revision": 1}))
|
||
|
||
|
||
@pytest.mark.asyncio # type: ignore[misc]
|
||
async def test_existing_policy_never_reads_legacy_yaml(
|
||
monkeypatch: pytest.MonkeyPatch,
|
||
tmp_path: Path,
|
||
) -> None:
|
||
"""新配置键一旦存在，启动不得再让 category.yaml 影响事实源。"""
|
||
state = _published_default_state()
|
||
store = _MemoryPolicyStore(state)
|
||
legacy_path = tmp_path / "category.yaml"
|
||
legacy_path.write_text("movie: {}\n", encoding="utf-8")
|
||
monkeypatch.setattr(
|
||
classification_composition,
|
||
"SystemConfigClassificationPolicyStore",
|
||
lambda *_args: store,
|
||
)
|
||
monkeypatch.setattr(
|
||
classification_composition,
|
||
"_load_legacy_yaml",
|
||
lambda _path: pytest.fail("存在新策略时不应读取 YAML"),
|
||
)
|
||
system_config = _SystemConfig({SystemConfigKey.MediaClassificationPolicy.value: state.model_dump(mode="json")})
|
||
|
||
composition = await classification_composition.compose_classification(
|
||
executor=cast(Any, _InlineExecutor()),
|
||
settings=cast(Any, SimpleNamespace(CONFIG_PATH=tmp_path)),
|
||
system_config=cast(Any, system_config),
|
||
)
|
||
|
||
assert composition.migrated is False
|
||
assert composition.runtime.require_policy().revision == 1
|
||
assert store.write_count == 0
|
||
|
||
|
||
@pytest.mark.asyncio # type: ignore[misc]
|
||
async def test_untouched_legacy_default_policy_gains_music_rules_once(
|
||
monkeypatch: pytest.MonkeyPatch,
|
||
tmp_path: Path,
|
||
) -> None:
|
||
"""旧版未编辑默认策略应幂等升级，用户已发布的其它策略不得被误判。"""
|
||
state = _published_legacy_default_state()
|
||
store = _MemoryPolicyStore(state)
|
||
system_config = _SystemConfig(
|
||
{
|
||
SystemConfigKey.MediaClassificationPolicy.value: state.model_dump(
|
||
mode="json"
|
||
)
|
||
}
|
||
)
|
||
monkeypatch.setattr(
|
||
classification_composition,
|
||
"SystemConfigClassificationPolicyStore",
|
||
lambda *_args: store,
|
||
)
|
||
|
||
composition = await classification_composition.compose_classification(
|
||
executor=cast(Any, _InlineExecutor()),
|
||
settings=cast(Any, SimpleNamespace(CONFIG_PATH=tmp_path)),
|
||
system_config=cast(Any, system_config),
|
||
)
|
||
|
||
policy = composition.runtime.require_policy()
|
||
assert composition.migrated is True
|
||
assert policy.revision == 2
|
||
assert [
|
||
category.path
|
||
for category in policy.categories
|
||
if category.media_type == "音乐"
|
||
] == [
|
||
["未分类"],
|
||
["Album"],
|
||
["Album", "Compilation"],
|
||
["EP"],
|
||
["Single"],
|
||
]
|
||
assert [rule.id for rule in policy.rules] == [
|
||
"music.compilation.default",
|
||
"music.ep.default",
|
||
"music.single.default",
|
||
"music.album.default",
|
||
]
|
||
assert store.write_count == 1
|
||
|
||
assert store.state is not None
|
||
system_config.publish_many(
|
||
{
|
||
SystemConfigKey.MediaClassificationPolicy: store.state.model_dump(
|
||
mode="json"
|
||
)
|
||
}
|
||
)
|
||
reloaded = await classification_composition.compose_classification(
|
||
executor=cast(Any, _InlineExecutor()),
|
||
settings=cast(Any, SimpleNamespace(CONFIG_PATH=tmp_path)),
|
||
system_config=cast(Any, system_config),
|
||
)
|
||
|
||
assert reloaded.migrated is False
|
||
assert reloaded.runtime.require_policy() == policy
|
||
assert store.write_count == 1
|
||
|
||
|
||
@pytest.mark.asyncio # type: ignore[misc]
|
||
async def test_custom_movie_policy_with_legacy_music_fallback_gains_music_rules(
|
||
monkeypatch: pytest.MonkeyPatch,
|
||
tmp_path: Path,
|
||
) -> None:
|
||
"""其它媒体已自定义时，仍应只升级完全未编辑的旧版音乐兜底。"""
|
||
state = _published_legacy_default_state()
|
||
categories = [
|
||
category.model_copy(
|
||
deep=True,
|
||
update={"name": "我的电影", "path": ["我的电影"]},
|
||
)
|
||
if category.id == "movie.uncategorized"
|
||
else category.model_copy(deep=True)
|
||
for category in state.active.categories
|
||
]
|
||
state = ClassificationPolicyState(
|
||
active=state.active.model_copy(
|
||
deep=True,
|
||
update={"categories": categories},
|
||
)
|
||
)
|
||
store = _MemoryPolicyStore(state)
|
||
system_config = _SystemConfig(
|
||
{
|
||
SystemConfigKey.MediaClassificationPolicy.value: state.model_dump(
|
||
mode="json"
|
||
)
|
||
}
|
||
)
|
||
monkeypatch.setattr(
|
||
classification_composition,
|
||
"SystemConfigClassificationPolicyStore",
|
||
lambda *_args: store,
|
||
)
|
||
|
||
composition = await classification_composition.compose_classification(
|
||
executor=cast(Any, _InlineExecutor()),
|
||
settings=cast(Any, SimpleNamespace(CONFIG_PATH=tmp_path)),
|
||
system_config=cast(Any, system_config),
|
||
)
|
||
|
||
policy = composition.runtime.require_policy()
|
||
assert composition.migrated is True
|
||
assert policy.revision == 2
|
||
assert next(
|
||
category for category in policy.categories if category.id == "movie.uncategorized"
|
||
).path == ["我的电影"]
|
||
assert [
|
||
category.id for category in policy.categories if category.media_type == "音乐"
|
||
] == [
|
||
"music.uncategorized",
|
||
"music.album",
|
||
"music.compilation",
|
||
"music.ep",
|
||
"music.single",
|
||
]
|
||
assert store.write_count == 1
|
||
|
||
|
||
@pytest.mark.asyncio # type: ignore[misc]
|
||
async def test_edited_legacy_default_policy_is_not_automatically_changed(
|
||
monkeypatch: pytest.MonkeyPatch,
|
||
tmp_path: Path,
|
||
) -> None:
|
||
"""即使仍是 revision 1，用户改过的默认策略也不得被启动升级覆盖。"""
|
||
state = _published_legacy_default_state()
|
||
categories = [
|
||
category.model_copy(
|
||
deep=True,
|
||
update={"name": "自定义音乐", "path": ["自定义音乐"]},
|
||
)
|
||
if category.id == "music.uncategorized"
|
||
else category.model_copy(deep=True)
|
||
for category in state.active.categories
|
||
]
|
||
state = ClassificationPolicyState(
|
||
active=state.active.model_copy(
|
||
deep=True,
|
||
update={"categories": categories},
|
||
)
|
||
)
|
||
store = _MemoryPolicyStore(state)
|
||
system_config = _SystemConfig(
|
||
{
|
||
SystemConfigKey.MediaClassificationPolicy.value: state.model_dump(
|
||
mode="json"
|
||
)
|
||
}
|
||
)
|
||
monkeypatch.setattr(
|
||
classification_composition,
|
||
"SystemConfigClassificationPolicyStore",
|
||
lambda *_args: store,
|
||
)
|
||
|
||
composition = await classification_composition.compose_classification(
|
||
executor=cast(Any, _InlineExecutor()),
|
||
settings=cast(Any, SimpleNamespace(CONFIG_PATH=tmp_path)),
|
||
system_config=cast(Any, system_config),
|
||
)
|
||
|
||
assert composition.migrated is False
|
||
assert composition.runtime.require_policy() == state.active
|
||
assert store.write_count == 0
|
||
|
||
|
||
@pytest.mark.asyncio # type: ignore[misc]
|
||
async def test_absent_policy_migrates_yaml_once_without_rewriting_file(
|
||
monkeypatch: pytest.MonkeyPatch,
|
||
tmp_path: Path,
|
||
) -> None:
|
||
"""合法旧配置只发布 revision 1，原 YAML 内容保持不变。"""
|
||
content = """movie:\n 动画电影:\n genre_ids: '16'\n 外语电影:\ntv:\n 未分类:\n"""
|
||
legacy_path = tmp_path / "category.yaml"
|
||
legacy_path.write_text(content, encoding="utf-8")
|
||
store = _MemoryPolicyStore()
|
||
monkeypatch.setattr(
|
||
classification_composition,
|
||
"SystemConfigClassificationPolicyStore",
|
||
lambda *_args: store,
|
||
)
|
||
|
||
composition = await classification_composition.compose_classification(
|
||
executor=cast(Any, _InlineExecutor()),
|
||
settings=cast(Any, SimpleNamespace(CONFIG_PATH=tmp_path)),
|
||
system_config=cast(Any, _SystemConfig({})),
|
||
)
|
||
|
||
assert composition.migrated is True
|
||
assert composition.runtime.require_policy().revision == 1
|
||
assert store.write_count == 1
|
||
assert legacy_path.read_text(encoding="utf-8") == content
|
||
|
||
|
||
@pytest.mark.asyncio
|
||
async def test_large_legacy_enumerations_migrate_and_reload_without_losing_values(
|
||
monkeypatch: pytest.MonkeyPatch,
|
||
tmp_path: Path,
|
||
) -> None:
|
||
"""复现 56/31 个旧枚举值的升级场景，验证首次发布、重启和旧接口均保留全部值。"""
|
||
languages = ",".join(f"language{index}" for index in range(26))
|
||
countries = ",".join(f"country{index}" for index in range(30))
|
||
content = (
|
||
f"movie:\n 欧美电影:\n original_language: '{languages}'\n"
|
||
f" production_countries: '{countries}'\n 未分类:\n"
|
||
f"tv:\n 欧美漫:\n genre_ids: '16'\n origin_country: '{countries}'\n 未分类:\n"
|
||
)
|
||
legacy_path = tmp_path / "category.yaml"
|
||
legacy_path.write_text(content, encoding="utf-8")
|
||
store = _MemoryPolicyStore()
|
||
monkeypatch.setattr(classification_composition, "SystemConfigClassificationPolicyStore", lambda *_args: store)
|
||
system_config = _SystemConfig({})
|
||
|
||
composition = await classification_composition.compose_classification(
|
||
executor=cast(Any, _InlineExecutor()),
|
||
settings=cast(Any, SimpleNamespace(CONFIG_PATH=tmp_path)),
|
||
system_config=cast(Any, system_config),
|
||
)
|
||
|
||
assert composition.migrated is True
|
||
policy = composition.runtime.require_policy()
|
||
assert policy.revision == 1
|
||
legacy_rules = [rule for rule in policy.rules if "音乐" not in rule.media_types]
|
||
assert len(policy.rules) == 6
|
||
assert len(legacy_rules) == 2
|
||
for rule in legacy_rules:
|
||
assert isinstance(rule.when, ClassificationConditionGroup)
|
||
assert rule.when.all is not None and len(rule.when.all) == 2
|
||
assert store.state is not None
|
||
system_config.publish_many({SystemConfigKey.MediaClassificationPolicy: store.state.model_dump(mode="json")})
|
||
reloaded = await classification_composition.compose_classification(
|
||
executor=cast(Any, _InlineExecutor()),
|
||
settings=cast(Any, SimpleNamespace(CONFIG_PATH=tmp_path)),
|
||
system_config=cast(Any, system_config),
|
||
)
|
||
|
||
assert reloaded.migrated is False
|
||
assert reloaded.runtime.require_policy() == policy
|
||
projected = reloaded.runtime.legacy_config().model_dump(exclude_none=True)
|
||
assert projected["movie"]["欧美电影"]["original_language"] == languages
|
||
assert projected["movie"]["欧美电影"]["production_countries"] == countries
|
||
assert projected["tv"]["欧美漫"]["origin_country"] == countries
|
||
assert store.write_count == 1
|
||
assert legacy_path.read_text(encoding="utf-8") == content
|
||
|
||
|
||
@pytest.mark.asyncio
|
||
async def test_publish_validation_failure_preserves_legacy_runtime_without_writes(
|
||
monkeypatch: pytest.MonkeyPatch,
|
||
tmp_path: Path,
|
||
) -> None:
|
||
"""真正超出叶子上限的不同字段保留错误诊断和旧配置，不得中断启动或写入新策略。"""
|
||
content = "movie:\n 复杂规则:\n" + "".join(f" field{index}: 'X'\n" for index in range(31))
|
||
legacy_path = tmp_path / "category.yaml"
|
||
legacy_path.write_text(content, encoding="utf-8")
|
||
store = _MemoryPolicyStore()
|
||
monkeypatch.setattr(classification_composition, "SystemConfigClassificationPolicyStore", lambda *_args: store)
|
||
|
||
composition = await classification_composition.compose_classification(
|
||
executor=cast(Any, _InlineExecutor()),
|
||
settings=cast(Any, SimpleNamespace(CONFIG_PATH=tmp_path)),
|
||
system_config=cast(Any, _SystemConfig({})),
|
||
)
|
||
|
||
assert composition.migrated is False
|
||
assert composition.runtime.active_policy() is None
|
||
assert any(issue.code == "max_conditions_exceeded" for issue in composition.runtime.diagnostics())
|
||
assert "复杂规则" in (composition.runtime.legacy_config().movie or {})
|
||
assert store.write_count == 0
|
||
assert store.state is None
|
||
assert legacy_path.read_text(encoding="utf-8") == content
|
||
|
||
|
||
@pytest.mark.asyncio # type: ignore[misc]
|
||
async def test_invalid_legacy_config_keeps_runtime_uninitialized_and_writes_nothing(
|
||
monkeypatch: pytest.MonkeyPatch,
|
||
tmp_path: Path,
|
||
) -> None:
|
||
"""无法无损表达的旧字段阻止自动发布，并保留结构化诊断。"""
|
||
(tmp_path / "category.yaml").write_text(
|
||
"movie:\n 错误规则:\n Bad/Field: value\ntv:\n 未分类:\n",
|
||
encoding="utf-8",
|
||
)
|
||
store = _MemoryPolicyStore()
|
||
monkeypatch.setattr(
|
||
classification_composition,
|
||
"SystemConfigClassificationPolicyStore",
|
||
lambda *_args: store,
|
||
)
|
||
|
||
composition = await classification_composition.compose_classification(
|
||
executor=cast(Any, _InlineExecutor()),
|
||
settings=cast(Any, SimpleNamespace(CONFIG_PATH=tmp_path)),
|
||
system_config=cast(Any, _SystemConfig({})),
|
||
)
|
||
|
||
assert composition.migrated is False
|
||
assert composition.runtime.active_policy() is None
|
||
assert any(issue.severity == "error" for issue in composition.runtime.diagnostics())
|
||
assert store.write_count == 0
|
||
|
||
|
||
def test_runtime_compat_projection_is_read_only_and_includes_music_categories() -> None:
|
||
"""运行时兼容门面只投影旧结构，并让分类列表包含音乐。"""
|
||
store = _MemoryPolicyStore()
|
||
service = ClassificationPolicyConfigurationService(store)
|
||
service.initialize()
|
||
runtime = ClassificationRuntime(service)
|
||
|
||
categories = runtime.media_categories().root
|
||
|
||
assert categories["音乐"] == [
|
||
"未分类",
|
||
"Album",
|
||
"Album / Compilation",
|
||
"EP",
|
||
"Single",
|
||
]
|
||
assert runtime.legacy_config().movie == {}
|
||
assert store.write_count == 1
|
||
|
||
|
||
@pytest.mark.asyncio # type: ignore[misc]
|
||
async def test_legacy_category_get_endpoints_use_classification_runtime_only(
|
||
monkeypatch: pytest.MonkeyPatch,
|
||
) -> None:
|
||
"""旧分类只读端点不得继续调度 TMDB 模块。"""
|
||
store = _MemoryPolicyStore()
|
||
service = ClassificationPolicyConfigurationService(store)
|
||
service.initialize()
|
||
runtime = ClassificationRuntime(service)
|
||
monkeypatch.setattr(
|
||
media_endpoint,
|
||
"MediaChain",
|
||
lambda: pytest.fail("旧分类端点不应再调用 MediaChain"),
|
||
)
|
||
|
||
before = media_endpoint.get_category_config(object(), runtime)
|
||
categories = await media_endpoint.category(object(), runtime)
|
||
|
||
assert before.success is True
|
||
assert before.data == {"movie": {}, "tv": {}}
|
||
assert categories.root == {
|
||
"电影": ["未分类"],
|
||
"电视剧": ["未分类"],
|
||
"音乐": [
|
||
"未分类",
|
||
"Album",
|
||
"Album / Compilation",
|
||
"EP",
|
||
"Single",
|
||
],
|
||
}
|
||
|
||
|
||
def test_legacy_category_config_route_has_no_write_method() -> None:
|
||
"""旧分类配置端点只保留 GET 投影，不再暴露任何写方法。"""
|
||
methods = {
|
||
method
|
||
for route in media_endpoint.router.routes
|
||
if route.path == "/category/config"
|
||
for method in route.methods or set()
|
||
}
|
||
|
||
assert methods == {"GET"}
|
||
assert not hasattr(media_endpoint, "save_category_config")
|