Files
MoviePilot/tests/test_chain_layering.py
jxxghp 7e851dbfa7 refactor(chain): 处理链功能域 mixin 化,清理未使用导入并根治兼容层循环导入
- ChainBase 拆分为 RecognitionMixin/MessageProcessingMixin/NotificationMixin
- TransferChain 拆分为 7 个功能 mixin(_mixins.py),SubscribeChain 音乐订阅域拆出 _music.py
- 斜杠命令交互四件套收敛为 InteractionChainMixin 委托,会话管理器移至 application 层,chain 层不再 re-export
- 模块基础类收敛到 app/modules/_base(notification/mediaserver 语义重命名)
- 清理 app/chain/__init__.py 24 个未使用导入,修正 49 处测试 patch 目标到实际命名空间
- 兼容层 legacy 符号不再并入 __all__,根治 schemas 初始化反向拉起 application.transfer 的循环导入
- 修复 bangumi 集数为字符串时 set_bangumi_info 抛 TypeError
- 新增重复代码等架构门禁测试;capability 清单校验排除下划线内部目录
2026-08-16 16:30:16 +08:00

140 lines
4.8 KiB
Python
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
"""处理链模块分层约束测试。"""
import ast
from pathlib import Path
PROJECT_ROOT = Path(__file__).resolve().parents[1]
CHAIN_ROOT = PROJECT_ROOT / "app" / "chain"
LEGACY_MUSIC_SCAN_ROOTS = (
PROJECT_ROOT / "app",
PROJECT_ROOT / "scripts",
)
MUSIC_SOURCE_CHAIN_FILES = (
"acoustid.py",
"douban.py",
"listenbrainz.py",
"lrclib.py",
"musicbrainz.py",
"theaudiodb.py",
)
def _imported_modules(path: Path) -> set[str]:
"""解析源码中的导入模块,包含函数内部的延迟导入。"""
tree = ast.parse(path.read_text(encoding="utf-8-sig"))
modules: set[str] = set()
for node in ast.walk(tree):
if isinstance(node, ast.ImportFrom) and node.module:
modules.add(node.module)
elif isinstance(node, ast.Import):
modules.update(alias.name for alias in node.names)
return modules
def _inherited_recognize_calls(path: Path) -> list[tuple[int, str]]:
"""查找业务链通过 self 隐式调用媒体识别入口的位置。"""
tree = ast.parse(path.read_text(encoding="utf-8"))
calls: list[tuple[int, str]] = []
for node in ast.walk(tree):
if not isinstance(node, ast.Call) or not isinstance(node.func, ast.Attribute):
continue
owner = node.func.value
if (
isinstance(owner, ast.Name)
and owner.id == "self"
and node.func.attr in {"recognize_media", "async_recognize_media"}
):
calls.append((node.lineno, node.func.attr))
return calls
def test_chain_base_does_not_import_concrete_chains() -> None:
"""基础链不得反向导入任何具体处理链。"""
imports = _imported_modules(CHAIN_ROOT / "__init__.py")
# 下划线前缀的内部模块(_messaging/_recognition 等)是 ChainBase 的
# 功能域 mixin,不是具体处理链,允许导入
assert not {
module
for module in imports
if module.startswith("app.chain.")
and not module.removeprefix("app.chain.").startswith("_")
}
def test_legacy_music_chain_is_removed() -> None:
"""聚合全部音乐职责的旧 MusicChain 文件和导入不得重新出现。"""
assert not (CHAIN_ROOT / "music.py").exists()
violations = {
str(path.relative_to(PROJECT_ROOT)): sorted(
module for module in _imported_modules(path) if module == "app.chain.music"
)
for root in LEGACY_MUSIC_SCAN_ROOTS
for path in root.rglob("*.py")
if "plugins" not in path.parts # 插件目录由插件仓自治,跳过
if "app.chain.music" in _imported_modules(path)
}
assert not violations
def test_music_source_chains_do_not_depend_on_public_orchestration_chains() -> None:
"""音乐数据源链不得反向依赖识别、刮削、搜索或推荐编排链。"""
forbidden = {
"app.chain.media",
"app.chain.recommend",
"app.chain.scraping",
"app.chain.search",
}
violations = {
filename: sorted(_imported_modules(CHAIN_ROOT / filename).intersection(forbidden))
for filename in MUSIC_SOURCE_CHAIN_FILES
if _imported_modules(CHAIN_ROOT / filename).intersection(forbidden)
}
assert not violations
def test_media_chain_excludes_scraping_and_music_exploration_methods() -> None:
"""MediaChain 只保留公共识别与详情路由,不得重新承接刮削或音乐探索职责。"""
path = CHAIN_ROOT / "media.py"
tree = ast.parse(path.read_text(encoding="utf-8"))
method_names = {
node.name
for node in ast.walk(tree)
if isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef))
}
forbidden_methods = {
"async_get_doubaninfo_by_bangumiid",
"async_get_doubaninfo_by_tmdbid",
"async_get_tmdbinfo_by_bangumiid",
"async_get_tmdbinfo_by_doubanid",
"scrape_metadata",
"scrape_metadata_event",
"scrape_music_metadata",
"get_doubaninfo_by_bangumiid",
"get_doubaninfo_by_tmdbid",
"get_music_lyrics",
"get_tmdbinfo_by_bangumiid",
"get_tmdbinfo_by_doubanid",
"async_get_music_lyrics",
"music_chart",
"async_music_chart",
"music_discover",
"async_music_discover",
"async_music_fresh_releases",
}
assert not method_names.intersection(forbidden_methods)
assert "app.chain.scraping" not in _imported_modules(path)
def test_business_chains_delegate_recognition_to_media_chain() -> None:
"""搜索、订阅、下载和转移链必须显式委托媒体识别编排层。"""
violations = {
name: calls
for name in ("search.py", "subscribe.py", "download.py", "transfer.py")
if (calls := _inherited_recognize_calls(CHAIN_ROOT / name))
}
assert not violations