From 0453fa2e57c4022f13d52c0a5f3c8ed2418cd2e1 Mon Sep 17 00:00:00 2001 From: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Date: Mon, 19 Dec 2022 13:37:56 +0200 Subject: [PATCH] Not needed to verify on nodeport services, they are not even shows when hostNet is enabled --- charts/ix-chart/2212.0.1/questions.yaml | 1 + charts/ix-chart/2212.0.1/templates/service.yaml | 4 ---- test/ix-chart/2212.0.1/questions.yaml | 1 + test/ix-chart/2212.0.1/templates/service.yaml | 4 ---- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/charts/ix-chart/2212.0.1/questions.yaml b/charts/ix-chart/2212.0.1/questions.yaml index 1f5ead90ab..bc46ac6c5d 100644 --- a/charts/ix-chart/2212.0.1/questions.yaml +++ b/charts/ix-chart/2212.0.1/questions.yaml @@ -426,6 +426,7 @@ questions: schema: type: int required: true + min: 9000 max: 65535 - variable: protocol label: "Protocol" diff --git a/charts/ix-chart/2212.0.1/templates/service.yaml b/charts/ix-chart/2212.0.1/templates/service.yaml index dfbe6ee748..4b0237d016 100644 --- a/charts/ix-chart/2212.0.1/templates/service.yaml +++ b/charts/ix-chart/2212.0.1/templates/service.yaml @@ -1,5 +1,4 @@ {{- if and (.Values.portForwardingList) (eq (include "hostNetworkingConfiguration" .) "false") }} -{{- $hostNet := .Values.hostNetwork }} apiVersion: v1 kind: Service metadata: @@ -10,9 +9,6 @@ spec: type: NodePort ports: {{- range $index, $config := .Values.portForwardingList }} - {{- if and (not $hostNet) (lt (int $config.nodePort) 9000) }} - {{- fail (printf "Port (%s) is too low. Minimum allowed port is 9000." ($config.nodePort | toString)) }} - {{- end }} - port: {{ $config.containerPort }} targetPort: {{ $config.containerPort }} protocol: {{ $config.protocol }} diff --git a/test/ix-chart/2212.0.1/questions.yaml b/test/ix-chart/2212.0.1/questions.yaml index 1f5ead90ab..fc77ea49e1 100644 --- a/test/ix-chart/2212.0.1/questions.yaml +++ b/test/ix-chart/2212.0.1/questions.yaml @@ -77,6 +77,7 @@ questions: description: "Specify port to be used for Portal access" schema: type: int + min: 9000 max: 65535 default: 15000 diff --git a/test/ix-chart/2212.0.1/templates/service.yaml b/test/ix-chart/2212.0.1/templates/service.yaml index dfbe6ee748..4b0237d016 100644 --- a/test/ix-chart/2212.0.1/templates/service.yaml +++ b/test/ix-chart/2212.0.1/templates/service.yaml @@ -1,5 +1,4 @@ {{- if and (.Values.portForwardingList) (eq (include "hostNetworkingConfiguration" .) "false") }} -{{- $hostNet := .Values.hostNetwork }} apiVersion: v1 kind: Service metadata: @@ -10,9 +9,6 @@ spec: type: NodePort ports: {{- range $index, $config := .Values.portForwardingList }} - {{- if and (not $hostNet) (lt (int $config.nodePort) 9000) }} - {{- fail (printf "Port (%s) is too low. Minimum allowed port is 9000." ($config.nodePort | toString)) }} - {{- end }} - port: {{ $config.containerPort }} targetPort: {{ $config.containerPort }} protocol: {{ $config.protocol }}