From 4ea3f015f6b4ae632deeb2d62d4e177cd5e666ef Mon Sep 17 00:00:00 2001 From: sonicaj Date: Mon, 6 Sep 2021 15:31:50 +0500 Subject: [PATCH] Update nextcloud upgrade strategy For nextcloud tags, 21.1 is greater then 21.1.0 so we reverse sort the tags list before doing semantic versioning as in semantic versioning both tags are equal and when we reverse sort it, 21.1 is prioritised over 21.1.0. --- charts/nextcloud/upgrade_strategy | 3 ++- test/nextcloud/upgrade_strategy | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/charts/nextcloud/upgrade_strategy b/charts/nextcloud/upgrade_strategy index adafa41868..d98b6bcd7a 100755 --- a/charts/nextcloud/upgrade_strategy +++ b/charts/nextcloud/upgrade_strategy @@ -7,7 +7,8 @@ from catalog_update.upgrade_strategy import semantic_versioning def newer_mapping(image_tags): key = list(image_tags.keys())[0] - version = semantic_versioning(image_tags[key]) + # 21.1 is greater then 21.1.0 so we reverse sort bfeore doing semantic versioning + version = semantic_versioning(sorted(image_tags[key], reverse=True)) if not version: return {} diff --git a/test/nextcloud/upgrade_strategy b/test/nextcloud/upgrade_strategy index adafa41868..d98b6bcd7a 100755 --- a/test/nextcloud/upgrade_strategy +++ b/test/nextcloud/upgrade_strategy @@ -7,7 +7,8 @@ from catalog_update.upgrade_strategy import semantic_versioning def newer_mapping(image_tags): key = list(image_tags.keys())[0] - version = semantic_versioning(image_tags[key]) + # 21.1 is greater then 21.1.0 so we reverse sort bfeore doing semantic versioning + version = semantic_versioning(sorted(image_tags[key], reverse=True)) if not version: return {}