From d30cedce3c4eec14bd43141298bd7897c85a6560 Mon Sep 17 00:00:00 2001 From: Waqar Ahmed Date: Fri, 29 Jan 2021 21:16:54 +0500 Subject: [PATCH] Update commit logic --- update_dependencies | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/update_dependencies b/update_dependencies index d09ac6b498..1b809b395f 100755 --- a/update_dependencies +++ b/update_dependencies @@ -41,7 +41,7 @@ def report_result(): for index, item in enumerate(ITEMS): index += 1 data = ITEMS[item] - print(f'\n\n[\033[94mINFO\x1B[0m]\t{index}) {item}') + print(f'\n[\033[94mINFO\x1B[0m]\t{index}) {item}') if data['success']: print( f'[\033[92mOK\x1B[0m]\t - Successfully updated dependencies for {", ".join(data["success"])} versions' @@ -65,11 +65,12 @@ def update_train_charts(train_path, commit): report_result() - if commit: + if commit and any(ITEMS[item]['success'] for item in ITEMS): if any(ITEMS[item]['error'] for item in ITEMS): print(f'[\033[91mFAILED\x1B[0m]\tNot committing changes as failures detected') else: - commit_msg = 'Updated catalog item dependencies\nFollowing items were updated:\n' + commit_msg = f'Updated catalog item dependencies ({train_path.rsplit("/", 1)[0]} train)\n' \ + 'Following items were updated:\n' for item in ITEMS: commit_msg += f'Updated {item} ({", ".join(ITEMS[item]["success"])} versions)\n\n'