From 94f2291f10d345130e55b8eed38eb9d3e3d9eff4 Mon Sep 17 00:00:00 2001
From: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Date: Sun, 9 Jan 2022 14:04:03 +0200
Subject: [PATCH] fix(openvscode-server): allow rootfs access, make token
 required (#1611)

* fix(openvscode-server): allow rootfs access, make token required

* doesn't work like that
---
 charts/stable/openvscode-server/Chart.yaml     |  2 +-
 charts/stable/openvscode-server/questions.yaml | 11 +++++++++--
 charts/stable/openvscode-server/values.yaml    |  1 +
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/charts/stable/openvscode-server/Chart.yaml b/charts/stable/openvscode-server/Chart.yaml
index bf87cf25c62..1a0c6d0c85c 100644
--- a/charts/stable/openvscode-server/Chart.yaml
+++ b/charts/stable/openvscode-server/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 kubeVersion: ">=1.16.0-0"
 name: openvscode-server
-version: 0.0.11
+version: 0.0.12
 appVersion: "1.63.2"
 description: Openvscode-server provides a version of VS Code that runs a server on a remote machine.
 type: application
diff --git a/charts/stable/openvscode-server/questions.yaml b/charts/stable/openvscode-server/questions.yaml
index 9286f1e21a5..85658c379ed 100644
--- a/charts/stable/openvscode-server/questions.yaml
+++ b/charts/stable/openvscode-server/questions.yaml
@@ -85,6 +85,7 @@ questions:
           schema:
             type: string
             private: true
+            required: true
             default: ""
         - variable: SUDO_PASSWORD
           label: "SUDO_PASSWORD"
@@ -99,7 +100,13 @@ questions:
       type: dict
       attrs:
 # Include{fixedEnv}
-
+        - variable: PUID
+          label: "PUID"
+          description: "Sets the PUID env var"
+          schema:
+            type: int
+            required: true
+            default: 568
 # Include{containerConfig}
 
   - variable: service
@@ -280,7 +287,7 @@ questions:
                 label: "ReadOnly Root Filesystem"
                 schema:
                   type: boolean
-                  default: true
+                  default: false
               - variable: allowPrivilegeEscalation
                 label: "Allow Privilege Escalation"
                 schema:
diff --git a/charts/stable/openvscode-server/values.yaml b/charts/stable/openvscode-server/values.yaml
index 0ebeb8eb848..1c4363647f1 100644
--- a/charts/stable/openvscode-server/values.yaml
+++ b/charts/stable/openvscode-server/values.yaml
@@ -5,6 +5,7 @@ image:
 
 securityContext:
   runAsNonRoot: false
+  readOnlyRootFilesystem: false
 
 podSecurityContext:
   runAsUser: 0